From patchwork Tue Jan 16 11:58:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Patchwork-Id: 10166603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AF69A601E7 for ; Tue, 16 Jan 2018 12:01:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EF082855E for ; Tue, 16 Jan 2018 12:01:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D5C728179; Tue, 16 Jan 2018 12:01:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C95312856D for ; Tue, 16 Jan 2018 12:01:12 +0000 (UTC) Received: from localhost ([::1]:59344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebPvU-0005n4-1V for patchwork-qemu-devel@patchwork.kernel.org; Tue, 16 Jan 2018 07:01:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebPsb-0003De-Us for qemu-devel@nongnu.org; Tue, 16 Jan 2018 06:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebPsa-0006hu-Hf for qemu-devel@nongnu.org; Tue, 16 Jan 2018 06:58:14 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:42260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebPsa-0006h8-7I for qemu-devel@nongnu.org; Tue, 16 Jan 2018 06:58:12 -0500 Received: by mail-wr0-x242.google.com with SMTP id e41so14544773wre.9 for ; Tue, 16 Jan 2018 03:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=akfE+DQT/a/HFyG5pC+fgPSZkHs6dVM117vGzu1eRT4=; b=HJdOKu5h1hMV+kxFsRmYykgeMNcBuSDWOckJV4ISukMLyaf2fkkzMTA8We1tZEbEVP 5XFjDOQOoeRQiDIdsAhvsTexjy7f6T6lIXayHk38I+zSXZaDx2amBuyZxAAkbGcImH0S JS0VJepY0gEQR/lDVuZRfwRvJskZZcuMpHtUhX6xON1VZ8VjALYskYg0ti797em32VYl fcpn3IWeQtEcPvdyzZIVnLjGX7PavplpU6/dyfiM18X/2JgxNc8ucoHZ2QRAgIfSV33a 0CHJ62WIer7jMKS7ixQw7OYiYRGNspXzhGaVdtpmVTE9lMQs7tWO5RlKGADdcL3G0ITR 94SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=akfE+DQT/a/HFyG5pC+fgPSZkHs6dVM117vGzu1eRT4=; b=ZRtuONXL2eUPcmlOJpZ88e9XoDzTfJyONCYoWrZI/i2lERuGX1sEy0XmH0gie+xwur KN21LEwPo7xj0Vr6z/U0aCiOAyKksxZxVLuS/TkwJm4I8WWH+9bUKFKILHgyEbHaXYTe jwBk3VUfIxA2/9OGO27aEd4/SJBQi/jl9vZajC8+EyHEJwSalFDNG7LalOaNjaOfrzK5 lsc1nrwgg8lAigvoOq55dwUNJrs9s3KN6eyhM1xAQYPrJ1UhVqvptxacYiU3X6wjLXlP mq2XuSJgOP8Kl/Jgj0bFtWfoL37qD2xajFeyTSpRuvvknl3ncuSJf62XFm4Ku7gitUP4 k8vg== X-Gm-Message-State: AKGB3mL3x3gpVnDUqJTIswf7RdfPlvlv3NV2kZQ+H3+N/uiWNBKhqoVA saEZvX3iRPCcV3HJfpEYBNw8hqVtUfGiDh+Kmi/pbKdE X-Google-Smtp-Source: ACJfBosR+eOLQL30ll0P8d4BDYRKLv97X07f14fTRo6M5Vmd/QBQ84nOqzwW+FxzI+zYN/B/a/RY/vC13HqAsEoH1So= X-Received: by 10.223.175.102 with SMTP id z93mr24179344wrc.48.1516103890853; Tue, 16 Jan 2018 03:58:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.199.143 with HTTP; Tue, 16 Jan 2018 03:58:10 -0800 (PST) In-Reply-To: References: <1516059302-7169-1-git-send-email-pbonzini@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 16 Jan 2018 12:58:10 +0100 Message-ID: To: Peter Maydell X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: Re: [Qemu-devel] [PULL v3 00/53] Misc changes for 2017-01-12 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Developers Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi On Tue, Jan 16, 2018 at 12:25 PM, Peter Maydell wrote: > On 15 January 2018 at 23:35, Paolo Bonzini wrote: >> The following changes since commit 997eba28a3ed5400a80f754bf3a1c8044b75b9ff: >> >> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20180111' into staging (2018-01-11 14:34:41 +0000) >> >> are available in the git repository at: >> >> >> git://github.com/bonzini/qemu.git tags/for-upstream >> >> for you to fetch changes up to ff9adba50bf8a4c080b8aee9be2314ef179a7b5f: >> >> ucontext: annotate coroutine stack for ASAN (2018-01-12 15:21:14 +0100) >> >> ---------------------------------------------------------------- >> * QemuMutex tracing improvements (Alex) >> * ram_addr_t optimization (David) >> * SCSI fixes (Fam, Stefan, me) >> * do {} while (0) fixes (Eric) >> * KVM fix for PMU (Jan) >> * memory leak fixes from ASAN (Marc-André) >> * migration fix for HPET, icount, loadvm (Maria, Pavel) >> * hflags fixes (me, Tao) >> * block/iscsi uninitialized variable (Peter L.) >> * full support for GMainContexts in character devices (Peter Xu) >> * more boot-serial-test (Thomas) >> * Memory leak fix (Zhecheng) > > Various build failures, I'm afraid: > damn, sorry.. > x86-64/Linux/gcc: > > configure produces an error message: > > ERROR: ASAN build enabled, but ASAN header is too old. > Without code annotation, the report may be inferior. > > even though this configure did not explicitly request ASAN. > Then configure seems to exit successfully anyway, since the > build proceeds. ASAN is enabled by default if available when --enable-debug. We could add more flags if that helps. > For some reason the build creates config-target.h a lot: > > make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/alldbg' > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > GEN config-target.h > [snip more lines] > GEN config-target.h > GEN config-target.h > make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/all' > GIT ui/keycodemapdb dtc capstone > make: Leaving directory '/home/petmay01/linaro/qemu-for-merges/build/all' > make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/all' > GEN qapi-event.h > [etc] One per target no? (the build should be more silent than before) > > Then it runs configure again, this time without the ERROR message, > and eventually fails with: > > CC hw/display/exynos4210_fimd.o > /home/petmay01/linaro/qemu-for-merges/hw/display/exynos4210_fimd.c: In > function ‘fimd_get_buffer_id’: > /home/petmay01/linaro/qemu-for-merges/hw/display/exynos4210_fimd.c:1105:5: > error: case label does not reduce to an integer constant > case FIMD_WINCON_BUF2_STAT: never saw that error, hmm interesting. This is related to -fsanitize=address ? Is this on Debian stable? > ^ > > On sparc64 host configure fails: > > config-host.mak is out-of-date, running configure > > ERROR: configure test passed without -Werror but failed with -Werror. > This is probably a bug in the configure script. The failing command > will be at the bottom of config.log. > You can run configure with --disable-werror to bypass this check. > > The bottom of config.log is: > > cc -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 > -I/usr/lib/sparc64-linux-gnu/glib-2.0/include -DNCURSES_WIDECHAR > -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/usr/include/ncursesw -m64 > -mcpu=ultrasparc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall > -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing > -fno-common -fwrapv -Wexpansion-to-defined -Wendif-labels > -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body > -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self > -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition > -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 > -I/usr/include/libpng16 -I$(SRC_PATH)/capstone/include > -fsanitize=address -o config-temp/qemu-conf.exe > config-temp/qemu-conf.c -m64 -g > cc1: warning: -fsanitize=address not supported for this target > cc -Werror -DHAS_LIBSSH2_SFTP_FSYNC -pthread -I/usr/include/glib-2.0 > -I/usr/lib/sparc64-linux-gnu/glib-2.0/include -DNCURSES_WIDECHAR > -D_GNU_SOURCE -D_DEFAULT_SOURCE -I/usr/include/ncursesw -m64 > -mcpu=ultrasparc -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 > -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall > -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing > -fno-common -fwrapv -Wexpansion-to-defined -Wendif-labels > -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body > -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self > -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition > -Wtype-limits -fstack-protector-strong -I/usr/include/p11-kit-1 > -I/usr/include/libpng16 -I$(SRC_PATH)/capstone/include > -fsanitize=address -o config-temp/qemu-conf.exe > config-temp/qemu-conf.c -m64 -g > cc1: error: -fsanitize=address not supported for this target [-Werror] Hmm, I guess the check -fsanitize=address doesn't return an error unless -Werror is given. Perhaps it needs: diff --git a/configure b/configure index f5550f3289..ba68c550c9 100755 --- a/configure +++ b/configure @@ -5190,7 +5190,7 @@ fi have_asan=no write_c_skeleton -if compile_prog "-fsanitize=address" ""; then +if compile_prog "-Werror -fsanitize=address" ""; then have_asan=yes fi @@ -5207,7 +5207,7 @@ int main(void) { return 0; } EOF -if compile_prog "-fsanitize=address" "" ; then +if compile_prog "-Werror -fsanitize=address" "" ; then have_asan_iface_fiber=yes fi