| Message ID | a4264aaee656910c84161a2965f7a501437379ca.1579374329.git.berto@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Misc BDRV_SECTOR_SIZE updates | expand |
On 18.01.20 20:09, Alberto Garcia wrote: > qemu-img's convert_co_copy_range() operates at the sector level and > block_copy() operates at the cluster level so this condition is always > true, but it is not necessary to restrict this here, so let's leave it > to the driver implementation return an error if there is any. > > Signed-off-by: Alberto Garcia <berto@igalia.com> > --- > block/qcow2.c | 4 ---- > 1 file changed, 4 deletions(-) Reviewed-by: Max Reitz <mreitz@redhat.com>
diff --git a/block/qcow2.c b/block/qcow2.c index 100393fd3b..a6b0d4ee1d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3829,10 +3829,6 @@ qcow2_co_copy_range_from(BlockDriverState *bs, case QCOW2_CLUSTER_NORMAL: child = s->data_file; copy_offset += offset_into_cluster(s, src_offset); - if ((copy_offset & 511) != 0) { - ret = -EIO; - goto out; - } break; default:
qemu-img's convert_co_copy_range() operates at the sector level and block_copy() operates at the cluster level so this condition is always true, but it is not necessary to restrict this here, so let's leave it to the driver implementation return an error if there is any. Signed-off-by: Alberto Garcia <berto@igalia.com> --- block/qcow2.c | 4 ---- 1 file changed, 4 deletions(-)