From patchwork Thu Nov 10 01:42:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Education Directorate X-Patchwork-Id: 9420503 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DDF96048E for ; Thu, 10 Nov 2016 01:43:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FC9329456 for ; Thu, 10 Nov 2016 01:43:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14A3129458; Thu, 10 Nov 2016 01:43:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 64F5E29456 for ; Thu, 10 Nov 2016 01:43:31 +0000 (UTC) Received: from localhost ([::1]:43323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4eOo-0005h6-LB for patchwork-qemu-devel@patchwork.kernel.org; Wed, 09 Nov 2016 20:43:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4eOI-0005gD-PT for qemu-devel@nongnu.org; Wed, 09 Nov 2016 20:42:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4eOF-00053P-Kf for qemu-devel@nongnu.org; Wed, 09 Nov 2016 20:42:58 -0500 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:36845) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4eOF-00052i-DT; Wed, 09 Nov 2016 20:42:55 -0500 Received: by mail-pf0-x243.google.com with SMTP id n85so2094940pfi.3; Wed, 09 Nov 2016 17:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:subject:cc:from:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=ZDgys+VgooOFVyjKx7OgGcjpCGGZstd+GzLuOWXAPLQ=; b=Nm78TQ3zL1NdNZFx4RMVl68mDgfGIwW5koAcvzzniOupVYEw/gyc+WOch9En20/o9c o0uuBUB4LAOBV0mCg9nNItJv5f8WMgcFCUGabD/N8ahpRGvnP80L1UQyrdP3sC7m1Ym8 hr0j2KUyiKN8Kh5CJKKiqL0rWTUiU5++g5TxiHrty+9sZcNXTLtl6kuXjBJaf7Vihz7E gyI58WMlsTl9RBnjXQrK793469rA+aW0emiOuz5VQq2aK+Le/IE8tSXI8l2MbICUM4Rw EXBKSQdoK5uXiIqm1f17wNgx9OKkvjVCpxtQVbuv9X2Iy1NnwbIJuGzPeFybNWXfFx4W nbnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:cc:from:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=ZDgys+VgooOFVyjKx7OgGcjpCGGZstd+GzLuOWXAPLQ=; b=LKwcsT9XGTRIU2Zyxgb3kUPbKh39Ed7N6xGtEfgyJ9HcZeQOK2w6VZlhopxxptL6dj Wtct3Q6Vgn6ytYDqAaWtx+++1pyxOAH/jfSyZR9bLyY2wiCB6tsWF4jzdY72TpO/pdDa PiwTVXsIYy4VUHxVGz4WMTVZeqg7khDKZpnSpIQiuggsSTjQP65NjJq9hbYDUMHzN+KP oBdx0Kplp4NSQFxPWdmMaOHvEtQMQfOwbDjD00D+utPhbiKa1v24qIqRHX7WOn5CPfpi A80aEnQF51X02vkGOH2KxbOAnu+hJapLVqNQmxR9I4BWfG/18rkKS9u9QSbJaGCeNlqw i9nw== X-Gm-Message-State: ABUngvegJXp57dAqU7F64AdJiU1ntAsc75gzVZc0BKbdNPpWqYC53bu5pzxLBoq6YlUGDw== X-Received: by 10.99.178.6 with SMTP id x6mr31503248pge.63.1478742173703; Wed, 09 Nov 2016 17:42:53 -0800 (PST) Received: from [192.168.31.21] (14-202-194-140.static.tpgi.com.au. [14.202.194.140]) by smtp.gmail.com with ESMTPSA id n26sm2119941pfi.32.2016.11.09.17.42.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Nov 2016 17:42:52 -0800 (PST) To: qemu-ppc@nongnu.org From: Balbir Singh Message-ID: Date: Thu, 10 Nov 2016 12:42:37 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [TRIVIAL][RFC][PATCH] FU exceptions should carry a cause (IC) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Cedric Le Goater , David Gibson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP As per the ISA we need a cause for FU exceptions.Executing a tabort r9 for example in libc, causes a EXCP_FU exception. We don't wire up the IC (cause) when we post the exception. The cause is required for the kernel to do the right thing. I caught this issue while testing the latest kernel against Cedrics' latest pnv ipmi branch. Signed-off-by: Balbir singh --- target-ppc/excp_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-ppc/excp_helper.c b/target-ppc/excp_helper.c index 808760b..cccea8d 100644 --- a/target-ppc/excp_helper.c +++ b/target-ppc/excp_helper.c @@ -427,6 +427,7 @@ static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp) case POWERPC_EXCP_VPU: /* Vector unavailable exception */ case POWERPC_EXCP_VSXU: /* VSX unavailable exception */ case POWERPC_EXCP_FU: /* Facility unavailable exception */ + env->spr[SPR_FSCR] |= ((target_ulong)env->error_code << 56); break; case POWERPC_EXCP_PIT: /* Programmable interval timer interrupt */ LOG_EXCP("PIT exception\n");