[v12,08/19] block: Block all intermediate nodes in commit_active_start()

Commit Message

Alberto Garcia Oct. 26, 2016, 10:29 a.m. UTC

When block-commit is launched without the top parameter, it uses
internally a mirror block job. In that case all intermediate nodes
between the active and base nodes must be blocked as well.

Signed-off-by: Alberto Garcia <[e-mail]>
Reviewed-by: Kevin Wolf <[e-mail]>
---
 block/mirror.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Patch

diff --git a/block/mirror.c b/block/mirror.c
index a4273f6..94be565 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -967,6 +967,14 @@  static void mirror_start_job(const char *job_id, BlockDriverState *bs,
     }
 
     block_job_add_bdrv(&s->common, target);
+    /* In commit_active_start() all intermediate nodes disappear, so
+     * any jobs in them must be blocked */
+    if (bdrv_chain_contains(bs, target)) {
+        BlockDriverState *iter;
+        for (iter = backing_bs(bs); iter != target; iter = backing_bs(iter)) {
+            block_job_add_bdrv(&s->common, iter);
+        }
+    }
 
     s->common.co = qemu_coroutine_create(mirror_run, s);
     trace_mirror_start(bs, s, s->common.co, opaque);