| Message ID | d72d9cf99ad0169a39cd3f8028ee7c2e112edf06.1732266152.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Prepare GHES driver to support error injection | expand |
On Fri, 22 Nov 2024 10:11:27 +0100 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > Make error handling within ghes_record_cper_errors() consistent, > i.e. instead abort just print a error in case ghes GED is not found. > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/acpi/ghes.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index ad7d895def2a..25587f5fc9ab 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -371,7 +371,10 @@ void ghes_record_cper_errors(const void *cper, size_t len, > > acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED, > NULL)); > - g_assert(acpi_ged_state); > + if (!acpi_ged_state) { > + error_setg(errp, "Can't find ACPI_GED object"); > + return; > + } > ags = &acpi_ged_state->ghes_state; > > start_addr = le64_to_cpu(ags->ghes_addr_le);
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index ad7d895def2a..25587f5fc9ab 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -371,7 +371,10 @@ void ghes_record_cper_errors(const void *cper, size_t len, acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED, NULL)); - g_assert(acpi_ged_state); + if (!acpi_ged_state) { + error_setg(errp, "Can't find ACPI_GED object"); + return; + } ags = &acpi_ged_state->ghes_state; start_addr = le64_to_cpu(ags->ghes_addr_le);