From patchwork Mon Aug 15 09:08:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Christian Borntraeger X-Patchwork-Id: 9280577 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B5EE160780 for ; Mon, 15 Aug 2016 09:09:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A293A28BE5 for ; Mon, 15 Aug 2016 09:09:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9745828BED; Mon, 15 Aug 2016 09:09:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2CCC128BE5 for ; Mon, 15 Aug 2016 09:09:22 +0000 (UTC) Received: from localhost ([::1]:35624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZDtY-000112-J6 for patchwork-qemu-devel@patchwork.kernel.org; Mon, 15 Aug 2016 05:09:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZDtI-00010w-LF for qemu-devel@nongnu.org; Mon, 15 Aug 2016 05:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZDtF-0002mZ-C2 for qemu-devel@nongnu.org; Mon, 15 Aug 2016 05:09:04 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZDtF-0002lt-3f for qemu-devel@nongnu.org; Mon, 15 Aug 2016 05:09:01 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7F93iaF137208 for ; Mon, 15 Aug 2016 05:08:59 -0400 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 24t0295yv4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 15 Aug 2016 05:08:59 -0400 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Aug 2016 10:08:57 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 15 Aug 2016 10:08:55 +0100 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: qemu-devel@nongnu.org Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id EFA0B1B08069 for ; Mon, 15 Aug 2016 10:10:29 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u7F98sCd23461898 for ; Mon, 15 Aug 2016 09:08:54 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u7F98reS024394 for ; Mon, 15 Aug 2016 03:08:53 -0600 Received: from oc1450873852.ibm.com (dyn-9-152-224-84.boeblingen.de.ibm.com [9.152.224.84]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u7F98nRn024224; Mon, 15 Aug 2016 03:08:49 -0600 To: Paolo Bonzini , qemu-devel@nongnu.org References: <1470837437-14713-1-git-send-email-pbonzini@redhat.com> <1470837437-14713-3-git-send-email-pbonzini@redhat.com> <66e64b7a-8d4d-a8ab-03d3-c48277165b77@de.ibm.com> From: Christian Borntraeger Date: Mon, 15 Aug 2016 11:08:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <66e64b7a-8d4d-a8ab-03d3-c48277165b77@de.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081509-0040-0000-0000-00000212AC2E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081509-0041-0000-0000-0000215CB595 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-15_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608150109 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-001b2d01.pphosted.com id u7F93iaF137208 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 Subject: Re: [Qemu-devel] [PULL 02/14] build-sys: fix building with make CFLAGS=.. argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 08/15/2016 10:41 AM, Christian Borntraeger wrote: > On 08/10/2016 03:57 PM, Paolo Bonzini wrote: >> From: Marc-André Lureau >> >> When calling make with a CFLAGS=.. argument, the -g/-O filter is not >> applied, which may result with build failure with ASAN for example. It >> could be solved with an 'override' directive on CFLAGS, but that would >> actually prevent setting different CFLAGS manually. >> >> Instead, filter the CFLAGS argument from the top-level Makefile (so >> you could still call make with a different CFLAGS argument on a >> rom/Makefile manually) >> >> Signed-off-by: Marc-André Lureau >> Reviewed-by: Paolo Bonzini >> Message-Id: <20160805082421.21994-2-marcandre.lureau@redhat.com> >> Signed-off-by: Paolo Bonzini > > > This patch breaks the build on the s390-ccw.img bios if I enable > --enable-debug > [...] > Something like seems to help. I need to double check... --- a/pc-bios/s390-ccw/Makefile +++ b/pc-bios/s390-ccw/Makefile @@ -10,8 +10,10 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/s390-ccw) .PHONY : all clean build-all OBJECTS = start.o main.o bootmap.o sclp-ascii.o virtio.o virtio-scsi.o -CFLAGS += -fPIE -fno-stack-protector -ffreestanding -march=z900 -CFLAGS += -fno-delete-null-pointer-checks -msoft-float +QEMU_CFLAGS := $(filter -W%, $(QEMU_CFLAGS)) +QEMU_CFLAGS := -ffreestanding -fno-delete-null-pointer-checks -msoft-float +QEMU_CFLAGS := -march=z900 -fPIE +QEMU_CFLAGS += $(call cc-option, $(QEMU_CFLAGS), -fno-stack-protector) LDFLAGS += -Wl,-pie -nostdlib build-all: s390-ccw.img