From patchwork Thu Mar 23 04:39:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boqun Feng X-Patchwork-Id: 13184961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CAA1C6FD1C for ; Thu, 23 Mar 2023 04:40:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230185AbjCWEkI (ORCPT ); Thu, 23 Mar 2023 00:40:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230078AbjCWEj5 (ORCPT ); Thu, 23 Mar 2023 00:39:57 -0400 Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76EFB26864; Wed, 22 Mar 2023 21:39:55 -0700 (PDT) Received: by mail-qv1-xf2d.google.com with SMTP id q88so7235613qvq.13; Wed, 22 Mar 2023 21:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679546394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:from:to:cc:subject :date:message-id:reply-to; bh=rpd6Nuq+zKvvgRPPpUZyvF1zFoaLkJFZfbVONMKqf1k=; b=ZtUacI0K1D1dkHPegq3R0xQXH5D6iYly/yNMtSCqRLSggNjIaNCO+DrMYdCMROZHor 30SUFRWDYr9ZPwjDWEfN/WMS0xfgQjHPfMFgag1qEUEL3JwMptZfhl0P9t8fVXwl4Ufp Begvrh8V6tpCZnMYR9TUOnSBWdkO9HIVW1IQrLFO04cfmqwte2/x/lOKZj//owgI8heW T9EP6QSfexXoK79ECQzFknv9CzwKtlLifKXoOPrF0BahMmayK66jgCy0DW4uYjbtR9+H ezIpeHjN9m1qnr4auK3dznk/6wbk4y9sx2KohpReWGrPQjuJ+EG6B2q3ovDcoWD6Agdq YshQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679546394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rpd6Nuq+zKvvgRPPpUZyvF1zFoaLkJFZfbVONMKqf1k=; b=i+gRrA+MHHukRh9LW9r/Bp8QSWYXkOUZJwJiRQJuhxwcrJLhK7/I38d1+FRDtmTwq8 LVS98/nX6NEQwYS0JkbxQ9HA29g/fmYcS0Dr9jQ1LzQ9aapRZVGkhNVyM/p/Dy7T1cLM +iYDGXDaoyNaVETjzozQCaojqDown6tJ/Ygx9jrBiAlLDWHhD/y/j43nxFIA/T83gV/9 wX+En8cgkOd27N+OGa4OGNLzTDB3gxrQ+U7EYxswRJCgSylrBeLXpAmQNOB0kZqtLjwz v61SvxIxwTu68tgDJ0CROkDI0slATmaYaBI2bKlce+7wBhn53it5gQdUJLuyRM1RmvHA bmjw== X-Gm-Message-State: AO0yUKWJUINja/ZELfprwp1yNHNChyC9AUYE0zY7j3el3IyBT4Z8M3dy c+FlHvxQR+/svsRip6tAIWY= X-Google-Smtp-Source: AK7set8X41D30DAr+Mb9Do//dk5O1nr2/Nkp0CUzIqGv3Ethb83zt+v3g7TV9csGvp2sp/I3EaRAjw== X-Received: by 2002:ad4:5d6c:0:b0:5ac:daf1:1ac1 with SMTP id fn12-20020ad45d6c000000b005acdaf11ac1mr10613633qvb.27.1679546394531; Wed, 22 Mar 2023 21:39:54 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id w2-20020ac87182000000b003b9a6d54b6csm11121127qto.59.2023.03.22.21.39.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 21:39:54 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id A905A27C0054; Thu, 23 Mar 2023 00:39:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 23 Mar 2023 00:39:53 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegfedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepuehoqhhu nhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrdgtohhmqeenucggtffrrg htthgvrhhnpeegleejiedthedvheeggfejveefjeejkefgveffieeujefhueeigfegueeh geeggfenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpe gsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeiledvgeehtdei gedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmhgrihhlrdgtohhmsehfih igmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Mar 2023 00:39:52 -0400 (EDT) From: Boqun Feng To: rcu@vger.kernel.org Cc: Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Shuah Khan , Bhaskar Chowdhury , Boqun Feng , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH rcu v2 04/10] tools: rcu: Add usage function and check for argument Date: Wed, 22 Mar 2023 21:39:29 -0700 Message-Id: <20230323043935.1221184-5-boqun.feng@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230323043935.1221184-1-boqun.feng@gmail.com> References: <20230323043935.1221184-1-boqun.feng@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org From: Bhaskar Chowdhury This commit converts extract-stall.sh script's header comment to a usage() function, and adds an argument check. While in the area, make this script be executable. [ paulmck: Strength argument check, remove extraneous comment. ] Signed-off-by: Bhaskar Chowdhury Signed-off-by: Paul E. McKenney Signed-off-by: Boqun Feng --- tools/rcu/extract-stall.sh | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) mode change 100644 => 100755 tools/rcu/extract-stall.sh diff --git a/tools/rcu/extract-stall.sh b/tools/rcu/extract-stall.sh old mode 100644 new mode 100755 index e565697c9f90..08a39ad44320 --- a/tools/rcu/extract-stall.sh +++ b/tools/rcu/extract-stall.sh @@ -1,11 +1,25 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0+ -# -# Extract any RCU CPU stall warnings present in specified file. -# Filter out clocksource lines. Note that preceding-lines excludes the -# initial line of the stall warning but trailing-lines includes it. -# -# Usage: extract-stall.sh dmesg-file [ preceding-lines [ trailing-lines ] ] + +usage() { + echo Extract any RCU CPU stall warnings present in specified file. + echo Filter out clocksource lines. Note that preceding-lines excludes the + echo initial line of the stall warning but trailing-lines includes it. + echo + echo Usage: $(basename $0) dmesg-file [ preceding-lines [ trailing-lines ] ] + echo + echo Error: $1 +} + +# Terminate the script, if the argument is missing + +if test -f "$1" && test -r "$1" +then + : +else + usage "Console log file \"$1\" missing or unreadable." + exit 1 +fi echo $1 preceding_lines="${2-3}"