From patchwork Tue Jan 19 16:18:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Iooss X-Patchwork-Id: 8064031 Return-Path: X-Original-To: patchwork-selinux@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F22AEBEEED for ; Tue, 19 Jan 2016 16:28:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6718320456 for ; Tue, 19 Jan 2016 16:28:49 +0000 (UTC) Received: from emvm-gh1-uea08.nsa.gov (emvm-gh1-uea08.nsa.gov [63.239.67.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70D0520265 for ; Tue, 19 Jan 2016 16:28:46 +0000 (UTC) X-TM-IMSS-Message-ID: <31b7596a0007fb62@nsa.gov> Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by nsa.gov ([10.208.42.193]) with ESMTP (TREND IMSS SMTP Service 7.1) id 31b7596a0007fb62 ; Tue, 19 Jan 2016 11:26:11 -0500 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u0JGQU7L025576; Tue, 19 Jan 2016 11:26:34 -0500 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u0JGJK7W221941 for ; Tue, 19 Jan 2016 11:19:20 -0500 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u0JGJKkp024861 for ; Tue, 19 Jan 2016 11:19:20 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1DMAAAQYZ5WnCIeaIFeGQEBAhABAgKER4hWsFqMIAEBAQEBARIBAQEBAQgLCQkhhzOIGwQBn1mfPIY6iRN+hBcFlxqcXgKOXIIuAQsBgjNxhSOBSwEBAQ X-IPAS-Result: A1DMAAAQYZ5WnCIeaIFeGQEBAhABAgKER4hWsFqMIAEBAQEBARIBAQEBAQgLCQkhhzOIGwQBn1mfPIY6iRN+hBcFlxqcXgKOXIIuAQsBgjNxhSOBSwEBAQ X-IronPort-AV: E=Sophos;i="5.22,317,1449550800"; d="scan'208";a="5114836" Received: from emvm-gh1-uea08.nsa.gov ([10.208.42.193]) by goalie.tycho.ncsc.mil with ESMTP; 19 Jan 2016 11:19:19 -0500 X-TM-IMSS-Message-ID: <31b07dac0007f793@nsa.gov> Received: from mx1.polytechnique.org (mx1.polytechnique.org [129.104.30.34]) by nsa.gov ([10.208.42.193]) with ESMTP (TREND IMSS SMTP Service 7.1; TLSv1/SSLv3 ADH-AES256-SHA (256/256)) id 31b07dac0007f793 ; Tue, 19 Jan 2016 11:18:41 -0500 Received: from iosakhe.paris.ensmp.fr (nat-1.ensmp.fr [194.214.158.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 227C256470F for ; Tue, 19 Jan 2016 17:19:15 +0100 (CET) From: Nicolas Iooss To: selinux@tycho.nsa.gov Subject: [PATCH] policycoreutils: newrole: add missing defined in #if Date: Tue, 19 Jan 2016 17:18:28 +0100 Message-Id: <1453220308-2967-1-git-send-email-nicolas.iooss@m4x.org> X-Mailer: git-send-email 2.7.0 X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Tue Jan 19 17:19:15 2016 +0100 (CET)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org X-TM-AS-MML: disable X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When building newrole with gcc 5.3.0 and some warning flags, the compiler reports: newrole.c:77:33: error: "NAMESPACE_PRIV" is not defined [-Werror=undef] #if defined(AUDIT_LOG_PRIV) || (NAMESPACE_PRIV) ^ Indeed, "defined" is missing here. This nevertheless worked so far because when NAMESPACE_PRIV was selected in the Makefile, newrole.c was compiled with "-DNAMESPACE_PRIV", which defined NAMESPACE_PRIV to 1. Signed-off-by: Nicolas Iooss --- policycoreutils/newrole/newrole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/policycoreutils/newrole/newrole.c b/policycoreutils/newrole/newrole.c index 65a945d3d3f3..c6544eed07b9 100644 --- a/policycoreutils/newrole/newrole.c +++ b/policycoreutils/newrole/newrole.c @@ -74,7 +74,7 @@ #ifdef USE_AUDIT #include #endif -#if defined(AUDIT_LOG_PRIV) || (NAMESPACE_PRIV) +#if defined(AUDIT_LOG_PRIV) || defined(NAMESPACE_PRIV) #include #include #endif