| Message ID | 1454236598-1829-1-git-send-email-nicolas.iooss@m4x.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 01/31/2016 05:36 AM, Nicolas Iooss wrote: > clang warns that __cil_permx_to_sepol_class_perms() return value, rc, > may be unitialized: > > ../cil/src/cil_binary.c:4188:9: error: variable 'rc' may be > uninitialized when used here [-Werror,-Wconditional-uninitialized] > return rc; > ^~ > ../cil/src/cil_binary.c:4148:8: note: initialize the variable 'rc' > to silence this warning > int rc; > ^ > = 0 > > This theoretically happens when cil_expand_class(permx->obj) returns an > empty list. > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> All patches applied. Thanks! - Steve > --- > libsepol/cil/src/cil_binary.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c > index 433f92e40a8e..47c751c0ef06 100644 > --- a/libsepol/cil/src/cil_binary.c > +++ b/libsepol/cil/src/cil_binary.c > @@ -4145,7 +4145,7 @@ exit: > > static int __cil_permx_to_sepol_class_perms(policydb_t *pdb, struct cil_permissionx *permx, class_perm_node_t **sepol_class_perms) > { > - int rc; > + int rc = SEPOL_OK; > struct cil_list *class_list = NULL; > struct cil_list_item *c; > class_datum_t *sepol_obj = NULL; >
diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c index 433f92e40a8e..47c751c0ef06 100644 --- a/libsepol/cil/src/cil_binary.c +++ b/libsepol/cil/src/cil_binary.c @@ -4145,7 +4145,7 @@ exit: static int __cil_permx_to_sepol_class_perms(policydb_t *pdb, struct cil_permissionx *permx, class_perm_node_t **sepol_class_perms) { - int rc; + int rc = SEPOL_OK; struct cil_list *class_list = NULL; struct cil_list_item *c; class_datum_t *sepol_obj = NULL;
clang warns that __cil_permx_to_sepol_class_perms() return value, rc, may be unitialized: ../cil/src/cil_binary.c:4188:9: error: variable 'rc' may be uninitialized when used here [-Werror,-Wconditional-uninitialized] return rc; ^~ ../cil/src/cil_binary.c:4148:8: note: initialize the variable 'rc' to silence this warning int rc; ^ = 0 This theoretically happens when cil_expand_class(permx->obj) returns an empty list. Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> --- libsepol/cil/src/cil_binary.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)