From patchwork Fri Feb 5 21:55:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Iooss X-Patchwork-Id: 8239901 Return-Path: X-Original-To: patchwork-selinux@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E95A2BEEE5 for ; Fri, 5 Feb 2016 21:57:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 49117203B8 for ; Fri, 5 Feb 2016 21:57:59 +0000 (UTC) Received: from emvm-gh1-uea08.nsa.gov (emvm-gh1-uea08.nsa.gov [63.239.67.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59559203B4 for ; Fri, 5 Feb 2016 21:57:58 +0000 (UTC) X-TM-IMSS-Message-ID: <8a70831b000522b2@nsa.gov> Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by nsa.gov ([10.208.42.193]) with ESMTP (TREND IMSS SMTP Service 7.1) id 8a70831b000522b2 ; Fri, 5 Feb 2016 16:55:59 -0500 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u15Ltfv4013139; Fri, 5 Feb 2016 16:55:51 -0500 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u15Ltc6G035448 for ; Fri, 5 Feb 2016 16:55:38 -0500 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u15Ltb6L013135 for ; Fri, 5 Feb 2016 16:55:38 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1BFAQDwGbVWnCIeaIFeGQEBAQEQAQIChEeIW654jBcBAQEBAQESAQEBAQEICwkJIYRwAQUnYlFXGYgbBAG/XIYShX6DN4NuBZZ1nEOOPoIYDEEZgUlpiXwBAQE X-IPAS-Result: A1BFAQDwGbVWnCIeaIFeGQEBAQEQAQIChEeIW654jBcBAQEBAQESAQEBAQEICwkJIYRwAQUnYlFXGYgbBAG/XIYShX6DN4NuBZZ1nEOOPoIYDEEZgUlpiXwBAQE X-IronPort-AV: E=Sophos;i="5.22,402,1449550800"; d="scan'208";a="5174322" Received: from emvm-gh1-uea08.nsa.gov ([10.208.42.193]) by goalie.tycho.ncsc.mil with ESMTP; 05 Feb 2016 16:55:35 -0500 X-TM-IMSS-Message-ID: <8a6fee3c00052279@nsa.gov> Received: from mx1.polytechnique.org (mx1.polytechnique.org [129.104.30.34]) by nsa.gov ([10.208.42.193]) with ESMTP (TREND IMSS SMTP Service 7.1; TLSv1/SSLv3 ADH-AES256-SHA (256/256)) id 8a6fee3c00052279 ; Fri, 5 Feb 2016 16:55:21 -0500 Received: from iosakhe.localdomain (32.206.133.77.rev.sfr.net [77.133.206.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id 6B8365647D3 for ; Fri, 5 Feb 2016 22:55:32 +0100 (CET) From: Nicolas Iooss To: selinux@tycho.nsa.gov Subject: [PATCH 2/2] libsemanage: no longer use variables with unused attribute Date: Fri, 5 Feb 2016 22:55:09 +0100 Message-Id: <1454709309-5505-2-git-send-email-nicolas.iooss@m4x.org> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454709309-5505-1-git-send-email-nicolas.iooss@m4x.org> References: <1454709309-5505-1-git-send-email-nicolas.iooss@m4x.org> X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Fri Feb 5 22:55:32 2016 +0100 (CET)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org X-TM-AS-MML: disable X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Nicolas Iooss --- libsemanage/src/database_llist.c | 3 --- libsemanage/src/database_policydb.c | 6 ------ libsemanage/src/debug.c | 2 -- libsemanage/src/direct_api.c | 1 - 4 files changed, 12 deletions(-) diff --git a/libsemanage/src/database_llist.c b/libsemanage/src/database_llist.c index 53583d46a06d..8ce2e2c1af3b 100644 --- a/libsemanage/src/database_llist.c +++ b/libsemanage/src/database_llist.c @@ -154,7 +154,6 @@ int dbase_llist_add(semanage_handle_t * handle, if (dbase_llist_cache_prepend(handle, dbase, data) < 0) goto err; - key = NULL; dbase->modified = 1; return STATUS_SUCCESS; @@ -224,7 +223,6 @@ hidden int dbase_llist_count(semanage_handle_t * handle __attribute__ ((unused)) { *response = dbase->cache_sz; - handle = NULL; return STATUS_SUCCESS; } @@ -303,7 +301,6 @@ int dbase_llist_del(semanage_handle_t * handle __attribute__ ((unused)), prev = ptr; } - handle = NULL; return STATUS_SUCCESS; } diff --git a/libsemanage/src/database_policydb.c b/libsemanage/src/database_policydb.c index e786afe1bd85..748a6ed692d5 100644 --- a/libsemanage/src/database_policydb.c +++ b/libsemanage/src/database_policydb.c @@ -165,7 +165,6 @@ static int dbase_policydb_flush(semanage_handle_t * handle dbase->modified = 0; /* Stub */ - handle = NULL; return STATUS_ERR; } @@ -298,9 +297,6 @@ static int dbase_policydb_del(semanage_handle_t * handle { /* Stub */ - key = NULL; - handle = NULL; - dbase = NULL; return STATUS_ERR; } @@ -311,8 +307,6 @@ static int dbase_policydb_clear(semanage_handle_t * handle { /* Stub */ - handle = NULL; - dbase = NULL; return STATUS_ERR; } diff --git a/libsemanage/src/debug.c b/libsemanage/src/debug.c index ea51ffbbc241..08a9e026042b 100644 --- a/libsemanage/src/debug.c +++ b/libsemanage/src/debug.c @@ -86,8 +86,6 @@ void hidden semanage_msg_default_handler(void *varg __attribute__ ((unused)), fprintf(stream, " (%s).", strerror(errsv)); fprintf(stream, "\n"); - - varg = NULL; } #ifdef __GNUC__ diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c index 7c84bcea629b..2187b658bfa9 100644 --- a/libsemanage/src/direct_api.c +++ b/libsemanage/src/direct_api.c @@ -291,7 +291,6 @@ static void semanage_direct_destroy(semanage_handle_t * sh __attribute__ ((unused))) { /* do nothing */ - sh = NULL; } static int semanage_direct_disconnect(semanage_handle_t * sh)