From patchwork Tue Apr 19 14:26:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Carter X-Patchwork-Id: 8880771 Return-Path: X-Original-To: patchwork-selinux@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D1F2BBF29F for ; Tue, 19 Apr 2016 14:29:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EE9B52026F for ; Tue, 19 Apr 2016 14:29:45 +0000 (UTC) Received: from emvm-gh1-uea09.nsa.gov (smtp.nsa.gov [8.44.101.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0B55201B4 for ; Tue, 19 Apr 2016 14:29:44 +0000 (UTC) X-TM-IMSS-Message-ID: <9de037910005b588@nsa.gov> Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by nsa.gov ([10.208.42.194]) with ESMTP (TREND IMSS SMTP Service 7.1) id 9de037910005b588 ; Tue, 19 Apr 2016 10:27:37 -0400 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u3JERv4L005862; Tue, 19 Apr 2016 10:27:57 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u3JEOYd2054982 for ; Tue, 19 Apr 2016 10:24:34 -0400 Received: from moss-lions.infosec.tycho.ncsc.mil (moss-lions [192.168.25.4]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u3JEOYFM005142 for ; Tue, 19 Apr 2016 10:24:34 -0400 From: James Carter To: selinux@tycho.nsa.gov Subject: [PATCH 5/6] libsepol/cil: Remove path field from cil_tree_node struct Date: Tue, 19 Apr 2016 10:26:04 -0400 Message-Id: <1461075965-17161-6-git-send-email-jwcart2@tycho.nsa.gov> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1461075965-17161-1-git-send-email-jwcart2@tycho.nsa.gov> References: <1461075965-17161-1-git-send-email-jwcart2@tycho.nsa.gov> X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-TM-AS-MML: disable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove path field from cil_tree_node struct and all references to it in CIL. This will reduce memory usage by 5%. Signed-off-by: James Carter --- libsepol/cil/src/cil_binary.c | 14 +++++++++++++- libsepol/cil/src/cil_build_ast.c | 2 -- libsepol/cil/src/cil_copy_ast.c | 1 - libsepol/cil/src/cil_parser.c | 23 +++++++++++------------ libsepol/cil/src/cil_tree.c | 1 - libsepol/cil/src/cil_tree.h | 1 - 6 files changed, 24 insertions(+), 18 deletions(-) diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c index 0a98ecd..9db42d5 100644 --- a/libsepol/cil/src/cil_binary.c +++ b/libsepol/cil/src/cil_binary.c @@ -4227,6 +4227,9 @@ exit: static avrule_t *__cil_init_sepol_avrule(uint32_t kind, struct cil_tree_node *node) { avrule_t *avrule; + struct cil_tree_node *source_node; + char *source_path; + int is_cil; avrule = cil_malloc(sizeof(avrule_t)); avrule->specified = kind; @@ -4235,8 +4238,17 @@ static avrule_t *__cil_init_sepol_avrule(uint32_t kind, struct cil_tree_node *no __cil_init_sepol_type_set(&avrule->ttypes); avrule->perms = NULL; avrule->line = node->line; - avrule->source_filename = node->path; + + avrule->source_filename = NULL; avrule->source_line = node->line; + source_node = cil_tree_get_next_path(node, &source_path, &is_cil); + if (source_node) { + avrule->source_filename = source_path; + if (!is_cil) { + avrule->source_line = node->hll_line; + } + } + avrule->next = NULL; return avrule; } diff --git a/libsepol/cil/src/cil_build_ast.c b/libsepol/cil/src/cil_build_ast.c index 5b9754a..1505873 100644 --- a/libsepol/cil/src/cil_build_ast.c +++ b/libsepol/cil/src/cil_build_ast.c @@ -521,7 +521,6 @@ int cil_gen_perm_nodes(struct cil_db *db, struct cil_tree_node *current_perm, st new_ast->parent = ast_node; new_ast->line = current_perm->line; new_ast->hll_line = current_perm->hll_line; - new_ast->path = current_perm->path; rc = cil_gen_perm(db, current_perm, new_ast, flavor, num_perms); if (rc != SEPOL_OK) { @@ -5919,7 +5918,6 @@ int __cil_build_ast_node_helper(struct cil_tree_node *parse_current, uint32_t *f ast_node->parent = ast_current; ast_node->line = parse_current->line; ast_node->hll_line = parse_current->hll_line; - ast_node->path = parse_current->path; if (parse_current->data == CIL_KEY_BLOCK) { rc = cil_gen_block(db, parse_current, ast_node, 0); diff --git a/libsepol/cil/src/cil_copy_ast.c b/libsepol/cil/src/cil_copy_ast.c index ad69781..5debd0d 100644 --- a/libsepol/cil/src/cil_copy_ast.c +++ b/libsepol/cil/src/cil_copy_ast.c @@ -1983,7 +1983,6 @@ int __cil_copy_node_helper(struct cil_tree_node *orig, __attribute__((unused)) u new->parent = parent; new->line = orig->line; new->hll_line = orig->hll_line; - new->path = orig->path; new->flavor = orig->flavor; new->data = data; diff --git a/libsepol/cil/src/cil_parser.c b/libsepol/cil/src/cil_parser.c index bf1c213..4341f8f 100644 --- a/libsepol/cil/src/cil_parser.c +++ b/libsepol/cil/src/cil_parser.c @@ -78,14 +78,13 @@ static void pop_hll_info(struct cil_stack *stack, int *hll_lineno, int *hll_expa } } -static void create_node(struct cil_tree_node **node, struct cil_tree_node *current, int line, int hll_line, char *path, void *value) +static void create_node(struct cil_tree_node **node, struct cil_tree_node *current, int line, int hll_line, void *value) { cil_tree_node_init(node); (*node)->parent = current; (*node)->flavor = CIL_NODE; (*node)->line = line; (*node)->hll_line = hll_line; - (*node)->path = path; (*node)->data = value; } @@ -117,14 +116,14 @@ static int add_hll_linemark(struct cil_tree_node **current, int *hll_lineno, int pop_hll_info(stack, hll_lineno, hll_expand); *current = (*current)->parent; } else { - create_node(&node, *current, tok.line, *hll_lineno, path, NULL); + create_node(&node, *current, tok.line, *hll_lineno, NULL); insert_node(node, *current); *current = node; - create_node(&node, *current, tok.line, *hll_lineno, path, CIL_KEY_SRC_INFO); + create_node(&node, *current, tok.line, *hll_lineno, CIL_KEY_SRC_INFO); insert_node(node, *current); - create_node(&node, *current, tok.line, *hll_lineno, path, CIL_KEY_SRC_HLL); + create_node(&node, *current, tok.line, *hll_lineno, CIL_KEY_SRC_HLL); insert_node(node, *current); if (hll_type == CIL_KEY_HLL_LMS) { @@ -162,7 +161,7 @@ static int add_hll_linemark(struct cil_tree_node **current, int *hll_lineno, int hll_file = cil_strpool_add(tok.value); - create_node(&node, *current, tok.line, *hll_lineno, path, hll_file); + create_node(&node, *current, tok.line, *hll_lineno, hll_file); insert_node(node, *current); } @@ -183,17 +182,17 @@ static void add_cil_path(struct cil_tree_node **current, char *path) { struct cil_tree_node *node; - create_node(&node, *current, 0, 0, path, NULL); + create_node(&node, *current, 0, 0, NULL); insert_node(node, *current); *current = node; - create_node(&node, *current, 0, 0, path, CIL_KEY_SRC_INFO); + create_node(&node, *current, 0, 0, CIL_KEY_SRC_INFO); insert_node(node, *current); - create_node(&node, *current, 0, 0, path, CIL_KEY_SRC_CIL); + create_node(&node, *current, 0, 0, CIL_KEY_SRC_CIL); insert_node(node, *current); - create_node(&node, *current, 0, 0, path, path); + create_node(&node, *current, 0, 0, path); insert_node(node, *current); } @@ -237,7 +236,7 @@ int cil_parser(char *_path, char *buffer, uint32_t size, struct cil_tree **parse case OPAREN: paren_count++; - create_node(&node, current, tok.line, hll_lineno, path, NULL); + create_node(&node, current, tok.line, hll_lineno, NULL); insert_node(node, current); current = node; break; @@ -258,7 +257,7 @@ int cil_parser(char *_path, char *buffer, uint32_t size, struct cil_tree **parse goto exit; } - create_node(&node, current, tok.line, hll_lineno, path, cil_strpool_add(tok.value)); + create_node(&node, current, tok.line, hll_lineno, cil_strpool_add(tok.value)); insert_node(node, current); break; case NEWLINE : diff --git a/libsepol/cil/src/cil_tree.c b/libsepol/cil/src/cil_tree.c index 1b95e71..e9bb039 100644 --- a/libsepol/cil/src/cil_tree.c +++ b/libsepol/cil/src/cil_tree.c @@ -206,7 +206,6 @@ void cil_tree_node_init(struct cil_tree_node **node) new_node->flavor = CIL_ROOT; new_node->line = 0; new_node->hll_line = 0; - new_node->path = NULL; *node = new_node; } diff --git a/libsepol/cil/src/cil_tree.h b/libsepol/cil/src/cil_tree.h index 318eecd..aeded56 100644 --- a/libsepol/cil/src/cil_tree.h +++ b/libsepol/cil/src/cil_tree.h @@ -47,7 +47,6 @@ struct cil_tree_node { enum cil_flavor flavor; uint32_t line; uint32_t hll_line; - char *path; void *data; };