From patchwork Fri Apr 22 15:38:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 8913561 Return-Path: X-Original-To: patchwork-selinux@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 560F9BF29F for ; Fri, 22 Apr 2016 15:52:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B45420121 for ; Fri, 22 Apr 2016 15:52:52 +0000 (UTC) Received: from emvm-gh1-uea09.nsa.gov (emvm-gh1-uea09.nsa.gov [8.44.101.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8E7920225 for ; Fri, 22 Apr 2016 15:52:50 +0000 (UTC) X-TM-IMSS-Message-ID: Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by nsa.gov ([10.208.42.194]) with ESMTP (TREND IMSS SMTP Service 7.1) id ad9f217500000a07 ; Fri, 22 Apr 2016 11:50:28 -0400 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u3MFoiif008022; Fri, 22 Apr 2016 11:50:48 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u3MFd53H105256 for ; Fri, 22 Apr 2016 11:39:05 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u3MFcxa6004148 for ; Fri, 22 Apr 2016 11:39:05 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CqBAA7RBpX/yQp0ApeHYJwgXu3d4QQhg4CgXQBAQEBAQFmJ4RCAQEBAxIVGQEBNwEPUTQBBQEcBgESIogIAaBpgTE+MYpPhSgBBIxdAQEBAQEBBAIBFwYKhA2CCohvhXEBjVd0iUiBVYxBiSmFZUWNLDCBDmKBeA0bgWlOAYc9gT0BAQE X-IPAS-Result: A0CqBAA7RBpX/yQp0ApeHYJwgXu3d4QQhg4CgXQBAQEBAQFmJ4RCAQEBAxIVGQEBNwEPUTQBBQEcBgESIogIAaBpgTE+MYpPhSgBBIxdAQEBAQEBBAIBFwYKhA2CCohvhXEBjVd0iUiBVYxBiSmFZUWNLDCBDmKBeA0bgWlOAYc9gT0BAQE X-IronPort-AV: E=Sophos;i="5.24,517,1454994000"; d="scan'208";a="5402609" Received: from emsm-gh1-uea10.corp.nsa.gov (HELO emsm-gh1-uea10.nsa.gov) ([10.208.41.36]) by goalie.tycho.ncsc.mil with ESMTP; 22 Apr 2016 11:39:04 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3Alvu2/RA3O8zkIGubSnbAUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSPrzoMbcNUDSrc9gkEXOFd2CrakU26yJ6+uwBSQp2tWojjMrSNR0TRgLiM?= =?us-ascii?q?EbzUQLIfWuLgnFFsPsdDEwB89YVVVorDmROElRH9viNRWJ+iXhpQAbFhi3Dwdp?= =?us-ascii?q?POO9QteU1JTnkb/qsM2PKyxzxxODIppKZC2sqgvQssREyaBDEY0WjiXzn31TZu?= =?us-ascii?q?5NznlpL1/A1zz158O34YIxu38I46Fp34d6XK77Z6U1S6BDRHRjajhtpZ6jiR6W?= =?us-ascii?q?ByaV53BUbSNeuBtFDwXf6Rj8FN+lvyH7u+ZwwiyyLcj3Vqs1XjLk5KBuHlugqy?= =?us-ascii?q?oBK3Ye7mzNkdBqga9H6EaiqhpjhYnKbZuOKOBzc7/1ctYTRG4HVcFUAWgJK4e1?= =?us-ascii?q?dIcGDvBJHutCoI777w8HohiWHwSgBOrzjDRPgymylYg70OlpKgfHwB4tBZpaq3?= =?us-ascii?q?LVsMf4Lo8IXOy1xbWOxjLGObce1TK45IXWfxQJu/yAXbtsN8HWzA1nLAPMiVWN?= =?us-ascii?q?oMTBPnvBzeQJskCY4vBmWObpjHQo/UU5jjGxx8tktY7OioIS10vJvXF134Mqf/?= =?us-ascii?q?W5TkBhaNKpGZcWsDuVYc8+aNkjSmcgniEg0Lwd8cqwey0S1Ygq3QXRbOaffoGD?= =?us-ascii?q?7zrsUe+QJXFzg3czPPqWgxui+E6sx/e0aMiu1x4esCtflfHeu3YMyVrX686aWr?= =?us-ascii?q?165EjnxDXZk0jx4+cMAkkunOKPKZcqwZYri4Ee90/EG3my0Gf7gqHeUkw15u+u?= =?us-ascii?q?o7DlZrz3upiaH5dzjQr+M6k0l8CkR+I1Ll5KFyK5v6yWzqDo8AXXQbhOguZ82v?= =?us-ascii?q?3TvpHXIcgAjqC4DgtZyYs4rRGlAGH1/s4fmCw8IU5FMDyAlZPpNlyGdOv1Eff5?= =?us-ascii?q?jVO2izdmytjNN7vmBJTGJ3yFm7DkK+Uuo3VAwRY+mIgMr6lfDasMdbeqAhf8?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A1EiAQCfQhpXkKrWVdFeHYJwgXu3d4QQg?= =?us-ascii?q?g2EAQKBdAEBAQEBAQICDwEBAQEHDQkJIYJcfVs9AQEBAxIVGQEBNwEPUTQBBQE?= =?us-ascii?q?cBgESIogIAaBsgTE+MYpPhSgBBIxdAQEBAQEBBAIBFwYKhA2CCohvhXGNWHSJS?= =?us-ascii?q?IFVjEGJKYVlRY0sMIEOgloNEQqBaU4Bhz2BPQEBAQ?= X-IPAS-Result: =?us-ascii?q?A1EiAQCfQhpXkKrWVdFeHYJwgXu3d4QQgg2EAQKBdAEBAQE?= =?us-ascii?q?BAQICDwEBAQEHDQkJIYJcfVs9AQEBAxIVGQEBNwEPUTQBBQEcBgESIogIAaBsg?= =?us-ascii?q?TE+MYpPhSgBBIxdAQEBAQEBBAIBFwYKhA2CCohvhXGNWHSJSIFVjEGJKYVlRY0?= =?us-ascii?q?sMIEOgloNEQqBaU4Bhz2BPQEBAQ?= X-IronPort-AV: E=Sophos;i="5.24,517,1454976000"; d="scan'208";a="12934426" Received: from emvm-gh1-uea09.nsa.gov ([10.208.42.194]) by emsm-gh1-uea10.nsa.gov with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Apr 2016 15:39:03 +0000 X-TM-IMSS-Message-ID: Received: from mail-ob0-f170.google.com (mail-ob0-f170.google.com [209.85.214.170]) by nsa.gov ([10.208.42.194]) with ESMTP (TREND IMSS SMTP Service 7.1; TLSv1/SSLv3 AES128-SHA (128/128)) id ad9446c00000061a ; Fri, 22 Apr 2016 11:38:37 -0400 Received: by mail-ob0-f170.google.com with SMTP id tz8so50751794obc.0 for ; Fri, 22 Apr 2016 08:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kHqY158vJabNchyChpPIgMQfy7vmDFNyGY8AFjxwgdA=; b=z1lu0+8meOT2gflTrMquXTcNr2DnwW01vENsBH9aZwiHiwbpIRKVbPk0JWXCHw94ly AxqNC0yybeFyQEmh9JamTNfabbLI/yCp8avIlL+z+igqL1Ze+F3dhgtDhvaVV5Nl78Pp NZ3D7EQ0SQhopNMErFQspEBmPb4Yl74GJY1JcDLdcFUCiO3+/OnbfA75MdYR0L/ibyG6 fGefphXwUl+9UZA1JeK7BPsh8cD5jQRncJ6MqiBRXg7leLmsK+xr7RiJICNUfvVIedwI 3BUEcNcZs1Ikn8UkWITRfE/XEdwWFT/NVRW5hrnMZou8wPpl7sEWSoNipiwKq5Rbq6wq l/fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kHqY158vJabNchyChpPIgMQfy7vmDFNyGY8AFjxwgdA=; b=Asgep7X/MBwVWz0n+mSWxA1s3unlleVxJeAzoNhwJ1jz2O8eTHVFs0PZOWAqB6aZ7U 1oAGp6JQNc5BHVDE4Pg0jhOXazrSwy4/sffnndJbtJtbVXts6us3JO8iJRotP07ex2l5 R1nqGIrdVSoY5h/o2GNwCGkJb3vH/VpJZyXI6YchVPYKFhht9x/qrng3HQjKTGgikftU N5tXhLb/0v0ypxvwREpFgB0XDQzkq4zKx0v3arprwA7z3mP2RGfj9KeWNC5Mce3i4faL +yzgARnAe5IUCBOaDnxotC46+zCZOtUSXQOcMFshbhnCNuHTBwHXgvQPJEMjFlSxIh1m iQLQ== X-Gm-Message-State: AOPr4FXr6YMXc1z2y3AWIeJSxJpFxf+LRYw1RVnPyhh5pT3pFst64Vj2bbAqs6jzUE3XY1BB X-Received: by 10.182.49.168 with SMTP id v8mr8945739obn.48.1461339542483; Fri, 22 Apr 2016 08:39:02 -0700 (PDT) Received: from localhost ([2605:a601:aab:f920:ad1c:41df:dcb1:a4a0]) by smtp.gmail.com with ESMTPSA id p1sm2112983obn.22.2016.04.22.08.39.01 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 22 Apr 2016 08:39:01 -0700 (PDT) From: Seth Forshee To: "Eric W. Biederman" , Kent Overstreet , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , David Woodhouse , Brian Norris , Alexander Viro , Jan Kara , Jeff Layton , "J. Bruce Fields" Subject: [PATCH v3 04/21] block_dev: Support checking inode permissions in lookup_bdev() Date: Fri, 22 Apr 2016 10:38:21 -0500 Message-Id: <1461339521-123191-5-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461339521-123191-1-git-send-email-seth.forshee@canonical.com> References: <1461339521-123191-1-git-send-email-seth.forshee@canonical.com> X-TM-AS-MML: disable X-Mailman-Approved-At: Fri, 22 Apr 2016 11:40:16 -0400 X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Cc: linux-bcache@vger.kernel.org, Serge Hallyn , Seth Forshee , Miklos Szeredi , Richard Weinberger , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, fuse-devel@lists.sourceforge.net, Austin S Hemmelgarn , linux-mtd@lists.infradead.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, Pavel Tikhomirov MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When looking up a block device by path no permission check is done to verify that the user has access to the block device inode at the specified path. In some cases it may be necessary to check permissions towards the inode, such as allowing unprivileged users to mount block devices in user namespaces. Add an argument to lookup_bdev() to optionally perform this permission check. A value of 0 skips the permission check and behaves the same as before. A non-zero value specifies the mask of access rights required towards the inode at the specified path. The check is always skipped if the user has CAP_SYS_ADMIN. All callers of lookup_bdev() currently pass a mask of 0, so this patch results in no functional change. Subsequent patches will add permission checks where appropriate. Signed-off-by: Seth Forshee Acked-by: Serge Hallyn --- drivers/md/bcache/super.c | 2 +- drivers/md/dm-table.c | 2 +- drivers/mtd/mtdsuper.c | 2 +- fs/block_dev.c | 13 ++++++++++--- fs/quota/quota.c | 2 +- include/linux/fs.h | 2 +- 6 files changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index a296425a7270..e169739a0253 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1950,7 +1950,7 @@ static ssize_t register_bcache(struct kobject *k, struct kobj_attribute *attr, sb); if (IS_ERR(bdev)) { if (bdev == ERR_PTR(-EBUSY)) { - bdev = lookup_bdev(strim(path)); + bdev = lookup_bdev(strim(path), 0); mutex_lock(&bch_register_lock); if (!IS_ERR(bdev) && bch_is_open(bdev)) err = "device already registered"; diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index f9e8f0bef332..13f568d527b5 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -372,7 +372,7 @@ dev_t dm_get_dev_t(const char *path) dev_t uninitialized_var(dev); struct block_device *bdev; - bdev = lookup_bdev(path); + bdev = lookup_bdev(path, 0); if (IS_ERR(bdev)) dev = name_to_dev_t(path); else { diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c index 20c02a3b7417..b5b60e1af31c 100644 --- a/drivers/mtd/mtdsuper.c +++ b/drivers/mtd/mtdsuper.c @@ -176,7 +176,7 @@ struct dentry *mount_mtd(struct file_system_type *fs_type, int flags, /* try the old way - the hack where we allowed users to mount * /dev/mtdblock$(n) but didn't actually _use_ the blockdev */ - bdev = lookup_bdev(dev_name); + bdev = lookup_bdev(dev_name, 0); if (IS_ERR(bdev)) { ret = PTR_ERR(bdev); pr_debug("MTDSB: lookup_bdev() returned %d\n", ret); diff --git a/fs/block_dev.c b/fs/block_dev.c index 3e84d62d0a25..e9b937845bdb 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1431,7 +1431,7 @@ struct block_device *blkdev_get_by_path(const char *path, fmode_t mode, struct block_device *bdev; int err; - bdev = lookup_bdev(path); + bdev = lookup_bdev(path, 0); if (IS_ERR(bdev)) return bdev; @@ -1821,12 +1821,14 @@ EXPORT_SYMBOL(ioctl_by_bdev); /** * lookup_bdev - lookup a struct block_device by name * @pathname: special file representing the block device + * @mask: rights to check for (%MAY_READ, %MAY_WRITE, %MAY_EXEC) * * Get a reference to the blockdevice at @pathname in the current * namespace if possible and return it. Return ERR_PTR(error) - * otherwise. + * otherwise. If @mask is non-zero, check for access rights to the + * inode at @pathname. */ -struct block_device *lookup_bdev(const char *pathname) +struct block_device *lookup_bdev(const char *pathname, int mask) { struct block_device *bdev; struct inode *inode; @@ -1841,6 +1843,11 @@ struct block_device *lookup_bdev(const char *pathname) return ERR_PTR(error); inode = d_backing_inode(path.dentry); + if (mask != 0 && !capable(CAP_SYS_ADMIN)) { + error = __inode_permission(inode, mask); + if (error) + goto fail; + } error = -ENOTBLK; if (!S_ISBLK(inode->i_mode)) goto fail; diff --git a/fs/quota/quota.c b/fs/quota/quota.c index 0f10ee9892ce..59223384b22e 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c @@ -799,7 +799,7 @@ static struct super_block *quotactl_block(const char __user *special, int cmd) if (IS_ERR(tmp)) return ERR_CAST(tmp); - bdev = lookup_bdev(tmp->name); + bdev = lookup_bdev(tmp->name, 0); putname(tmp); if (IS_ERR(bdev)) return ERR_CAST(bdev); diff --git a/include/linux/fs.h b/include/linux/fs.h index 66a639ec1bc4..173b8adc6131 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2438,7 +2438,7 @@ static inline void unregister_chrdev(unsigned int major, const char *name) #define BLKDEV_MAJOR_HASH_SIZE 255 extern const char *__bdevname(dev_t, char *buffer); extern const char *bdevname(struct block_device *bdev, char *buffer); -extern struct block_device *lookup_bdev(const char *); +extern struct block_device *lookup_bdev(const char *, int mask); extern void blkdev_show(struct seq_file *,off_t); #else