From patchwork Mon Jul 11 11:59:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Lautrbach X-Patchwork-Id: 9223391 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51EE460572 for ; Mon, 11 Jul 2016 12:04:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E0E825227 for ; Mon, 11 Jul 2016 12:04:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C5AF27C38; Mon, 11 Jul 2016 12:04:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from emsm-gh1-uea11.nsa.gov (smtp.nsa.gov [8.44.101.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7137125227 for ; Mon, 11 Jul 2016 12:04:34 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.28,346,1464652800"; d="scan'208";a="17526553" IronPort-PHdr: =?us-ascii?q?9a23=3AhuDKRxAosVupkUGkoYTXUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSP/zo8bcNUDSrc9gkEXOFd2CrakV06yN7uu7BCQp2tWoiDg6aptCVhsI24?= =?us-ascii?q?09vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6kO74TNaIBjjLw09?= =?us-ascii?q?fr2zQd+KyZ/qnLvvs7ToICxwzAKnZr1zKBjk5S7wjeIxxbVYF6Aq1xHSqWFJce?= =?us-ascii?q?kFjUlhJFaUggqurpzopM0rzj5U884F24YAFPyiPvdwcLpDET5zM3wp/J+s8gHZ?= =?us-ascii?q?Sg6C+nsRT35QkxxGBBPI51fmT5zxtW38vfF2niybOYrzRLEwXD2kqKBzVB7vjj?= =?us-ascii?q?xALDM98WfKmp9NirlGqkekrh1734mGe4yRNfxjbubHcMoHSHFddtpAXCxGRIWn?= =?us-ascii?q?Zs0ACPRWJvtSrYT2uw4TqwCjDxKnHuLlx2x0gSrt0Kk71fkxOR3X1wwnWdQVuT?= =?us-ascii?q?Lbq8umGr0VVLWNwbXShRHKcu9M0z726MCcahQovO2WV7tYa8fdyUAzUQjCiwPD?= =?us-ascii?q?+sTeIzqJ27FV4CCg5O16WLfq0jYq?= X-IPAS-Result: =?us-ascii?q?A2FUBQAuioNX/wHyM5Bcgz6BUrRihiQihytMAQEBAQEBAgJ?= =?us-ascii?q?iJ4IyBAMQghsCNwwIAh4OAwECBgIXKQgIAwEtFR8LBRgEiA+/HgsBAQEBIoYni?= =?us-ascii?q?GARAWiFDwWZGI5SAolihUYCSJAbg3NsiAqBNQEBAQ?= Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by emsm-gh1-uea11.nsa.gov with ESMTP; 11 Jul 2016 12:04:29 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u6BBxo0g028965; Mon, 11 Jul 2016 08:01:12 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u6BBxjaO244302 for ; Mon, 11 Jul 2016 07:59:45 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u6BBxfIQ028963 for ; Mon, 11 Jul 2016 07:59:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1BRAQB5iYNXhxy3hNFcHoRypgmCAQGMV4ImhAkShgaBKkwBAQEBAQETAQEBCgsJCSGGC4FRiDC/TYYniVqFDwWZGI5SAo8oAkiPR4IMAQtWgVk6Mok/AQEB X-IPAS-Result: A1BRAQB5iYNXhxy3hNFcHoRypgmCAQGMV4ImhAkShgaBKkwBAQEBAQETAQEBCgsJCSGGC4FRiDC/TYYniVqFDwWZGI5SAo8oAkiPR4IMAQtWgVk6Mok/AQEB X-IronPort-AV: E=Sophos;i="5.28,346,1464667200"; d="scan'208";a="5572188" Received: from emsm-gh1-uea11.corp.nsa.gov (HELO emsm-gh1-uea11.nsa.gov) ([10.208.41.37]) by goalie.tycho.ncsc.mil with ESMTP; 11 Jul 2016 07:59:36 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3AY7/XsxU4wvNb2wKQfovXkLEqbRnV8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYZheCt8tkgFKBZ4jH8fUM07OQ6PG4Hzddqs3c+Fk5M7V0Hycfjs?= =?us-ascii?q?sXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aJBzzOEJP?= =?us-ascii?q?K/jvHcaK1oLshrj0oMCYOFgArQH+SIs6FA+xowTVu5teqqpZAYF19CH0pGBVcf?= =?us-ascii?q?9d32JiKAHbtR/94sCt4MwrqHwI6Lpyv/JHBL73e6U+UKxwECUtM2dz4tbi8xbE?= =?us-ascii?q?U1ih/HwZB10bjgAAJwHY8AvwV5zx+n/isuNgxDOQNOXsQLw0UCjk5KBuHky7wB?= =?us-ascii?q?wbPiI0pTmEwvd7i7hW9Uqs?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0FkAgDpiINXhxy3hNFcHoRypgmCAQGMV?= =?us-ascii?q?4ImhAkShgaBKkwBAQEBAQECAg8BAQEKCwkJIS+CMhWDFYFRiDC/TIYniVqFDwW?= =?us-ascii?q?ZGI5SAo8oAkiPR4IYVoFZOjKJPwEBAQ?= X-IPAS-Result: =?us-ascii?q?A0FkAgDpiINXhxy3hNFcHoRypgmCAQGMV4ImhAkShgaBKkw?= =?us-ascii?q?BAQEBAQECAg8BAQEKCwkJIS+CMhWDFYFRiDC/TIYniVqFDwWZGI5SAo8oAkiPR?= =?us-ascii?q?4IYVoFZOjKJPwEBAQ?= X-IronPort-AV: E=Sophos;i="5.28,346,1464652800"; d="scan'208";a="17526385" Received: from mx1.redhat.com ([209.132.183.28]) by emsm-gh1-uea11.nsa.gov with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2016 11:59:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D83CA77348 for ; Mon, 11 Jul 2016 11:59:33 +0000 (UTC) Received: from rhel-at-redhat.localdomain.com ([10.40.2.167]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6BBxWIj000871; Mon, 11 Jul 2016 07:59:33 -0400 From: Petr Lautrbach To: selinux@tycho.nsa.gov Subject: [PATCH] libsepol: Add missing return to sepol_node_query() Date: Mon, 11 Jul 2016 13:59:27 +0200 Message-Id: <1468238367-31812-1-git-send-email-plautrba@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 11 Jul 2016 11:59:33 +0000 (UTC) X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP Due to the missing return in sepol_node_query(), the function always set *response to NULL whenever a protocol was SEPOL_PROTO_IP6 Fixes: sudo semanage node -a -M ::1 -p ipv6 -t node_t ::1 sudo semanage node -m -M ::1 -p ipv6 -t node_t ::1 [1] 12968 segmentation fault (core dumped) semanage node -m -M ::1 -p ipv6 -t node_t ::1 Signed-off-by: Petr Lautrbach --- libsepol/src/nodes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsepol/src/nodes.c b/libsepol/src/nodes.c index 50cf21d..820346d 100644 --- a/libsepol/src/nodes.c +++ b/libsepol/src/nodes.c @@ -273,6 +273,7 @@ int sepol_node_query(sepol_handle_t * handle, c, SEPOL_PROTO_IP6, response) < 0) goto err; + return STATUS_SUCCESS; } } break;