diff mbox

[2/2] semanage: fix modify action in node and interface

Message ID 1469464627-2159-2-git-send-email-mvadkert@redhat.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Miroslav Vadkerti July 25, 2016, 4:37 p.m. UTC 
The modify actions of security context mappings for
interface and node actully called add action.

Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
---
 policycoreutils/semanage/semanage | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Smalley Aug. 11, 2016, 5:33 p.m. UTC | #1 
On 07/25/2016 12:37 PM, Miroslav Vadkerti wrote:
> The modify actions of security context mappings for
> interface and node actully called add action.
> 
> Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>

Thanks, applied.

> ---
>  policycoreutils/semanage/semanage | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
> index 954411d..b199ebe 100644
> --- a/policycoreutils/semanage/semanage
> +++ b/policycoreutils/semanage/semanage
> @@ -524,7 +524,7 @@ def handleInterface(args):
>      if args.action is "add":
>          OBJECT.add(args.interface, args.range, args.type)
>      if args.action is "modify":
> -        OBJECT.add(args.interface, args.range, args.type)
> +        OBJECT.modify(args.interface, args.range, args.type)
>      if args.action is "delete":
>          OBJECT.delete(args.interface)
>      if args.action is "list":
> @@ -607,7 +607,7 @@ def handleNode(args):
>      if args.action is "add":
>          OBJECT.add(args.node, args.netmask, args.proto, args.range, args.type)
>      if args.action is "modify":
> -        OBJECT.add(args.node, args.netmask, args.proto, args.range, args.type)
> +        OBJECT.modify(args.node, args.netmask, args.proto, args.range, args.type)
>      if args.action is "delete":
>          OBJECT.delete(args.node, args.netmask, args.proto)
>      if args.action is "list":
>
diff mbox

Patch

diff --git a/policycoreutils/semanage/semanage b/policycoreutils/semanage/semanage
index 954411d..b199ebe 100644
--- a/policycoreutils/semanage/semanage
+++ b/policycoreutils/semanage/semanage
@@ -524,7 +524,7 @@  def handleInterface(args):
     if args.action is "add":
         OBJECT.add(args.interface, args.range, args.type)
     if args.action is "modify":
-        OBJECT.add(args.interface, args.range, args.type)
+        OBJECT.modify(args.interface, args.range, args.type)
     if args.action is "delete":
         OBJECT.delete(args.interface)
     if args.action is "list":
@@ -607,7 +607,7 @@  def handleNode(args):
     if args.action is "add":
         OBJECT.add(args.node, args.netmask, args.proto, args.range, args.type)
     if args.action is "modify":
-        OBJECT.add(args.node, args.netmask, args.proto, args.range, args.type)
+        OBJECT.modify(args.node, args.netmask, args.proto, args.range, args.type)
     if args.action is "delete":
         OBJECT.delete(args.node, args.netmask, args.proto)
     if args.action is "list":