From patchwork Fri Jul 29 13:53:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Jurgens X-Patchwork-Id: 9252583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9BB3B6075F for ; Fri, 29 Jul 2016 15:11:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C0E92833B for ; Fri, 29 Jul 2016 15:11:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80D4D28342; Fri, 29 Jul 2016 15:11:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from emsm-gh1-uea10.nsa.gov (emsm-gh1-uea10.nsa.gov [8.44.101.8]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 712912833B for ; Fri, 29 Jul 2016 15:11:45 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.28,440,1464652800"; d="scan'208";a="16070630" IronPort-PHdr: =?us-ascii?q?9a23=3AE62/OBXx4CDQARKGq8H7/wHcx33V8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYZxOPt8tkgFKBZ4jH8fUM07OQ6PG4HzJRqsnQ+Fk5M7V0Hycfjs?= =?us-ascii?q?sXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aJBzzOEJP?= =?us-ascii?q?K/jvHcaK1oLshrj0pcyYPFQArQH+SIs6FA+xowTVu5teqqpZAYF19CH0pGBVcf?= =?us-ascii?q?9d32JiKAHbtR/94sCt4MwrqHwI6Loc7coIbYHWN+R9FOQZX3waNDU+5Nfqrgbr?= =?us-ascii?q?VgyS/T4HVWFQlQBHR0Dd5Qz+do/4ry+/s+16wiTcNsrzCfgvVS+K87ZgSBiujj?= =?us-ascii?q?wOcTE+7iWfh9R5lqNAiAqovR1k24rda4zTM+BxOuvRed4WS21bUu5LWiBBC5/6?= =?us-ascii?q?ZIwKS6IaMO9e6YnwqUcfhRq4GQSoQujoz3sAhnbym7c9yOknCh3B1w8IENcHsX?= =?us-ascii?q?CSp9LwZ4kIVuXg4KDOhRfedfxb3yy1vITBdBEspfOkWL90dcPXzllpHATA2AbD?= =?us-ascii?q?4bf5Ni+Yg7xe+1OQ6PBtAKf202M=3D?= X-IPAS-Result: =?us-ascii?q?A2H7BABZcZtX/wHyM5BdGwEBAYMngVK6fSCHMEwBAQEBAQE?= =?us-ascii?q?CAlongjIEAxCCFAIBAwECNxQgCQIDAwkBARcIIQgIAwEtFREHBwsFGASIEAS8Q?= =?us-ascii?q?QELASSPCREBhXcFjhZxiiyPAIlphVWQKVSCEhyBT2uGNoE1AQEB?= Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by emsm-gh1-uea10.nsa.gov with ESMTP; 29 Jul 2016 15:11:36 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u6TFBZF0012572; Fri, 29 Jul 2016 11:11:36 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u6TDsCd0152204 for ; Fri, 29 Jul 2016 09:54:12 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u6TDsBF9003339 for ; Fri, 29 Jul 2016 09:54:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1DIAQBQX5tXfYGlL8FdHAEBhHm2eIQMhh0CgXgBAQEBAQETAQEWKy+EXQIBA3cCEBgIMVcHEog1vEABMJUSBY4WcYosjwCPPpApgmYcgU85ModrAQEB X-IPAS-Result: A1DIAQBQX5tXfYGlL8FdHAEBhHm2eIQMhh0CgXgBAQEBAQETAQEWKy+EXQIBA3cCEBgIMVcHEog1vEABMJUSBY4WcYosjwCPPpApgmYcgU85ModrAQEB X-IronPort-AV: E=Sophos;i="5.28,439,1464667200"; d="scan'208";a="5610099" Received: from emsm-gh1-uea10.corp.nsa.gov (HELO emsm-gh1-uea10.nsa.gov) ([10.208.41.36]) by goalie.tycho.ncsc.mil with ESMTP; 29 Jul 2016 09:54:11 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3ALx07PxCeGjZ60iyu8pFcUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSP/zosbcNUDSrc9gkEXOFd2CrakV06yI4uu+BSQp2tWoiDg6aptCVhsI24?= =?us-ascii?q?09vjcLJ4q7M3D9N+PgdCcgHc5PBxdP9nC/NlVJSo6lPwWB6kO74TNaIBjjLw09?= =?us-ascii?q?fr2zQd+KyZrmnL7us7ToICxwzAKnZr1zKBjk5S7wjeIxxbVYF6Aq1xHSqWFJce?= =?us-ascii?q?kFjUlhJFaUggqurpzopM0r221qtvkg789NV7nhN+R9FOQATWduD2dg783xtALc?= =?us-ascii?q?ZRCI+2BZSWIS1B1SDEyN9BjnWr/puzb+8+963zOXe8bxSPR8Qji5x7t6Qx/vzi?= =?us-ascii?q?EcPng293+TwsFohbhauzq5rgZ+2JbQaYqYcv1kceeVcdcXSWRGRMp5TSFNAoqg?= =?us-ascii?q?KYAICq5JJutRqc/9qlUSvDO/AxWhAKXkzToMzn//2esg1P8sFxra2wcjN90LuX?= =?us-ascii?q?XQ6t7yMfQ8S+ewmYXBy33hculZ1DHmoNzEexYgrPWOdbd9dc7Yz04/UQjCiwPD?= =?us-ascii?q?+sTeIzqJ27FV4CCg5O16WLfq0jZ/pg=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0H8AgDjXptXfYGlL8FdHAEBhHm2eIQMh?= =?us-ascii?q?h0CgXgBAQEBAQECAg8BARYrL4IyBAESAYITAgEDdwIQGAgxVwcSiDW8PgEwlRI?= =?us-ascii?q?FjhZxiiyPAI8+kCmCZhyBTzkyh2sBAQE?= X-IPAS-Result: =?us-ascii?q?A0H8AgDjXptXfYGlL8FdHAEBhHm2eIQMhh0CgXgBAQEBAQE?= =?us-ascii?q?CAg8BARYrL4IyBAESAYITAgEDdwIQGAgxVwcSiDW8PgEwlRIFjhZxiiyPAI8+k?= =?us-ascii?q?CmCZhyBTzkyh2sBAQE?= X-IronPort-AV: E=Sophos;i="5.28,439,1464652800"; d="scan'208";a="16065407" Received: from mail-il-dmz.mellanox.com (HELO mellanox.co.il) ([193.47.165.129]) by emsm-gh1-uea10.nsa.gov with ESMTP; 29 Jul 2016 13:54:10 +0000 Received: from Internal Mail-Server by MTLPINE1 (envelope-from danielj@mellanox.com) with ESMTPS (AES256-SHA encrypted); 29 Jul 2016 16:54:06 +0300 Received: from x-vnc01.mtx.labs.mlnx (x-vnc01.mtx.labs.mlnx [10.12.150.16]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id u6TDrgir021752; Fri, 29 Jul 2016 16:54:03 +0300 From: Dan Jurgens To: chrisw@sous-sol.org, paul@paul-moore.com, sds@tycho.nsa.gov, eparis@parisplace.org, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com Subject: [PATCH v3 3/9] selinux lsm IB/core: Implement LSM notification system Date: Fri, 29 Jul 2016 16:53:30 +0300 Message-Id: <1469800416-125043-4-git-send-email-danielj@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1469800416-125043-1-git-send-email-danielj@mellanox.com> References: <1469800416-125043-1-git-send-email-danielj@mellanox.com> X-Mailman-Approved-At: Fri, 29 Jul 2016 11:02:35 -0400 X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Cc: linux-rdma@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Jurgens Add a generic notificaiton mechanism in the LSM. Interested consumers can register a callback with the LSM and security modules can produce events. Because access to Infiniband QPs are enforced in the setup phase of a connection security should be enforced again if the policy changes. Register infiniband devices for policy change notification and check all QPs on that device when the notification is received. Add a call to the notification mechanism from SELinux when the AVC cache changes or setenforce is cleared. Signed-off-by: Daniel Jurgens --- v2: - new patch that has the generic notification, replaces selinux and IB/core patches related to the ib_flush callback. Yuval Shaia and Paul Moore v3: - use notifier chains. Paul Moore drivers/infiniband/core/device.c | 53 ++++++++++++++++++++++++++++++++++++++++ include/linux/security.h | 8 ++++++ security/security.c | 20 +++++++++++++++ security/selinux/hooks.c | 5 ++-- security/selinux/selinuxfs.c | 2 ++ 5 files changed, 86 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index 5b42e83..7b6fd06 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -39,6 +39,8 @@ #include #include #include +#include +#include #include #include #include @@ -82,6 +84,14 @@ static LIST_HEAD(client_list); static DEFINE_MUTEX(device_mutex); static DECLARE_RWSEM(lists_rwsem); +static int ib_security_change(struct notifier_block *nb, unsigned long event, + void *lsm_data); +static void ib_policy_change_task(struct work_struct *work); +static DECLARE_WORK(ib_policy_change_work, ib_policy_change_task); + +static struct notifier_block ibdev_lsm_nb = { + .notifier_call = ib_security_change, +}; static int ib_device_check_mandatory(struct ib_device *device) { @@ -344,6 +354,40 @@ static int setup_port_pkey_list(struct ib_device *device) return 0; } +static void ib_policy_change_task(struct work_struct *work) +{ + struct ib_device *dev; + + down_read(&lists_rwsem); + list_for_each_entry(dev, &device_list, core_list) { + int i; + + for (i = rdma_start_port(dev); i <= rdma_end_port(dev); i++) { + u64 sp; + int ret = ib_get_cached_subnet_prefix(dev, + i, + &sp); + + WARN_ONCE(ret, + "ib_get_cached_subnet_prefix err: %d, this should never happen here\n", + ret); + ib_security_cache_change(dev, i, sp); + } + } + up_read(&lists_rwsem); +} + +static int ib_security_change(struct notifier_block *nb, unsigned long event, + void *lsm_data) +{ + if (event != LSM_POLICY_CHANGE) + return NOTIFY_DONE; + + schedule_work(&ib_policy_change_work); + + return NOTIFY_OK; +} + /** * ib_register_device - Register an IB device with IB core * @device:Device to register @@ -1075,10 +1119,18 @@ static int __init ib_core_init(void) goto err_sa; } + ret = register_lsm_notifier(&ibdev_lsm_nb); + if (ret) { + pr_warn("Couldn't register LSM notifier. ret %d\n", ret); + goto err_ibnl_clients; + } + ib_cache_setup(); return 0; +err_ibnl_clients: + ib_remove_ibnl_clients(); err_sa: ib_sa_cleanup(); err_mad: @@ -1098,6 +1150,7 @@ err: static void __exit ib_core_cleanup(void) { + unregister_lsm_notifier(&ibdev_lsm_nb); ib_cache_cleanup(); ib_remove_ibnl_clients(); ib_sa_cleanup(); diff --git a/include/linux/security.h b/include/linux/security.h index 0bd8319..84abc05 100644 --- a/include/linux/security.h +++ b/include/linux/security.h @@ -69,6 +69,14 @@ struct audit_krule; struct user_namespace; struct timezone; +enum lsm_event { + LSM_POLICY_CHANGE, +}; + +int call_lsm_notifier(enum lsm_event event, void *data); +int register_lsm_notifier(struct notifier_block *nb); +int unregister_lsm_notifier(struct notifier_block *nb); + /* These functions are in security/commoncap.c */ extern int cap_capable(const struct cred *cred, struct user_namespace *ns, int cap, int audit); diff --git a/security/security.c b/security/security.c index 45b6dc0..8b8ddb2 100644 --- a/security/security.c +++ b/security/security.c @@ -33,6 +33,8 @@ /* Maximum number of letters for an LSM name string */ #define SECURITY_NAME_MAX 10 +static ATOMIC_NOTIFIER_HEAD(lsm_notifier_chain); + /* Boot-time LSM user choice */ static __initdata char chosen_lsm[SECURITY_NAME_MAX + 1] = CONFIG_DEFAULT_SECURITY; @@ -98,6 +100,24 @@ int __init security_module_enable(const char *module) return !strcmp(module, chosen_lsm); } +int call_lsm_notifier(enum lsm_event event, void *data) +{ + return atomic_notifier_call_chain(&lsm_notifier_chain, event, data); +} +EXPORT_SYMBOL(call_lsm_notifier); + +int register_lsm_notifier(struct notifier_block *nb) +{ + return atomic_notifier_chain_register(&lsm_notifier_chain, nb); +} +EXPORT_SYMBOL(register_lsm_notifier); + +int unregister_lsm_notifier(struct notifier_block *nb) +{ + return atomic_notifier_chain_unregister(&lsm_notifier_chain, nb); +} +EXPORT_SYMBOL(unregister_lsm_notifier); + /* * Hook list operation macros. * diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index a86d537..7c22703 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -159,13 +159,14 @@ static int selinux_peerlbl_enabled(void) return (selinux_policycap_alwaysnetwork || netlbl_enabled() || selinux_xfrm_enabled()); } -static int selinux_netcache_avc_callback(u32 event) +static int selinux_cache_avc_callback(u32 event) { if (event == AVC_CALLBACK_RESET) { sel_netif_flush(); sel_netnode_flush(); sel_netport_flush(); synchronize_net(); + call_lsm_notifier(LSM_POLICY_CHANGE, NULL); } return 0; } @@ -6235,7 +6236,7 @@ static __init int selinux_init(void) security_add_hooks(selinux_hooks, ARRAY_SIZE(selinux_hooks)); - if (avc_add_callback(selinux_netcache_avc_callback, AVC_CALLBACK_RESET)) + if (avc_add_callback(selinux_cache_avc_callback, AVC_CALLBACK_RESET)) panic("SELinux: Unable to register AVC netcache callback\n"); if (selinux_enforcing) diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 1b1fd27..983bf2a 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -177,6 +177,8 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf, avc_ss_reset(0); selnl_notify_setenforce(selinux_enforcing); selinux_status_update_setenforce(selinux_enforcing); + if (!selinux_enforcing) + call_lsm_notifier(LSM_POLICY_CHANGE, NULL); } length = count; out: