diff mbox

[v5] Build the SELinux testsuite on systems using the Reference Policy

Message ID 1472236590.14055.3.camel@trentalancia.net (mailing list archive)
State Not Applicable
Headers show

Commit Message

Guido Trentalancia Aug. 26, 2016, 6:36 p.m. UTC
Sorry about that ! I did not test it properly because I was hitting a
problem with the policy...

The following one should work, although it's slightly noisy...

Fix the Makefile in the policy subdirectory of the SELinux testsuite
so that it builds correctly on the standard Reference Policy which
does not have the same booleans available on Red Hat.

Previous versions were not working within the Makefile.

Signed-off-by: Guido Trentalancia <guido@trentalancia.net>
---
 policy/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Smalley Sept. 1, 2016, 12:38 p.m. UTC | #1
On 08/26/2016 02:36 PM, Guido Trentalancia wrote:
> Sorry about that ! I did not test it properly because I was hitting a
> problem with the policy...
> 
> The following one should work, although it's slightly noisy...
> 
> Fix the Makefile in the policy subdirectory of the SELinux testsuite
> so that it builds correctly on the standard Reference Policy which
> does not have the same booleans available on Red Hat.
> 
> Previous versions were not working within the Makefile.
> 
> Signed-off-by: Guido Trentalancia <guido@trentalancia.net>

Thanks, applied.

> ---
>  policy/Makefile |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- selinux-testsuite-git-23082016-orig/policy/Makefile	2016-08-23 20:50:08.527633728 +0200
> +++ selinux-testsuite-git-23082016/policy/Makefile	2016-08-26 20:33:01.677418513 +0200
> @@ -68,7 +69,7 @@ load_rhel: all
>  
>  load_general: all
>  	# General policy load
> -	/usr/sbin/setsebool allow_domain_fd_use=0
> +	@-/usr/sbin/setsebool allow_domain_fd_use=0
>  	$(SEMODULE) -i test_policy/test_policy.pp
>  
>  unload_rhel:
> @@ -77,7 +78,7 @@ unload_rhel:
>  
>  unload_general:
>  	# General policy unload
> -	/usr/sbin/setsebool allow_domain_fd_use=1
> +	@-/usr/sbin/setsebool allow_domain_fd_use=1
>  	$(SEMODULE) -r test_policy
>  
>  clean:
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
>
Guido Trentalancia Sept. 1, 2016, 12:39 p.m. UTC | #2
Hello Stephen.

Thanks very much for applying the patch.

Guido

On Thu, 01/09/2016 at 08.38 -0400, Stephen Smalley wrote:
> On 08/26/2016 02:36 PM, Guido Trentalancia wrote:
> > 
> > Sorry about that ! I did not test it properly because I was hitting
> > a
> > problem with the policy...
> > 
> > The following one should work, although it's slightly noisy...
> > 
> > Fix the Makefile in the policy subdirectory of the SELinux
> > testsuite
> > so that it builds correctly on the standard Reference Policy which
> > does not have the same booleans available on Red Hat.
> > 
> > Previous versions were not working within the Makefile.
> > 
> > Signed-off-by: Guido Trentalancia <guido@trentalancia.net>
> 
> Thanks, applied.


> > 
> > ---
> >  policy/Makefile |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- selinux-testsuite-git-23082016-orig/policy/Makefile	2016
> > -08-23 20:50:08.527633728 +0200
> > +++ selinux-testsuite-git-23082016/policy/Makefile	2016-08-
> > 26 20:33:01.677418513 +0200
> > @@ -68,7 +69,7 @@ load_rhel: all
> >  
> >  load_general: all
> >  	# General policy load
> > -	/usr/sbin/setsebool allow_domain_fd_use=0
> > +	@-/usr/sbin/setsebool allow_domain_fd_use=0
> >  	$(SEMODULE) -i test_policy/test_policy.pp
> >  
> >  unload_rhel:
> > @@ -77,7 +78,7 @@ unload_rhel:
> >  
> >  unload_general:
> >  	# General policy unload
> > -	/usr/sbin/setsebool allow_domain_fd_use=1
> > +	@-/usr/sbin/setsebool allow_domain_fd_use=1
> >  	$(SEMODULE) -r test_policy
> >  
> >  clean:
> >
diff mbox

Patch

--- selinux-testsuite-git-23082016-orig/policy/Makefile	2016-08-23 20:50:08.527633728 +0200
+++ selinux-testsuite-git-23082016/policy/Makefile	2016-08-26 20:33:01.677418513 +0200
@@ -68,7 +69,7 @@  load_rhel: all
 
 load_general: all
 	# General policy load
-	/usr/sbin/setsebool allow_domain_fd_use=0
+	@-/usr/sbin/setsebool allow_domain_fd_use=0
 	$(SEMODULE) -i test_policy/test_policy.pp
 
 unload_rhel:
@@ -77,7 +78,7 @@  unload_rhel:
 
 unload_general:
 	# General policy unload
-	/usr/sbin/setsebool allow_domain_fd_use=1
+	@-/usr/sbin/setsebool allow_domain_fd_use=1
 	$(SEMODULE) -r test_policy
 
 clean: