From patchwork Fri Sep 23 19:24:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Roberts, William C" X-Patchwork-Id: 9348685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 929AE6077A for ; Fri, 23 Sep 2016 19:28:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 830632AD98 for ; Fri, 23 Sep 2016 19:28:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75EB52AD9B; Fri, 23 Sep 2016 19:28:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from emsm-gh1-uea11.nsa.gov (smtp.nsa.gov [8.44.101.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CFE5F2AD98 for ; Fri, 23 Sep 2016 19:28:17 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.30,383,1470700800"; d="scan'208";a="19516991" IronPort-PHdr: =?us-ascii?q?9a23=3AlNAuJx0W7QOAzFcVsmDT+DRfVm0co7zxezQtwd8Z?= =?us-ascii?q?segQKPad9pjvdHbS+e9qxAeQG96KsbQc1KGP6fGocFdDyK7JiGoFfp1IWk1Nou?= =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXsq3G/pQQfBg/4fVIs?= =?us-ascii?q?YL+kQMiK0I/ujbH60qaQSj0AvCC6b7J2IUf+hiTqne5Sv7FfLL0swADCuHpCdr?= =?us-ascii?q?ce72ppIVWOg0S0vZ/or9Ze6SAYh9YNv44FCP27LOwESulDATAnNX0lzNH6vhnE?= =?us-ascii?q?Cw2U7z0TVXtS2gFEGCDZ/Rr6WdH3qSK8ue1jiweAOsijUrEwXTWr6uFgDgXvgi?= =?us-ascii?q?odKyUR8WfLh8g2h6Ve80HpnAB234OBONLdD/F5ZK6IOIpCSA=3D=3D?= X-IPAS-Result: =?us-ascii?q?A2FZBQBrgeVX/wHyM5BdHAEBBAEBCgEBFwEBBAEBCgEBgxA?= =?us-ascii?q?BAQEBAR6BU6Y0lEEjh2tMAQEBAQEBAQECAQJbJ4IyBAMTBYIYAjcUIA4DCQIXC?= =?us-ascii?q?CEICAMBLRUYBwsFGASIKr03ASSIO4ZkAhEBhXoFjyuKS49oAol7hWwCSJAfVIU?= =?us-ascii?q?lUgGFJA8XYYEnAQEB?= Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by emsm-gh1-uea11.nsa.gov with ESMTP; 23 Sep 2016 19:28:12 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u8NJRavo029989; Fri, 23 Sep 2016 15:27:46 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u8NJPwJL198503 for ; Fri, 23 Sep 2016 15:25:58 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u8NJPv3G029897; Fri, 23 Sep 2016 15:25:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1A9BAAggeVX/yNjr8ZdGgEBAQECAQEBAQgBAQEBgzsBAQEBAR6BU7ZshBMUhgqBZkwBAgEBAQEBAl6GCDCBDxKIS70rMYg7hmSGDgWPK4pLj2gCj2cCSJAfVIUlHjQBhSSCLgEBAQ X-IPAS-Result: A1A9BAAggeVX/yNjr8ZdGgEBAQECAQEBAQgBAQEBgzsBAQEBAR6BU7ZshBMUhgqBZkwBAgEBAQEBAl6GCDCBDxKIS70rMYg7hmSGDgWPK4pLj2gCj2cCSJAfVIUlHjQBhSSCLgEBAQ X-IronPort-AV: E=Sophos;i="5.30,383,1470715200"; d="scan'208";a="5726004" Received: from emsm-gh1-uea11.corp.nsa.gov (HELO emsm-gh1-uea11.nsa.gov) ([10.208.41.37]) by goalie.tycho.ncsc.mil with ESMTP; 23 Sep 2016 15:25:57 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3Ao3K5zx2zr8LmcmqasmDT+DRfVm0co7zxezQtwd8Z?= =?us-ascii?q?segQI/ad9pjvdHbS+e9qxAeQG96KsbQc1KGP6fGocFdDyK7JiGoFfp1IWk1Nou?= =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXsq3G/pQQfBg/4fVIs?= =?us-ascii?q?YL+kQMiK0I/ujbH60qaQSj0AvCC6b7J2IUf+hiTqne5Sv7FfLL0swADCuHpCdr?= =?us-ascii?q?ce72ppIVWOg0S0vZ/or9ZLuh5dsPM59sNGTb6yP+FhFeQZX3waNDUu6cnqswTT?= =?us-ascii?q?ZRee7XsbFGMNm1xHBBaBpAr2Rb/toyD6sax7wyDcMsroHp4uXjH38KZvTB7hjW?= =?us-ascii?q?EMcSQ++mzNltdYjaRHrRbnrBt6kN2cW52cKPcrJvCVRtgdX2cUG58JDyE=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0HABABvgOVX/yNjr8ZdGwEBAQMBAQEJA?= =?us-ascii?q?QEBFwEBBAEBCgEBgxABAQEBAR6BU6Y0kDiEExSGCoFmTAEBAQEBAQEBAgECWye?= =?us-ascii?q?CMgQBFQEEgxAwgQ8SiEu9KwwliDuGZIYOBY8rikuPaAKPZwJIkB9UhSUeNAGFJ?= =?us-ascii?q?G6BQAEBAQ?= X-IPAS-Result: =?us-ascii?q?A0HABABvgOVX/yNjr8ZdGwEBAQMBAQEJAQEBFwEBBAEBCgE?= =?us-ascii?q?BgxABAQEBAR6BU6Y0kDiEExSGCoFmTAEBAQEBAQEBAgECWyeCMgQBFQEEgxAwg?= =?us-ascii?q?Q8SiEu9KwwliDuGZIYOBY8rikuPaAKPZwJIkB9UhSUeNAGFJG6BQAEBAQ?= X-IronPort-AV: E=Sophos;i="5.30,383,1470700800"; d="scan'208";a="19516919" Received: from fmsmga002-icc.fm.intel.com ([198.175.99.35]) by emsm-gh1-uea11.nsa.gov with ESMTP; 23 Sep 2016 19:25:56 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga002-icc.fm.intel.com with ESMTP; 23 Sep 2016 12:25:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,383,1470726000"; d="scan'208";a="883176987" Received: from psethi-mobl11.amr.corp.intel.com (HELO wcrobert-MOBL1.amr.corp.intel.com) ([10.254.124.71]) by orsmga003.jf.intel.com with ESMTP; 23 Sep 2016 12:25:55 -0700 From: william.c.roberts@intel.com To: selinux@tycho.nsa.gov, sds@tycho.nsa.gov Subject: [PATCH] libselinux: kill logging check for selinux_enabled() Date: Fri, 23 Sep 2016 12:24:10 -0700 Message-Id: <1474658650-10685-1-git-send-email-william.c.roberts@intel.com> X-Mailer: git-send-email 1.9.1 X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP From: William Roberts Drop the check for selinux_enabled() on logging. The caller can silence the logs by setting the logging callback and discarding the messages. Change-Id: Ia6769ef7ad8cc2144ad2bb73e5bf7c76ebfe487b Signed-off-by: William Roberts --- libselinux/src/callbacks.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libselinux/src/callbacks.c b/libselinux/src/callbacks.c index cdf7b63..c3cf98b 100644 --- a/libselinux/src/callbacks.c +++ b/libselinux/src/callbacks.c @@ -16,7 +16,6 @@ default_selinux_log(int type __attribute__((unused)), const char *fmt, ...) { int rc; va_list ap; - if (is_selinux_enabled() == 0) return 0; va_start(ap, fmt); rc = vfprintf(stderr, fmt, ap); va_end(ap);