From patchwork Tue Nov 1 20:23:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Roberts, William C" X-Patchwork-Id: 9408023 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A92960585 for ; Tue, 1 Nov 2016 20:23:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8459129A11 for ; Tue, 1 Nov 2016 20:23:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 77FF529A91; Tue, 1 Nov 2016 20:23:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from emsm-gh1-uea10.nsa.gov (smtp.nsa.gov [8.44.101.8]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0D34429A11 for ; Tue, 1 Nov 2016 20:23:51 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.31,433,1473120000"; d="scan'208";a="504947" IronPort-PHdr: =?us-ascii?q?9a23=3A7xl5GRH4dneKrtCsZYwpBJ1GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ75ocqwAkXT6L1XgUPTWs2DsrQf2rCQ4/mrADZeqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i760zceF13FOBZv?= =?us-ascii?q?IaytQ8iJ3p7xh7n5oseNKyxzxxOFKYtoKxu3qQiD/uI3uqBFbpgL9x3Sv3FTcP?= =?us-ascii?q?5Xz247bXianhL7+9vitMU7q3cYhuglv/Jkfe26Ov1gDO8QMDNzNWE+48nirl/C?= =?us-ascii?q?SgyU/VMZDnVQlQBHR0De4RX7WIrhmjfrvep6ni+BNIv5Sq5ndy6l6vJ0SRvsiS?= =?us-ascii?q?4CcTV/6mbdh9Zsl4papg6so1p0xIuHM8muKPNic/aFLpshTm1bU5MUDnRM?= X-IPAS-Result: =?us-ascii?q?A2EzBACi+BhY/wHyM5BdGgEBAQECAQEBAQgBAQEBFQEBAQE?= =?us-ascii?q?CAQEBAQgBAQEBgn8BAQEBAR+BVKYRlGUpiB1TAQEBAQEBAQECAQJfKIIzBAMTB?= =?us-ascii?q?YIXAjcUIAsDAwkCFwghCAgDAS0VGAcLBRgEiDO4VwEKAQEBI4hChmkRAYV8BYg?= =?us-ascii?q?/hwdEihCQNQKKCIV6ApEXVIYTUgGFL3iBNAEBAQ?= Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by emsm-gh1-uea10.nsa.gov with ESMTP; 01 Nov 2016 20:23:50 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id uA1KNeFC005479; Tue, 1 Nov 2016 16:23:42 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id uA1KNdP7037587 for ; Tue, 1 Nov 2016 16:23:39 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id uA1KNdSP005473; Tue, 1 Nov 2016 16:23:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1DCAwDP+BhY/yNjr8ZdGgEBAQECAQEBAQgBAQEBgyoBAQEBAR+BVLZshBYYhgqCGFMBAgEBAQEBAmKGCTCBDxKIVLhZATCIQoljC4MJBYg/hwdEihCQNQKQAgKRF1SGE1IBh1sBAQE X-IPAS-Result: A1DCAwDP+BhY/yNjr8ZdGgEBAQECAQEBAQgBAQEBgyoBAQEBAR+BVLZshBYYhgqCGFMBAgEBAQEBAmKGCTCBDxKIVLhZATCIQoljC4MJBYg/hwdEihCQNQKQAgKRF1SGE1IBh1sBAQE X-IronPort-AV: E=Sophos;i="5.31,433,1473134400"; d="scan'208";a="5799414" Received: from emsm-gh1-uea11.corp.nsa.gov (HELO emsm-gh1-uea11.nsa.gov) ([10.208.41.37]) by goalie.tycho.ncsc.mil with ESMTP; 01 Nov 2016 16:23:38 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3AjzkryxGgYwCvw+6/eKAmMJ1GYnF86YWxBRYc798d?= =?us-ascii?q?s5kLTJ75oM+wAkXT6L1XgUPTWs2DsrQf2rCQ4/mrADZeqb+681k6OKRWUBEEjc?= =?us-ascii?q?hE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i760zceF13FOBZv?= =?us-ascii?q?IaytQ8iJ3p7xh7n5oseNKyxzxxOFKYtoKxu3qQiD/uI3uqBFbpgL9x3Sv3FTcP?= =?us-ascii?q?5Xz247bXianhL7+9vitMU7q3cYk7sb+sVBSaT3ebgjBfwdVWx+cjN92Mq+sxjI?= =?us-ascii?q?Sg+G/T0dVWINiTJNXxiD6wv1Gt/qvy/7sPdt8DWLNs3xC7YvUHKt6Lk4ZgXvjX?= =?us-ascii?q?IYNjo98WjSzMc2lqVRrQi9vDR+xZLZZMeeM/8tLevmYdoGSD8ZDY5qXCtbD9b5?= =?us-ascii?q?NtNXAg=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0EzBACi+BhY/yNjr8ZdGgEBAQECAQEBA?= =?us-ascii?q?QgBAQEBFgEBAQMBAQEJAQEBgn8BAQEBAR+BVKYRkFuEFhiGCoIYUwEBAQEBAQE?= =?us-ascii?q?BAgECXyiCMwQBFQEEgw8wgQ8SiFS4VwELJYhCjHcFiD+HB0SKEJA1ApACApEXV?= =?us-ascii?q?IYTUgGGDoFNAQEB?= X-IPAS-Result: =?us-ascii?q?A0EzBACi+BhY/yNjr8ZdGgEBAQECAQEBAQgBAQEBFgEBAQM?= =?us-ascii?q?BAQEJAQEBgn8BAQEBAR+BVKYRkFuEFhiGCoIYUwEBAQEBAQEBAgECXyiCMwQBF?= =?us-ascii?q?QEEgw8wgQ8SiFS4VwELJYhCjHcFiD+HB0SKEJA1ApACApEXVIYTUgGGDoFNAQE?= =?us-ascii?q?B?= X-IronPort-AV: E=Sophos;i="5.31,433,1473120000"; d="scan'208";a="409332" Received: from fmsmga002-icc.fm.intel.com ([198.175.99.35]) by emsm-gh1-uea11.nsa.gov with ESMTP; 01 Nov 2016 20:23:37 +0000 Received: from fmsmga004-icc.fm.intel.com ([198.175.99.11]) by fmsmga002-icc.fm.intel.com with ESMTP; 01 Nov 2016 13:23:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,433,1473145200"; d="scan'208";a="186464498" Received: from cmrodrig-mobl.amr.corp.intel.com (HELO wcrobert-MOBL1.amr.corp.intel.com) ([10.254.111.80]) by fmsmga004.fm.intel.com with ESMTP; 01 Nov 2016 13:23:36 -0700 From: william.c.roberts@intel.com To: nicolas.iooss@m4x.org, selinux@tycho.nsa.gov Subject: [PATCH] libselinux: fix compiler flags for linux + clang Date: Tue, 1 Nov 2016 13:23:24 -0700 Message-Id: <1478031804-13993-1-git-send-email-william.c.roberts@intel.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Cc: sds@tycho.nsa.gov MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP From: William Roberts As reported by Nicolas Iooss, the clang + linux build seems broken: clang-3.9: warning: argument unused during compilation: '-undefined dynamic_lookup' /usr/bin/ld: unrecognised option: -install_name clang-3.9: error: linker command failed with exit code 1 (use -v to see invocation) We already have those options set for Darwin, just drop them from the clang side. Signed-off-by: William Roberts --- libselinux/src/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile index ae40f80..b92fe1c 100644 --- a/libselinux/src/Makefile +++ b/libselinux/src/Makefile @@ -73,13 +73,12 @@ override CFLAGS += -fipa-pure-const -Wlogical-op -Wpacked-bitfield-compat -Wsync -Wno-suggest-attribute=pure -Wno-suggest-attribute=const -Wp,-D_FORTIFY_SOURCE=2 else override CFLAGS += -Wunused-command-line-argument -override LDFLAGS += -L/opt/local/lib -undefined dynamic_lookup -LD_SONAME_FLAGS=-install_name,$(LIBSO) endif ifeq ($(OS), Darwin) override CFLAGS += -I/opt/local/include override LDFLAGS += -L/opt/local/lib -undefined dynamic_lookup +LD_SONAME_FLAGS=-install_name,$(LIBSO) endif PCRE_LDFLAGS ?= -lpcre