diff mbox series

[2/2] semanage: add a missing space in ibendport help

Message ID 20180905214906.11016-2-nicolas.iooss@m4x.org (mailing list archive)
State Not Applicable
Headers show
Series [1/2] semanage: "semanage user" does not use -s, fix documentation | expand

Commit Message

Nicolas Iooss Sept. 5, 2018, 9:49 p.m. UTC 
Currently, in:

    # semanage ibendport --help
    usage: semanage ibendport [-h] [-n] [-N] [-s STORE] [ --add -t TYPE
    -z IBDEV_NAME -r RANGE ( port ) | --delete -z IBDEV_NAME -r RANGE(
    port ) | --deleteall  | --extract  | --list -C | --modify -t TYPE -z
    IBDEV_NAME -r RANGE ( port ) ]

... a space is missing between "RANGE" and "( port )" in the usage of
--delete. Add it by splitting the string correctly in the usage line
definition.

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---
 python/semanage/semanage | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

William Roberts Sept. 6, 2018, 7:48 p.m. UTC | #1 
ack

On Wed, Sep 5, 2018 at 2:53 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:

> Currently, in:
>
>     # semanage ibendport --help
>     usage: semanage ibendport [-h] [-n] [-N] [-s STORE] [ --add -t TYPE
>     -z IBDEV_NAME -r RANGE ( port ) | --delete -z IBDEV_NAME -r RANGE(
>     port ) | --deleteall  | --extract  | --list -C | --modify -t TYPE -z
>     IBDEV_NAME -r RANGE ( port ) ]
>
> ... a space is missing between "RANGE" and "( port )" in the usage of
> --delete. Add it by splitting the string correctly in the usage line
> definition.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> ---
>  python/semanage/semanage | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/python/semanage/semanage b/python/semanage/semanage
> index e32d1e8ad387..f4be97507c18 100644
> --- a/python/semanage/semanage
> +++ b/python/semanage/semanage
> @@ -62,7 +62,7 @@ usage_ibpkey = "semanage ibpkey [-h] [-n] [-N] [-s
> STORE] ["
>  usage_ibpkey_dict = {' --add': ('-t TYPE', '-x SUBNET_PREFIX', '-r
> RANGE', '(', 'ibpkey_name', '|', 'pkey_range', ')'), ' --modify': ('-t
> TYPE', '-x SUBNET_PREFIX', '-r RANGE', '(', 'ibpkey_name', '|',
> 'pkey_range', ')'), ' --delete': ('-x SUBNET_PREFIX', '(', 'ibpkey_name',
> '|', 'pkey_range', ')'), ' --list': ('-C',), ' --extract': ('',), '
> --deleteall': ('',)}
>
>  usage_ibendport = "semanage ibendport [-h] [-n] [-N] [-s STORE] ["
> -usage_ibendport_dict = {' --add': ('-t TYPE', '-z IBDEV_NAME', '-r
> RANGE', '(', 'port', ')'), ' --modify': ('-t TYPE', '-z IBDEV_NAME', '-r
> RANGE', '(', 'port', ')'), ' --delete': ('-z IBDEV_NAME', '-r RANGE''(',
> 'port', ')'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall':
> ('',)}
> +usage_ibendport_dict = {' --add': ('-t TYPE', '-z IBDEV_NAME', '-r
> RANGE', '(', 'port', ')'), ' --modify': ('-t TYPE', '-z IBDEV_NAME', '-r
> RANGE', '(', 'port', ')'), ' --delete': ('-z IBDEV_NAME', '-r RANGE', '(',
> 'port', ')'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall':
> ('',)}
>
>  usage_node = "semanage node [-h] [-n] [-N] [-S STORE] ["
>  usage_node_dict = {' --add': ('-M NETMASK', '-p PROTOCOL', '-t TYPE', '-r
> RANGE', 'node'), ' --modify': ('-M NETMASK', '-p PROTOCOL', '-t TYPE', '-r
> RANGE', 'node'), ' --delete': ('-M NETMASK', '-p PROTOCOL', 'node'), '
> --list': ('-C',), ' --extract': ('',), ' --deleteall': ('',)}
> --
> 2.18.0
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to
> Selinux-request@tycho.nsa.gov.
>
<div dir="ltr">ack</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 5, 2018 at 2:53 PM Nicolas Iooss &lt;<a href="mailto:nicolas.iooss@m4x.org">nicolas.iooss@m4x.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Currently, in:<br>
<br>
    # semanage ibendport --help<br>
    usage: semanage ibendport [-h] [-n] [-N] [-s STORE] [ --add -t TYPE<br>
    -z IBDEV_NAME -r RANGE ( port ) | --delete -z IBDEV_NAME -r RANGE(<br>
    port ) | --deleteall  | --extract  | --list -C | --modify -t TYPE -z<br>
    IBDEV_NAME -r RANGE ( port ) ]<br>
<br>
... a space is missing between &quot;RANGE&quot; and &quot;( port )&quot; in the usage of<br>
--delete. Add it by splitting the string correctly in the usage line<br>
definition.<br>
<br>
Signed-off-by: Nicolas Iooss &lt;<a href="mailto:nicolas.iooss@m4x.org" target="_blank">nicolas.iooss@m4x.org</a>&gt;<br>
---<br>
 python/semanage/semanage | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/python/semanage/semanage b/python/semanage/semanage<br>
index e32d1e8ad387..f4be97507c18 100644<br>
--- a/python/semanage/semanage<br>
+++ b/python/semanage/semanage<br>
@@ -62,7 +62,7 @@ usage_ibpkey = &quot;semanage ibpkey [-h] [-n] [-N] [-s STORE] [&quot;<br>
 usage_ibpkey_dict = {&#39; --add&#39;: (&#39;-t TYPE&#39;, &#39;-x SUBNET_PREFIX&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;ibpkey_name&#39;, &#39;|&#39;, &#39;pkey_range&#39;, &#39;)&#39;), &#39; --modify&#39;: (&#39;-t TYPE&#39;, &#39;-x SUBNET_PREFIX&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;ibpkey_name&#39;, &#39;|&#39;, &#39;pkey_range&#39;, &#39;)&#39;), &#39; --delete&#39;: (&#39;-x SUBNET_PREFIX&#39;, &#39;(&#39;, &#39;ibpkey_name&#39;, &#39;|&#39;, &#39;pkey_range&#39;, &#39;)&#39;), &#39; --list&#39;: (&#39;-C&#39;,), &#39; --extract&#39;: (&#39;&#39;,), &#39; --deleteall&#39;: (&#39;&#39;,)}<br>
<br>
 usage_ibendport = &quot;semanage ibendport [-h] [-n] [-N] [-s STORE] [&quot;<br>
-usage_ibendport_dict = {&#39; --add&#39;: (&#39;-t TYPE&#39;, &#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --modify&#39;: (&#39;-t TYPE&#39;, &#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --delete&#39;: (&#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;&#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --list&#39;: (&#39;-C&#39;,), &#39; --extract&#39;: (&#39;&#39;,), &#39; --deleteall&#39;: (&#39;&#39;,)}<br>
+usage_ibendport_dict = {&#39; --add&#39;: (&#39;-t TYPE&#39;, &#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --modify&#39;: (&#39;-t TYPE&#39;, &#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --delete&#39;: (&#39;-z IBDEV_NAME&#39;, &#39;-r RANGE&#39;, &#39;(&#39;, &#39;port&#39;, &#39;)&#39;), &#39; --list&#39;: (&#39;-C&#39;,), &#39; --extract&#39;: (&#39;&#39;,), &#39; --deleteall&#39;: (&#39;&#39;,)}<br>
<br>
 usage_node = &quot;semanage node [-h] [-n] [-N] [-S STORE] [&quot;<br>
 usage_node_dict = {&#39; --add&#39;: (&#39;-M NETMASK&#39;, &#39;-p PROTOCOL&#39;, &#39;-t TYPE&#39;, &#39;-r RANGE&#39;, &#39;node&#39;), &#39; --modify&#39;: (&#39;-M NETMASK&#39;, &#39;-p PROTOCOL&#39;, &#39;-t TYPE&#39;, &#39;-r RANGE&#39;, &#39;node&#39;), &#39; --delete&#39;: (&#39;-M NETMASK&#39;, &#39;-p PROTOCOL&#39;, &#39;node&#39;), &#39; --list&#39;: (&#39;-C&#39;,), &#39; --extract&#39;: (&#39;&#39;,), &#39; --deleteall&#39;: (&#39;&#39;,)}<br>
-- <br>
2.18.0<br>
<br>
_______________________________________________<br>
Selinux mailing list<br>
<a href="mailto:Selinux@tycho.nsa.gov" target="_blank">Selinux@tycho.nsa.gov</a><br>
To unsubscribe, send email to <a href="mailto:Selinux-leave@tycho.nsa.gov" target="_blank">Selinux-leave@tycho.nsa.gov</a>.<br>
To get help, send an email containing &quot;help&quot; to <a href="mailto:Selinux-request@tycho.nsa.gov" target="_blank">Selinux-request@tycho.nsa.gov</a>.<br>
</blockquote></div>
diff mbox series

Patch

diff --git a/python/semanage/semanage b/python/semanage/semanage
index e32d1e8ad387..f4be97507c18 100644
--- a/python/semanage/semanage
+++ b/python/semanage/semanage
@@ -62,7 +62,7 @@  usage_ibpkey = "semanage ibpkey [-h] [-n] [-N] [-s STORE] ["
 usage_ibpkey_dict = {' --add': ('-t TYPE', '-x SUBNET_PREFIX', '-r RANGE', '(', 'ibpkey_name', '|', 'pkey_range', ')'), ' --modify': ('-t TYPE', '-x SUBNET_PREFIX', '-r RANGE', '(', 'ibpkey_name', '|', 'pkey_range', ')'), ' --delete': ('-x SUBNET_PREFIX', '(', 'ibpkey_name', '|', 'pkey_range', ')'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall': ('',)}
 
 usage_ibendport = "semanage ibendport [-h] [-n] [-N] [-s STORE] ["
-usage_ibendport_dict = {' --add': ('-t TYPE', '-z IBDEV_NAME', '-r RANGE', '(', 'port', ')'), ' --modify': ('-t TYPE', '-z IBDEV_NAME', '-r RANGE', '(', 'port', ')'), ' --delete': ('-z IBDEV_NAME', '-r RANGE''(', 'port', ')'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall': ('',)}
+usage_ibendport_dict = {' --add': ('-t TYPE', '-z IBDEV_NAME', '-r RANGE', '(', 'port', ')'), ' --modify': ('-t TYPE', '-z IBDEV_NAME', '-r RANGE', '(', 'port', ')'), ' --delete': ('-z IBDEV_NAME', '-r RANGE', '(', 'port', ')'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall': ('',)}
 
 usage_node = "semanage node [-h] [-n] [-N] [-S STORE] ["
 usage_node_dict = {' --add': ('-M NETMASK', '-p PROTOCOL', '-t TYPE', '-r RANGE', 'node'), ' --modify': ('-M NETMASK', '-p PROTOCOL', '-t TYPE', '-r RANGE', 'node'), ' --delete': ('-M NETMASK', '-p PROTOCOL', 'node'), ' --list': ('-C',), ' --extract': ('',), ' --deleteall': ('',)}