From patchwork Sat Sep 22 00:08:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jann Horn via Selinux X-Patchwork-Id: 10611227 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C6AB81709 for ; Sat, 22 Sep 2018 00:10:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B656C2DAFA for ; Sat, 22 Sep 2018 00:10:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A9CB12DB21; Sat, 22 Sep 2018 00:10:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from upbd19pa10.eemsg.mail.mil (upbd19pa10.eemsg.mail.mil [214.24.27.85]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA256 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D0CA82DAFA for ; Sat, 22 Sep 2018 00:10:39 +0000 (UTC) X-EEMSG-check-008: 170089126|UPBD19PA10_EEMSG_MP10.csd.disa.mil Received: from emsm-gh1-uea10.ncsc.mil ([214.29.60.2]) by upbd19pa10.eemsg.mail.mil with ESMTP/TLS/DHE-RSA-AES256-SHA256; 22 Sep 2018 00:10:35 +0000 X-IronPort-AV: E=Sophos;i="5.54,287,1534809600"; d="scan'208";a="16120153" IronPort-PHdr: 9a23:EELfzx/NXSafef9uRHKM819IXTAuvvDOBiVQ1KB60OgUIJqq85mqBkHD//Il1AaPAd2Eraocw8Pt8InYEVQa5piAtH1QOLdtbDQizfssogo7HcSeAlf6JvO5JwYzHcBFSUM3tyrjaRsdF8nxfUDdrWOv5jAOBBr/KRB1JuPoEYLOksi7ze+/94HRbglSmDaxfa55IQmrownWqsQYm5ZpJLwryhvOrHtIeuBWyn1tKFmOgRvy5dq+8YB6/ShItP0v68BPUaPhf6QlVrNYFygpM3o05MLwqxbOSxaE62YGXWUXlhpIBBXF7A3/U5zsvCb2qvZx1S+HNsL4V7A0XSmp4bltRhHmlSwLMyc1/HzLhsB1iq9Upw6sqhJjz4LJeY2ZKOdydb7Zcd8HRWdNW8BcXDFDDIyhdYsCF/QPM+hboYf6qFQAsAO+CAuxCO7hyjFInGP506Ik3OQ6CgzGwA4tEsgSvHnOsNn5KqEfWv21wqnSyjXDautb1y/86IfUcRAqvPSCXahqfsrV10YvCQLFgUmQqYf4ITOV1/4CuHWG4eV+UeKvimgnqxx+ozOywcoskZfGhoYUylDC6CV4z504JcG4SUFnYd6kF4FctyeBN4RsWM8iTGZouDgjx7AApJW1fzAKxYw6yxPQZPGLaYiF7g/5WOqPLjp0mmhpdK+nixqs8EWs1PHwW8yp3FtKsiVIl8fAumwQ2xHW9MSKT+Fy80Wh1DmT0g3e5f9LLlwomafeMZEu2Lw9mYYWvEnNACP5g0P7h7KMeEo+4Oin8eHnb63jpp+bKoB7lBnzMr8rmsyjGeQ4NRUOX3SD9eS8yrLj+Ur5Ta1WjvIsiKnZsY3aJd8Bqq6lAw5azoYj6xGlAzegzNsYhmUIIEhAeBKGi4jlI1DOIPbmAvejm1mgjThmyv/cMrDhH5nBNGbPnbj/cbpn9kJQ0A8zwspe55JQBLEBOvXzWkrpudzDEBA5Nw20w+D6CNRyz48RQmWPArKfMKzOr1CI/fkiI/WMZYAJuDb9LOIp5/j1jXAjg1Mdcq6p3YUPZHCiAvtmO1mZYWbrgtoZE2cKuQw+Q/b2iF2CSzFTYW2/X6A75jE9DYKpF5zDRpyzj7ybxye3BJpWZnpJClqUC3fna52EW+sQaCKVOsJhkD4EWqK9RI8izhGuswn6y7t5LufP9C0YsY/j1ddu6O3OkxEy6SF0A96a02GXQGF+hnkISCMu3KBjvUx9zU+O0bBmjPNDC9NT4fJJUhs9NZPHzux1Fc79VRzbcteOUlamTc2sASstQdIp398Of0F9Fs2/gRDE2SqqBaIamKKPBJw16a/TxWb+J9x6y3rc06khlVYmSNNVNWK6nq5/6xTTB4nRnkqHj6alb74c3C/W9GqY1WqBpltYUA9rUaXdWXAQfFfZosrj6kPFVb+uBqwtMhFdxs6aNqtKdtrpgE1IRffiPNTeZny+m32rCBaG2LyDcY3qe38H0yXFEkgElAIT8miaOggiHCuhpHjeDDN2H1L1f0zs6fV+qG+8TkIszAGFdU5h172o+hMOhvyTUfAT3rUZuCs7rDV0Blm91crMC9WcvwphYLlcYdQl7VhdyG3ZrQ19MYK6L615nFERbwF3s1np1xVtBYVKidIqo28yzApuNaKY10tMeC+C0pD0JLLXMXXy/RCoa6PNwVHRzNeW9bkJ6PQkqlXsphulFkw8/HV7y9NVyWeT5o3WDAoOVpL8Slw3+AVnqLzBbSk94ozV2WdqMaaqrj/Iw8gpC/c9yha8Y9dfN7uJFBT8E80AAMiuM/AqlkOybhICO+BT+qs0MNmgd/ec3q6kIvpgliq8jWtb+IB9zl6M9y1kR+/GxZkFx+2Y0RWdVzfnl1qhrN74mZpfajEPG2qz0y/kBJReZqdqZ4YEFX+uI9GrxtV5n5PtXX9Y9FqnB1wYw8+kYgCdYELn3Q1Xz0gXpmanmSSgxTxujz4ptraf3DDJw+n6aRUHJnRERHN5gFjwJoi0iswVU1Kzbwg1jhel41j1x7RDrqRlM2bTWVtIfzTxL2x6TKuwt6aNY9JI6JMyqylYTOS8YVecSr7yuBYa1yLjH21EyzAhcDGmoJL5nwZ1iGiFNnZ8sGLZed1sxRfY/NHcQf9R3iEaRCVhkjnYGFy8P9iv/dWJmJbOqfu+V3qgVp1VcCnk0ZiAuDG95WJ0HR21h+qzlcH/EQgmzS/70MFnVT/PrBb4Zonkyb66Pv5gfkhmH1L88Nd6FZ1lkocqg5EQw3cajI2P/XUbiWfzLclb2aXmYXoOWzELxcXV7RPm2EJ9KHKJ3IT5WWuBwsd7YNm6eGwW0Don789WEKeU8KBEnSxtr1qgtw3RfPx9kSkFyfQ07n4an/8GuBA2wyWAGbAdA1NYPTf2mxST6NC+sb9Xa3qxfri+00p+h9+hA6+YrgFaRnn5Zo8oHTVs4cVnLFLMzHrz55n6eNnWcN0erQOUkxHdgOhVMp4xkOQFhTZ/M2LnoXIl0/I7jQBp3ZyipIiIMXht/KaiDxFENz31e8MS9ijjjalEmMaaxYevHo9uGj8TRpvnUeqoEC4OtfTgLwuOEz09qnOFFrfEGA+f70lmr3zRHJC3K3GXJH4ZzdB8SxWHIkxQnhwUVi0gnpElDgCq2NDhcEBh6zAf/FH4rAdMyuVtNxTkXGfQuhqnajAuSJeFNBpW9AZC50XLPsOC8uJ/BSZY/oeurAaVMGyUexxIDX0VWkyDH13jMKOu6sfd/OiDHOW+KefOYbKVqeFFTfiH2Zev3pFh/zaWOcWFJmNiAOEj2kpfQXB5HNzUlC4URCAQkyLNbtWbpAun+iFttcCw7ujkVBj05YSRD7tSMNNv+w25gKqYK+GRhDx5KStD1p8Wy37H0qQf3EUViyFobTWtFq4AtSHVRqLKhqBXFwIbaz90NMZQ9K083wZNOcndit7uy7F3kOU6C1ZfWlzngM2pYtYKI26lPlPdGEmLLKiGJSHMw8zvY6O8Sb1RjP1Ttx20uDabD1HsMy+GlznoSxCvK/9DgDucPBxEt4G3agxtBnT7TNL6dh27N8d6jTsozrIugnPHLm0cMT9nc0NRtLKQ6zhYgvZ+G2Bb6HpqM/WEkT6D7+bEMpYWredrAiNsmuJA/ns60KVa4zteRPNpmCvftcVho1C8kuaSzTpnXgJOqixVi4OLp0liP7vW9oVYU3be4B0N9XmQCwgNp9Z9F9Lgob5QytnSm6LoMzpN6cjU/dEbB8naM8KILmYuMQfzGD7VEAsETSSnNWfBiExBiPuS7GGaroAmqpjwn5oDUrtbVFsvFvwEDERkHdsCLYx4XjMijL6XlskI5WCxrBPJXsVVoojHVu6OAfXoMDuZlqdLZx8JwbP+MIQSOZb21FBlall/gIvFAVHQXcxXri1ncAA0vF1H8GJiQW0rx0LldgSt7WcOGvGomx42jQ1+Yfgw+Dr3/Vc4OEDKpCoxkUk2n9XpmzaRfyDtLK2oR4FZFzL0t1QtMpP8Wwt1cQyynUljNDfYR7JQj6Bten1qiA7co5RAAuRQTatabx8M3fuXfekn0UxAqiW7wk9K/fHKCZ9jlAQ2b5Gjt3dA2gJlbN4yI6zfPrFEwUNRhq2UuC+kz+4xwBIEK0YL7mySZDYCuFYUObk+Oyqo4uts5BSZlDRdfmgBTOAlre909kwjIeSA1Djv06RDK0yrMOyfNayZsXDalcGUWlMwyl8Il05d8Lhs18cjclabV0AozLuVDBQHLdPMJxxPYcdO83beZjqBseLIwZ1pJYq9DfzoQfWItKkKnkKuBBwpEJgU7sQdApms11nVItvlLLEf1Rog/xjkJFKBDPRNeRKEji0Ho92hw5Br3YlRPDYdAX9yMS+v/LbYuhcqgOafXNcxenoaRJELNmgxWMKhgCNZo25AAyOp0u0HzAiC7jn8pivUDDn9YNpjZOuUZR12B9Gs/DUz6a62hkDL8p/GPWH1KcxiusPT6eMdv5uGBelYQqV9s0fdnolYRmalU23UHN60OZf/dZcjYcbzCnagXVy1kyg1QNvpPNaxMqiIhhnlRYNOv4mB3zAsK9O9FjAYGxd/vOwC6rhzZQsfbJo/Zh7oqhkxN7elLAeezNquX36nKSFKQPlH0eW6e7tXwjI0bu+9zHsvVIs6zuew8U4JSpEHlRTexfGkZ4lFTyf8BmZdewLUpSoilmhhMOkyzv04wBPSvlkWKyqLe/BxaGxYo9E8AkufLm9sCmolQV+Ql4nD7xWt37AT/itdg81b3fdDsHfgop/VeCisV7CzqZXJryogasAro7F2MYzmOcaGqI/SnjnEQ5XKtA2KTjK6HeJAmtdMOCJYXOVImWY9NMwEvopO91E8WdogKLxUFqYsvKyqZiR5AiIIyy8WSZ+A1iQYguigw7vaiguQcJM6PRwKqpVNmN0dXDJ3YiMFv6KjUp3Wl26dRmgQLgYT9h5A5AUalo9/Zurl+pbHTIdQyz5KpPJ5SjfLGYR1+Fv6UG6WhUP1R+mmk+yswQ1d1uns0sUBVB55F0dd2/5cllE0J7FvN6kQoonKvyeQdUPhoGLi0vapJEVKxM3PcF34EZDFunbiXS0a5X0UX5VAyHXFGZQViQp5Z74hpE9QL4C+Zkb++zskypxyELm2Sc+n21QooWsISiqxD9VBDORmv07NVz1+f5CnspPlNItOQmVI4p2St09ZkFlxMy6+0ZdcMd9C7SMMXDdVvTWQp9+ySMpd2cBoEZMDPtB/tGrjF69ePpievWE2sKT1ynDF4zA8rEu6xDKrFq+kVeJW4XMRFRgyKmSDrkkvE/Es/X3M8lDMtVB0+/lUBqSVgUV2ujZ9EYhEBixV2nC9M1RzUH5Gvv1fKKvPd8xcR+c9ZQOzOxMkD/ErxEqJ8l9onXfifyN9rBNa9D7HUwkySyYVnq/nmScCpcG/JT8aV5VIYC0jbyjfMQKbnjtXvBJFZEF0QJ0ZB8tF+7UH3YtV4sXCSFyjKSceXBB4MQI4y/Vfn1ZZsEqEYSDdERaodfHXvx11Z8iRqsCpLO7+/AhalIzqq/w4+L8FR329ng2hW9beoJHgtteSrEuBaL/4M/GgYX/GVDXMgg2whbYgD5nO4SfTNRFWJIRkxnU/YJjuE2jLMQ5BJ6IBKEpRTbp6ZsleouBGe89kf74E+a1sBhKCXR7vHZKgrflYIVbJRDTeKSqB/va5oY3N8bzXUfLgadCUx3bbX6J3OY936T//G7rx0I9e/E/21u1s9kN8R1jGKTqOrM/9JgMR+cmtalfivoAzHTzIGptwl2Dtxk5YfcoNXyKq6IgYyI9e6HvoTOJ41U7zsPFd97Z68oQ35rFpxt2yJajMNfRbv0hnAgKXBgVx7JktBnZwR3xJaO8LNPjRZbgZjdzpq+3vE6wX8xiV9uxCZNvJOU7Oh86/CiuGRhxchgcBrjwaIRWA2P6ZgaN0Ttylpefh0EI3/1e+NgIGzKxq5Yqc+6qJpfXYYAHNwrUfQajlWN/zoaowtE+I4v0kjrEOcHRvYwK7COgdStIdxmD4wK8xzCIsCM3CEKji+P5CS3I5hijvm415H1gNBvwUGqeE8ppEkWclgezZMccWfbpYlmaIDx6kHacIyWS35CuPPGllnhbO3gnoQWyp8F/5sS94QCXLz9f5kUpZT6K3CllWXyqoP094rTyOMRHwtNXtpaQ68EE2M2LjtNKXl2utIrBXENPlJNyaPyY0oEgbjJorRtygwYobA8ayIM8N8HFiafvT82yrnDFHo6dbgIre5caZ+u7JEnmkjq2araiNxT9Dx3g8o14/8NChOevU692MXfuoy34bTz1jtAvZQx61trvbokgSOUyKzEjLn4gKMctC3XUi10Hm4+8jQMko9AhFE4bNaPwDqSr0ODvuzlaVe8g3WTWG0ztLAlL1FkF1GKcg12Lrp8LFjGre9VIuSIlxcUznmBN2Ap43KUIo8lcXxDQMHRIKaRCBA7GiHV7lIpccVUgfdRSH26C3eqUw3U1zxLOj/vPcbex4B6oQK/lcjw+OnF5AGpIVsK0TW6x8e15D9KHNogjtFonnU+LglXUuKf2/Wtpa/twBt3s+/ga/QAKt6ZZd77kBjpCFbapEYYXRs8B96Edn/iQDditXgBhwlxm5S/wTpPj/4tjHt5ql8uSuW7gjR+UZ8xg5HGp/gIH2gF89vdHbzeFcRZPJiY7n6gBCP2aKuJrG0xl7MecOJIarfLFu9noZIygeI2kDPcGRa/k64i9iLC/f51pcDcMQfdkYJtbCmRhIik31X7Fe7s/bGl6bC4dwcMAl9Gj3xyo28Zs7VObv9jm2KYrZ715TI/NJlD9sm87apOgJ3frSDzAa7mKHZBhz3iOP0IKNC/L3/eWQ1NHUSU0JETMsX4daPjqC9hStRvCpm5XxTgOU9sjzjYowdE2OQnyxnbwFvbhXHO9BiyX72z1eGZ7vh/KRrdWg8mxXtkdIEIxr9x3KBL1fPolnORT/jsSqSFB8BjH+eM7IaBUjo++WxuYQ4+VkKUTyf4gbIggLy7ji83paUhNuSKLqvlaeRe8RY99mR+3fo3BN7YJvMbQPPEScpJP2sjdIsk45DxEzZL82sDNaalHEnBdJVKbspL4AlgwcXMZ9uU9NH2KwJW0/6yPDVaRUl6mRFOcV/y6STqMUVUVoNTlyQxSv2JVhY7Gph+xIsntaniNhp/gnyzlmSwGgti3spqIN3zUg9aqmtDUAv3xKUOGekybOCVVew/UGl6AcC2zt6VakenkMcJPy4KV7JcTn7YQh4W4wYRYkfyIdRumgFifwj7+IAoyIrdJcix6NuNnUYb+1MycSKqw3yQj/SHhlzgjegBFo/XMJQjWl698kPp+9Occ+xiezH2jUblMM7b1IsMfrsl4LVuQ2Y0t7wGp/ysiHWjENRMvXFmYugAgkbHlLfZNA5BIBCaknnCyIvqhH/wETZjfYCIKl9ZfMnZSA5X5oVtpux2TLtoWZl5gq1ztjgNoy4SmQ604fb+jJb8g5JHn41c980+X6auusueBPHI1gy5yuV/gNNsTl8myzjsZEQEigk5IfFFnxE/UKwrrFUiylAXOZUKywfmyNmSspehrp6B2pKEAnQNtbpE86dO3Zj9hTkBO3AuA8fTmZuVKOlD9rCugdbQ9j5Yo= X-IPAS-Result: A2C8AAAvh6Vb/wHyM5BbGwEBAQEDAQEBBwMBAQGBU4E4KiqBCFwVE4xni0uYXBQMgQQDShQYEwGICCE2FgEDAQEBAQEBAgFsKII1DIJ/AjcUIA4DCQISLggIAwEtAwEFAQsfCwUYBIJBPykBgVgBApdnPIw5hGiFKRKGSIQWDgk/gUGBEoddARIBbIULAog+hX4xRo1HCZAeCxeIZ4ZAAZRaAgQCBAUCBQ8hgSgELTQwcSsKGCkPO4EzGoEfkHRPewEBixqCPQEB Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by EMSM-GH1-UEA10.NCSC.MIL with ESMTP; 22 Sep 2018 00:10:33 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus.infosec.tycho.ncsc.mil [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id w8M09eW6009760; Fri, 21 Sep 2018 20:09:52 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id w8M09c3A018209 for ; Fri, 21 Sep 2018 20:09:38 -0400 Received: from goalie.tycho.ncsc.mil (goalie.infosec.tycho.ncsc.mil [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id w8M09cNd009758 for ; Fri, 21 Sep 2018 20:09:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1B1AACwh6VblywbGNZbgz0qJ4FnKJgyUgaKHo1mgSQDUwuEbINIITQYAQMBAQEBAQECFAEBAQEBBhgGTIYLAQE3AYEUAQUBNYMhKQGBSw0BApdoPIocgh2CdQEBBYF7hRIIEoZIgnuBGxd5gQeBEoYtAoF2OIULiECGL0aNRwmFC4sTCxeIZ4ZBlFoCBAIEBQIFDyGBIWyBIU0jFYMngjODT4pyT45UAQE X-IPAS-Result: A1B1AACwh6VblywbGNZbgz0qJ4FnKJgyUgaKHo1mgSQDUwuEbINIITQYAQMBAQEBAQECFAEBAQEBBhgGTIYLAQE3AYEUAQUBNYMhKQGBSw0BApdoPIocgh2CdQEBBYF7hRIIEoZIgnuBGxd5gQeBEoYtAoF2OIULiECGL0aNRwmFC4sTCxeIZ4ZBlFoCBAIEBQIFDyGBIWyBIU0jFYMngjODT4pyT45UAQE X-IronPort-AV: E=Sophos;i="5.54,287,1534824000"; d="scan'208";a="375800" Received: from emsm-gh1-uea10.ncsc.mil ([214.29.60.34]) by goalie.tycho.ncsc.mil with ESMTP; 21 Sep 2018 20:09:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0B1AAAvh6VblywbGNZbgz0qJ4FnKJgyUgaKHo1mgSQDUwuEbINIITQYAQMBAQEBAQECARMBAQEBAQYYBkwMgjUigygBATcBgRQBBQE1gyEpAYFLDQECl2c8ihyCHYJ1AQEFgXuFEggShkiCe4EbF3mBB4EShi0CgXY4hQuIQIYvRo1HCYULixMLF4hnhkGUWgIEAgQFAgUPIYEhbIEhTSMVgyeCM4NPinJPjlQBAQ X-IPAS-Result: A0B1AAAvh6VblywbGNZbgz0qJ4FnKJgyUgaKHo1mgSQDUwuEbINIITQYAQMBAQEBAQECARMBAQEBAQYYBkwMgjUigygBATcBgRQBBQE1gyEpAYFLDQECl2c8ihyCHYJ1AQEFgXuFEggShkiCe4EbF3mBB4EShi0CgXY4hQuIQIYvRo1HCYULixMLF4hnhkGUWgIEAgQFAgUPIYEhbIEhTSMVgyeCM4NPinJPjlQBAQ X-IronPort-AV: E=Sophos;i="5.54,287,1534809600"; d="scan'208";a="16120145" X-IronPort-Outbreak-Status: No, level 0, Unknown - Unknown Received: from updc3cpa05.eemsg.mail.mil ([214.24.27.44]) by EMSM-GH1-UEA10.NCSC.MIL with ESMTP; 22 Sep 2018 00:09:36 +0000 X-EEMSG-check-005: 0 X-EEMSG-check-006: 000-001;adf61524-ce31-48e1-9eb4-b581d770fe50 X-EEMSG-check-008: 337792261|UPBD19PA06_EEMSG_MP6.csd.disa.mil X-EEMSG-SBRS: 1.6 X-EEMSG-ORIG-IP: 209.85.215.194 X-EEMSG-check-002: true X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DcAAAHiKVbdMLXVdFbHgEGBwaBUYE6KoI2mDJOAQEBAQaKHo1mgSQDUwsThFmDSBkHAQQwGAEDAQEBAQEBAQEBEwEKCwwHGwwlDII1IoMaAQ0BATcBgRQBBQE1gyEpAYFLDQGXajyKHIIdgnUBAQWBe4USCAkBCIZIgnuBGxd5gQeBEoYtAoIuhQuIQIYvRo1HCYULixMLF4hnhkABlFoCBAIEBQIFDyGBIWyBIU0jFYMnghmDaYpyT45UAQE X-IPAS-Result: A0DcAAAHiKVbdMLXVdFbHgEGBwaBUYE6KoI2mDJOAQEBAQaKHo1mgSQDUwsThFmDSBkHAQQwGAEDAQEBAQEBAQEBEwEKCwwHGwwlDII1IoMaAQ0BATcBgRQBBQE1gyEpAYFLDQGXajyKHIIdgnUBAQWBe4USCAkBCIZIgnuBGxd5gQeBEoYtAoIuhQuIQIYvRo1HCYULixMLF4hnhkABlFoCBAIEBQIFDyGBIWyBIU0jFYMnghmDaYpyT45UAQE Received: from mail-pg1-f194.google.com ([209.85.215.194]) by upbd19pa06.eemsg.mail.mil with ESMTP/TLS/AES128-SHA; 22 Sep 2018 00:09:15 +0000 Received: by mail-pg1-f194.google.com with SMTP id r1-v6so6721324pgp.11 for ; Fri, 21 Sep 2018 17:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=EeftLdPPePFR+0DUmIBZsOtLnxDc2neTlzKWvckulhE=; b=gwpnnscqOXLyCjLjwHefo5BGnkx4Fi6QFGuJ3P7sKXu14n9jpXwrMZh8wbrhv3ZgV4 rG3MUq5R9lwaLfDexhVZEIXmj3Agqzp8cjhuecQgaso9c315ZjVRhOfp3DB1AG/BVytg oGuyeL8aN/dTO9MoOtTc5tkEpLCETpyUWyMFOvGn9HNkhCJdtsD9yDShcVqpTWN3/Qd8 scf5oRDmpOXpWdlJ8RtuOm4YdquAK8bFiyCiqIHgogM8T33OlB2eIuz0BjOBufOhANKy +pLq/fAYo3RiFyKmOHRDxM4G/bBjEwdOIZraAkpbjuBAV1iKL5phsWOhTO1EVydVns+8 E9tA== X-Gm-Message-State: ABuFfohtpFxyv+latZ8UWX34H5sVHauTIBz2t/Rs87uAddm+C9VnD8nv 5nn7vYpJdHCDBwf3B8LLIK7MrOkAq1pCZQ== X-Google-Smtp-Source: ACcGV63gnasEAv3V0GA/IA99McEIPLicVvFryFL6ae8VzEm7QBNbiHIDt6SPGo2BDy1UR3VAjlW/pw== X-Received: by 2002:a65:50c9:: with SMTP id s9-v6mr63784pgp.417.1537574952562; Fri, 21 Sep 2018 17:09:12 -0700 (PDT) Received: from nick.mtv.corp.google.com ([2620:15c:201:2:a75c:4ec0:aa7c:32b]) by smtp.gmail.com with ESMTPSA id t123-v6sm35180048pfd.51.2018.09.21.17.09.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 17:09:11 -0700 (PDT) X-EEMSG-check-009: 444-444 To: selinux@tycho.nsa.gov Date: Fri, 21 Sep 2018 17:08:59 -0700 Message-Id: <20180922000859.121485-1-nnk@google.com> X-Mailer: git-send-email 2.19.0.444.g18242da7ef-goog MIME-Version: 1.0 Subject: [PATCH] secilc: better error handling X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: From: Nick Kralevich via Selinux Reply-To: Nick Kralevich Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP Fix a situation where the secilc command line tool could return success even though the compilation failed. $ secilc /dev/null -o /dev/null -f /dev/null Failure reading file: /dev/null $ echo $? 0 Fix a few other minor oversights while I'm here. Signed-off-by: Nick Kralevich Signed-off-by: Nick Kralevich <nnk@google.com>
--- libsepol/include/sepol/errcodes.h | 2 +- secilc/secilc.c | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libsepol/include/sepol/errcodes.h b/libsepol/include/sepol/errcodes.h index 0136564a..6e9ff316 100644 --- a/libsepol/include/sepol/errcodes.h +++ b/libsepol/include/sepol/errcodes.h @@ -12,7 +12,7 @@ extern "C" { #define SEPOL_OK 0 /* These first error codes are defined for compatibility with - * previous version of libsepol. In the future, custome error + * previous version of libsepol. In the future, custom error * codes that don't map to system error codes should be defined * outside of the range of system error codes. */ diff --git a/secilc/secilc.c b/secilc/secilc.c index 0be6975b..8578cc26 100644 --- a/secilc/secilc.c +++ b/secilc/secilc.c @@ -257,14 +257,16 @@ int main(int argc, char *argv[]) rc = stat(argv[i], &filedata); if (rc == -1) { fprintf(stderr, "Could not stat file: %s\n", argv[i]); + rc = SEPOL_ERR; goto exit; } - file_size = filedata.st_size; + file_size = filedata.st_size; buffer = malloc(file_size); rc = fread(buffer, file_size, 1, file); if (rc != 1) { fprintf(stderr, "Failure reading file: %s\n", argv[i]); + rc = SEPOL_ERR; goto exit; } fclose(file); @@ -345,11 +347,13 @@ int main(int argc, char *argv[]) if (file_contexts == NULL) { fprintf(stderr, "Failed to open file_contexts file\n"); + rc = SEPOL_ERR; goto exit; } - + if (fwrite(fc_buf, sizeof(char), fc_size, file_contexts) != fc_size) { fprintf(stderr, "Failed to write file_contexts file\n"); + rc = SEPOL_ERR; goto exit; }