| Message ID | 20200123125716.12662-5-omosnace@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix build with -fno-common | expand |
On 1/23/20 7:57 AM, Ondrej Mosnacek wrote: > GCC 10 has it enabled by default and everything now builds OK with it, > so add it to CFLAGS to avoid breaking the build in the future. > > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> For all four patches, Acked-by: James Carter <jwcart2@tycho.nsa.gov> > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c238dbc8..298cd2b7 100644 > --- a/Makefile > +++ b/Makefile > @@ -16,7 +16,8 @@ else > -Wstrict-prototypes \ > -Wundef \ > -Wunused \ > - -Wwrite-strings > + -Wwrite-strings \ > + -fno-common > endif > > ifneq ($(DESTDIR),) >
Ondrej Mosnacek <omosnace@redhat.com> writes: > GCC 10 has it enabled by default and everything now builds OK with it, > so add it to CFLAGS to avoid breaking the build in the future. > > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index c238dbc8..298cd2b7 100644 > --- a/Makefile > +++ b/Makefile > @@ -16,7 +16,8 @@ else > -Wstrict-prototypes \ > -Wundef \ > -Wunused \ > - -Wwrite-strings > + -Wwrite-strings \ > + -fno-common > endif > > ifneq ($(DESTDIR),) This change applies only when you run a build from root directory. Would it make sense to propagate it also to libsepol/src/Makefile and checkpolicy/Makefile so it's used when users builds components from released tar balls?
diff --git a/Makefile b/Makefile index c238dbc8..298cd2b7 100644 --- a/Makefile +++ b/Makefile @@ -16,7 +16,8 @@ else -Wstrict-prototypes \ -Wundef \ -Wunused \ - -Wwrite-strings + -Wwrite-strings \ + -fno-common endif ifneq ($(DESTDIR),)
GCC 10 has it enabled by default and everything now builds OK with it, so add it to CFLAGS to avoid breaking the build in the future. Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)