[RFC,V3,1/2] selinux-testsuite: Use native filesystem for tests - Part 1

Message ID	20200310162456.32240-2-richard_c_haines@btinternet.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <SRS0=d7nf=43=vger.kernel.org=selinux-owner@kernel.org> From: Richard Haines <richard_c_haines@btinternet.com> To: selinux@vger.kernel.org, sds@tycho.nsa.gov Cc: smayhew@redhat.com, Richard Haines <richard_c_haines@btinternet.com> Subject: [RFC V3 PATCH 1/2] selinux-testsuite: Use native filesystem for tests - Part 1 Date: Tue, 10 Mar 2020 16:24:55 +0000 Message-Id: <20200310162456.32240-2-richard_c_haines@btinternet.com> In-Reply-To: <20200310162456.32240-1-richard_c_haines@btinternet.com> References: <20200310162456.32240-1-richard_c_haines@btinternet.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: selinux-owner@vger.kernel.org Precedence: bulk
Series	selinux-testsuite: Use native filesystem for tests \| expand [RFC,V3,0/2] selinux-testsuite: Use native filesystem for tests [RFC,V3,1/2] selinux-testsuite: Use native filesystem for tests - Part 1 [RFC,V3,2/2] selinux-testsuite: Use native filesystem for tests - Part 2

diff --git a/README.md b/README.md index 27c9d56..6dfdf44 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,9 @@ following command: libbpf-devel \ keyutils-libs-devel \ kernel-devel \ - quota + quota \ + xfsprogs-devel \ + libuuid-devel The testsuite requires a pre-existing base policy configuration of SELinux, using either the old example policy or the reference policy as the baseline. @@ -164,6 +166,12 @@ security_label export option and will test default NFS file labeling in the absence of any options. When finished, it will unmount and unexport the mount and then stop the nfs-server. +There is also an option to allow individual tests to be run on NFS as +shown by the following example (ensure a valid policy is loaded): + + # cd selinux-testsuite + # ./tools/nfs.sh nfs_filesystem -v + ## Running the Tests Create a shell with the `unconfined_r` or `sysadm_r` role and the Linux diff --git a/defconfig b/defconfig index 8419e40..00bf9f3 100644 --- a/defconfig +++ b/defconfig @@ -104,3 +104,9 @@ CONFIG_NFS_V4_SECURITY_LABEL=y CONFIG_NFSD=m CONFIG_NFSD_V4=y CONFIG_NFSD_V4_SECURITY_LABEL=y + +# Test XFS and VFAT filesystems. +# This is not required for SELinux operation itself. +CONFIG_XFS_FS=m +CONFIG_XFS_QUOTA=y +CONFIG_VFAT_FS=m diff --git a/policy/test_filesystem.te b/policy/test_filesystem.te index 09f9d4a..1d9d3db 100644 --- a/policy/test_filesystem.te +++ b/policy/test_filesystem.te @@ -6,6 +6,9 @@ attribute filesystemdomain; kernel_setsched(filesystemdomain) +# For module filesystems +kernel_request_load_module(filesystemdomain) + #################### Create test file contexts ###################### type test_filesystem_filecon_t; files_type(test_filesystem_filecon_t) @@ -26,10 +29,10 @@ typeattribute test_filesystem_t filesystemdomain; allow test_filesystem_t self:capability { sys_admin }; allow test_filesystem_t self:filesystem { mount remount quotamod relabelfrom relabelto unmount quotaget }; -allow test_filesystem_t test_file_t:dir { add_name mounton write remove_name rmdir }; +allow test_filesystem_t test_file_t:dir { add_name mounton read write remove_name rmdir relabelfrom }; # Create test file -allow test_filesystem_t test_filesystem_file_t:dir { read add_name write search }; -allow test_filesystem_t test_filesystem_file_t:file { open getattr create write relabelfrom relabelto }; +allow test_filesystem_t test_filesystem_file_t:dir { read add_name write search mounton }; +allow test_filesystem_t test_filesystem_file_t:file { open getattr create read write relabelfrom relabelto }; fs_mount_all_fs(test_filesystem_t) fs_remount_all_fs(test_filesystem_t) @@ -58,6 +61,10 @@ type_transition test_filesystem_t test_filesystem_file_t:file test_filesystem_fi allow test_filesystem_t test_filesystem_filetranscon_t:file { create getattr open write relabelfrom }; dontaudit unconfined_t test_filesystem_filetranscon_t:file { getattr read }; +# For NFS +type_transition test_filesystem_t test_file_t:file test_filesystem_filetranscon_t; +allow test_filesystem_filetranscon_t test_filesystem_file_t:filesystem { associate }; + #################### Deny filesystem { relabelfrom } ###################### # hooks.c may_context_mount_sb_relabel() FILESYSTEM__RELABELFROM type test_filesystem_sb_relabel_no_relabelfrom_t; @@ -182,9 +189,12 @@ typeattribute test_file_no_quotaon_t testdomain; typeattribute test_file_no_quotaon_t filesystemdomain; allow test_file_no_quotaon_t self:capability { sys_admin }; -allow test_file_no_quotaon_t self:filesystem { quotamod relabelto mount unmount relabelfrom }; +allow test_file_no_quotaon_t self:filesystem { quotamod quotaget relabelto mount unmount relabelfrom }; allow test_file_no_quotaon_t test_file_t:dir { mounton write remove_name rmdir }; # neverallow test_file_no_quotaon_t self:file { quotaon }; + +# For XFS: +# neverallow allow test_file_no_quotaon_t self:dir { quotaon }; fs_mount_all_fs(test_file_no_quotaon_t) fs_relabelfrom_all_fs(test_file_no_quotaon_t) fs_associate(test_file_no_quotaon_t) @@ -249,8 +259,8 @@ fs_mount_all_fs(test_move_mount_no_mounton_t) fs_unmount_all_fs(test_move_mount_no_mounton_t) fs_relabelfrom_all_fs(test_move_mount_no_mounton_t) fs_associate(test_move_mount_no_mounton_t) -allow test_move_mount_no_mounton_t test_file_t:dir { mounton write remove_name rmdir }; -# neverallow test_move_mount_no_mounton_t self:dir { mounton }; +allow test_move_mount_no_mounton_t test_file_t:dir { write remove_name rmdir }; +# neverallow test_move_mount_no_mounton_t test_file_t:dir { mounton }; #################### Deny filesystem { unmount } ###################### # hooks.c selinux_umount() FILESYSTEM__UNMOUNT @@ -312,7 +322,7 @@ allow test_setfscreatecon_t test_setfscreatecon_newcon_t:dir { create getattr rm # Permit creation of the new file in a NFS filesystem. # This is required when running the testsuite on a labeled NFS mount. -allow test_setfscreatecon_newcon_t nfs_t:filesystem associate; +allow test_setfscreatecon_newcon_t nfs_t:filesystem { associate }; ################# deny process { setfscreate } ############# type test_no_setfscreatecon_t; @@ -342,7 +352,7 @@ allow test_filesystem_fscontext_t test_filesystem_fscontext_fs_t:file { create g allow test_filesystem_fscontext_t test_filesystem_fscontext_fs_t:filesystem { mount relabelto unmount }; fs_relabelfrom_all_fs(test_filesystem_fscontext_t) files_search_all(test_filesystem_fscontext_t) -allow test_filesystem_filecon_t test_filesystem_fscontext_fs_t:filesystem associate; +allow test_filesystem_filecon_t test_filesystem_fscontext_fs_t:filesystem { associate }; ########### Test context= ################# type test_filesystem_context_t; @@ -373,6 +383,73 @@ allow test_filesystem_fscontext_t test_filesystem_context_file_t:file { create g allow test_filesystem_context_t test_file_t:dir { relabelfrom }; allow test_filesystem_context_t unlabeled_t:dir { mounton relabelto }; +# +####################### Rules for nfs_filesystem/test ################### +# +files_mounton_default(filesystemdomain) +userdom_manage_user_home_content_dirs(test_filesystem_may_create_no_associate_t) +userdom_manage_user_home_content_dirs(test_filesystem_inode_setxattr_no_associate_t) + +allow test_filesystem_t etc_t:filesystem { relabelto relabelfrom mount unmount }; +allow test_filesystem_sb_relabel_no_relabelfrom_t self:filesystem { mount relabelto }; +allow test_filesystem_sb_relabel_no_relabelfrom_t self:filesystem { mount }; + +allow test_filesystem_may_create_no_associate_t nfs_t:filesystem { associate }; +allow test_filesystem_may_create_no_associate_t unconfined_t:file { getattr relabelto }; +allow unconfined_t test_filesystem_may_create_no_associate_t:filesystem { getattr mount relabelto unmount }; +allow test_filesystem_may_create_no_associate_t test_file_t:dir { add_name }; +allow test_filesystem_may_create_no_associate_t test_file_t:file { create write relabelfrom }; +allow test_filesystem_may_create_no_associate_t test_filesystem_file_t:filesystem { mount unmount relabelto }; +allow test_file_t test_filesystem_may_create_no_associate_t:filesystem { associate }; +# neverallow unconfined_t test_filesystem_may_create_no_associate_t:filesystem associate; + +allow unconfined_t test_filesystem_inode_setxattr_no_associate_t:filesystem { getattr mount relabelfrom relabelto unmount }; +allow test_filesystem_inode_setxattr_no_associate_t unconfined_t:file { getattr open read write }; +allow test_filesystem_inode_setxattr_no_associate_t nfs_t:filesystem { associate }; +allow test_filesystem_inode_setxattr_no_associate_t test_file_t:dir { add_name }; +allow test_filesystem_inode_setxattr_no_associate_t test_file_t:file { create relabelfrom write }; +allow test_file_t test_filesystem_inode_setxattr_no_associate_t:filesystem { associate }; +# neverallow unconfined_t test_filesystem_inode_setxattr_no_associate_t:filesystem { associate }; + +# +############### Rules for NFS mount ################## +# +userdom_search_user_home_content(filesystemdomain) +fs_search_nfs(filesystemdomain) +# mount same twice test +#userdom_mounton_user_runtime_dirs(test_filesystem_t) # Not in Fedora policy +allow test_filesystem_t user_home_t:dir mounton; +# test fsconfig(2) fix +allow test_filesystem_t unlabeled_t:dir relabelto; + +allow test_filesystem_t test_filesystem_file_t:filesystem { getattr mount remount unmount relabelto relabelfrom }; +allow test_filesystem_t test_file_t:file { create write relabelfrom }; +allow test_file_t test_filesystem_file_t:filesystem { associate }; +allow test_setfscreatecon_newcon_t test_filesystem_file_t:filesystem { associate }; +allow test_filesystem_filecon_t test_filesystem_file_t:filesystem { associate }; +allow test_filesystem_no_getattr_t test_filesystem_file_t:filesystem { mount unmount relabelfrom relabelto }; +allow test_filesystem_no_mount_t test_filesystem_file_t:filesystem { relabelfrom relabelto }; +allow test_filesystem_no_remount_t test_filesystem_file_t:filesystem { mount unmount relabelfrom relabelto }; +allow test_filesystem_no_unmount_t test_filesystem_file_t:filesystem { mount relabelfrom relabelto }; +allow test_filesystem_no_getattr_t test_filesystem_file_t:dir { search mounton }; +allow test_filesystem_no_mount_t test_filesystem_file_t:dir { search mounton }; +allow test_filesystem_no_remount_t test_filesystem_file_t:dir { search mounton }; +allow test_filesystem_no_unmount_t test_filesystem_file_t:dir { search mounton }; + +# +############ Rules for VFAT ############################## +# +gen_require(` + type dosfs_t; +') +allow test_filesystem_t dosfs_t:file { open getattr write }; +allow test_filesystem_context_t dosfs_t:file { open getattr write }; +allow test_filesystem_no_getattr_t dosfs_t:filesystem { associate }; +allow test_filesystem_no_mount_t dosfs_t:filesystem { associate }; +allow test_filesystem_no_remount_t dosfs_t:filesystem { associate }; +allow test_filesystem_no_unmount_t dosfs_t:filesystem { associate }; +allow test_move_mount_no_mounton_t dosfs_t:filesystem { associate }; + # ########### Allow these domains to be entered from sysadm domain ############ # diff --git a/policy/test_filesystem_name_trans.te b/policy/test_filesystem_name_trans.te index ce04601..7e336e4 100644 --- a/policy/test_filesystem_name_trans.te +++ b/policy/test_filesystem_name_trans.te @@ -18,3 +18,9 @@ fs_associate(test_filesystem_filenametranscon2_t) type_transition test_filesystem_t test_filesystem_file_t:file test_filesystem_filenametranscon2_t "name_trans_test_file2"; allow test_filesystem_t test_filesystem_filenametranscon2_t:file { create getattr open write }; dontaudit unconfined_t test_filesystem_filenametranscon2_t:file { getattr read }; + +### NFS Rules ########## +type_transition test_filesystem_t test_file_t:file test_filesystem_filenametranscon1_t "name_trans_test_file1"; +type_transition test_filesystem_t test_file_t:file test_filesystem_filenametranscon2_t "name_trans_test_file2"; +allow test_filesystem_filenametranscon1_t test_filesystem_file_t:filesystem { associate }; +allow test_filesystem_filenametranscon2_t test_filesystem_file_t:filesystem { associate }; diff --git a/policy/test_filesystem_notify.te b/policy/test_filesystem_notify.te index 3e8a246..94570ac 100644 --- a/policy/test_filesystem_notify.te +++ b/policy/test_filesystem_notify.te @@ -5,12 +5,39 @@ ################# Test all functions ########################## # For fanotify tests allow test_filesystem_t self:filesystem { watch }; -# Until 'fs_watch_all_fs(test_filesystem_t)' in Policy use: -gen_require(` - type fs_t; -') allow test_filesystem_t fs_t:filesystem { watch }; allow test_filesystem_t test_filesystem_file_t:dir { watch_sb watch_mount }; +# For nfs +allow test_filesystem_t nfs_t:filesystem { watch }; +allow test_filesystem_t test_file_t:dir { watch_mount watch_sb }; +# For vfat +allow test_filesystem_t dosfs_t:filesystem { watch }; + +# +############### Rules for NFS mount with rootcontext option ################# +# +userdom_search_user_home_content(filesystemdomain) +allow test_filesystem_no_watch_mount_t nfs_t:filesystem { unmount }; +allow test_filesystem_no_watch_mount_t test_filesystem_file_t:dir { search }; +allow test_filesystem_no_watch_sb_t nfs_t:filesystem { unmount watch }; +allow test_filesystem_no_watch_sb_t test_filesystem_file_t:dir { search }; +allow test_filesystem_no_watch_t nfs_t:filesystem { unmount }; +allow test_filesystem_no_watch_t test_filesystem_file_t:dir { search }; + +# +############### Rules for NFS mount with no context option ################## +# +allow test_filesystem_no_watch_mount_t nfs_t:dir { search }; +allow test_filesystem_no_watch_sb_t nfs_t:dir { search }; +allow test_filesystem_no_watch_t nfs_t:dir { search }; + +# +############### Rules for NFS mount with fscontext option #################### +# +allow test_filesystem_no_watch_mount_t test_filesystem_file_t:filesystem { mount unmount relabelto }; +allow test_filesystem_no_watch_sb_t test_filesystem_file_t:filesystem { mount unmount relabelto watch }; +allow test_filesystem_no_watch_t test_filesystem_file_t:filesystem { mount unmount relabelto }; +allow test_filesystem_t test_filesystem_file_t:filesystem { watch }; #################### Deny filesystem { watch } ###################### # hooks.c selinux_path_notify() FILESYSTEM__WATCH @@ -22,7 +49,7 @@ typeattribute test_filesystem_no_watch_t filesystemdomain; allow test_filesystem_no_watch_t self:capability { sys_admin }; allow test_filesystem_no_watch_t self:filesystem { associate relabelto mount unmount relabelfrom }; -allow test_filesystem_no_watch_t test_file_t:dir { mounton write remove_name rmdir }; +allow test_filesystem_no_watch_t test_file_t:dir { mounton read write remove_name rmdir watch_sb }; fs_mount_all_fs(test_filesystem_no_watch_t) fs_relabelfrom_all_fs(test_filesystem_no_watch_t) fs_associate(test_filesystem_no_watch_t) @@ -37,7 +64,7 @@ typeattribute test_filesystem_no_watch_sb_t filesystemdomain; allow test_filesystem_no_watch_sb_t self:capability { sys_admin }; allow test_filesystem_no_watch_sb_t self:filesystem { watch associate relabelto mount unmount relabelfrom }; -allow test_filesystem_no_watch_sb_t test_file_t:dir { mounton write remove_name rmdir }; +allow test_filesystem_no_watch_sb_t test_file_t:dir { mounton read write remove_name rmdir }; fs_mount_all_fs(test_filesystem_no_watch_sb_t) fs_relabelfrom_all_fs(test_filesystem_no_watch_sb_t) @@ -53,7 +80,7 @@ typeattribute test_filesystem_no_watch_mount_t filesystemdomain; allow test_filesystem_no_watch_mount_t self:capability { sys_admin }; allow test_filesystem_no_watch_mount_t self:filesystem { watch associate relabelto mount unmount relabelfrom }; -allow test_filesystem_no_watch_mount_t test_file_t:dir { mounton write remove_name rmdir }; +allow test_filesystem_no_watch_mount_t test_file_t:dir { mounton read write remove_name rmdir }; fs_mount_all_fs(test_filesystem_no_watch_mount_t) fs_relabelfrom_all_fs(test_filesystem_no_watch_mount_t) diff --git a/tests/filesystem/.gitignore b/tests/filesystem/.gitignore index 5ac18d0..e76fcd3 100644 --- a/tests/filesystem/.gitignore +++ b/tests/filesystem/.gitignore @@ -9,3 +9,4 @@ check_file_context check_mount_context create_file grim_reaper +xfs_quotas_test diff --git a/tests/filesystem/Filesystem.pm b/tests/filesystem/Filesystem.pm index a08570a..a21d737 100644 --- a/tests/filesystem/Filesystem.pm +++ b/tests/filesystem/Filesystem.pm @@ -1,10 +1,10 @@ package Filesystem; use Exporter qw(import); our @EXPORT_OK = - qw(check_config udisks2_stop udisks2_restart get_loop_dev attach_dev make_fs mk_mntpoint_1 mk_mntpoint_2 cleanup cleanup1 reaper); + qw(check_config udisks2_stop udisks2_restart get_loop_dev attach_dev make_fs mk_mntpoint_1 mk_mntpoint_2 cleanup cleanup1 reaper nfs_gen_opts); sub check_config { - my ( $base, $fanotify_fs ) = @_; + my ( $base, $fanotify_fs, $nfs_enabled, $vfat_enabled ) = @_; $tst_count = 0; @@ -25,15 +25,26 @@ sub check_config { $mod_pol_vers = `checkmodule -V | cut -f 2 -d '-'`; $max_kernel_policy = `cat /sys/fs/selinux/policyvers`; - if ( $mod_pol_vers >= 11 and $pol_vers >= 25 and $max_kernel_policy >= 25 ) - { - $name_trans = 1; - $tst_count += 2; + if ( not $vfat_enabled ) { + if ( $mod_pol_vers >= 11 + and $pol_vers >= 25 + and $max_kernel_policy >= 25 ) + { + $name_trans = 1; + $tst_count += 2; + } + } + + $type_trans = 0; + if ( not $vfat_enabled ) { + $type_trans = 1; + $tst_count += 1; } - return ( $tst_count, $watch, $name_trans ); + + return ( $tst_count, $watch, $name_trans, $type_trans ); } -# Optionally stop the udisks(8) daemon, then restart on exit. +# Stop the udisks(8) daemon, then restart on exit. sub udisks2_stop { $status = 0; @@ -112,8 +123,9 @@ sub attach_dev { sub make_fs { my ( $mk_type, $mk_dev, $mk_dir ) = @_; print "Create $mk_dir/fstest with dd\n"; - $result = system( - "dd if=/dev/zero of=$mk_dir/fstest bs=1024 count=10240 2>/dev/null"); + $result = + system( + "dd if=/dev/zero of=$mk_dir/fstest bs=4096 count=4096 2>/dev/null"); if ( $result != 0 ) { print "dd failed to create $mk_dir/fstest\n"; } @@ -121,7 +133,7 @@ sub make_fs { attach_dev( $mk_dev, $mk_dir ); print "Make $mk_type filesystem on $mk_dev\n"; - $result = system("mkfs.$mk_type -I 256 $mk_dev >& /dev/null"); + $result = system("mkfs.$mk_type $mk_dev >& /dev/null"); if ( $result != 0 ) { system("losetup -d $mk_dev 2>/dev/null"); print "mkfs.$mk_type failed to create filesystem on $mk_dev\n"; @@ -164,3 +176,83 @@ sub reaper { system("$base/grim_reaper -t $n $v 2>/dev/null"); } } + +sub nfs_gen_opts { + + my ( $type, $base, $filesys ) = @_; + + $mnt_entry = `findmnt -fUln -t $type -T $base`; + my @mnt_item = split " ", $mnt_entry; + + $tgt = $mnt_item[0]; + $src = $mnt_item[1]; + $type = $mnt_item[2]; + + # Use a common $dev entry for all tests + $dev = "$src/tests/$filesys/mntpoint"; + + # Build mandatory nfs options, some of which mount.nfs(8) would resolve + ($clientaddr) = ( $mnt_item[3] =~ /clientaddr=([^,\/]+)/ ); + chomp($clientaddr); + $clientaddr = "clientaddr=$clientaddr"; + + # Remove items that could match e.g. clientaddr, addr + $mnt_item[3] =~ s/clientaddr=$clientaddr/xxxx/i; + ($addr) = ( $mnt_item[3] =~ /addr=([^,\/]+)/ ); + chomp($addr); + $addr = "addr=$addr"; + $mnt_item[3] =~ s/addr=$addr/xxxx/i; + ($proto) = ( $mnt_item[3] =~ /proto=([^,\/]+)/ ); + chomp($proto); + $proto = "proto=$proto"; + ($vers) = ( $mnt_item[3] =~ /vers=([^,\/]+)/ ); + chomp($vers); + $vers = "vers=$vers"; + + $fs_context = " "; + $fscontext = " "; + $seclabel = " "; + $seclabel_type = 0; # No seclabel = 0, fscontext = 1, context = 2 + ($fscontext) = ( $mnt_item[3] =~ /fscontext=([^,\/]+)/ ); + $mnt_item[3] =~ s/fscontext=$fs_context/xxxx/i; + ($context) = ( $mnt_item[3] =~ /context=([^,\/]+)/ ); + + if ( defined $fscontext ) { + $seclabel = "fscontext=$fscontext"; + $seclabel_type = 1; + } + elsif ( defined $context ) { + $seclabel = "context=$context"; + $seclabel_type = 2; + } + chomp($seclabel); + + print "NFS mount entries:\n\ttype: $type\n\tsrc: $src\n"; + print "\ttgt: $tgt\n\t$clientaddr\n\t$addr\n\t$proto\n\t$seclabel\n"; + + # Use a common set of NFS options. Note fsconfig(2) returns + # 'Invalid argument' if a blank entry (as $seclabel can be) is passed + # as a parameter (as NFS sees this as an invalid option). + if ( $seclabel eq " " ) { + $nfs_mount_opts = "$vers,$proto,$clientaddr,$addr"; + } + else { + $nfs_mount_opts = "$vers,$proto,$clientaddr,$addr,$seclabel"; + } + + # Build option for testing 'SELinux: mount invalid. Same superblock,...' + # that returns EBUSY. Depends on what the initial mount set as its value + $inval_seclabel = $seclabel; + if ( $seclabel_type eq 0 ) { + $inval_seclabel = "context=system_u:object_r:test_filesystem_file_t:s0"; + } + elsif ( $seclabel_type eq 1 ) { + $inval_seclabel =~ s/fscontext/context/i; + } + elsif ( $seclabel_type eq 2 ) { + $inval_seclabel =~ s/context/fscontext/i; + } + $nfs_inval_mount_opts = "$vers,$proto,$clientaddr,$addr,$inval_seclabel"; + + return ( $dev, $nfs_mount_opts, $nfs_inval_mount_opts, $seclabel_type ); +} diff --git a/tests/filesystem/Makefile b/tests/filesystem/Makefile index d2fad63..a863ea2 100644 --- a/tests/filesystem/Makefile +++ b/tests/filesystem/Makefile @@ -2,7 +2,8 @@ #export CFLAGS += -DHAVE_FS_WATCH_PERM TARGETS = mount umount quotas_test statfs_test create_file_change_context \ -fs_relabel check_file_context grim_reaper check_mount_context create_file +fs_relabel check_file_context grim_reaper check_mount_context create_file \ +xfs_quotas_test LDLIBS += -lselinux diff --git a/tests/filesystem/test b/tests/filesystem/test index 78faf72..536002c 100755 --- a/tests/filesystem/test +++ b/tests/filesystem/test @@ -1,37 +1,129 @@ #!/usr/bin/perl use Test::More; +# Load common subroutines. +use File::Basename qw(dirname); +use Cwd qw(abs_path); +use lib dirname( abs_path $0); +use Filesystem + qw(check_config udisks2_stop udisks2_restart get_loop_dev attach_dev make_fs mk_mntpoint_1 mk_mntpoint_2 cleanup cleanup1 reaper nfs_gen_opts); + BEGIN { $basedir = $0; $basedir =~ s|(.*)/[^/]*|$1|; - # Load common subroutines. - use File::Basename qw(dirname); - use Cwd qw(abs_path); - use lib dirname( abs_path $0); - use Filesystem - qw(check_config udisks2_stop udisks2_restart get_loop_dev attach_dev make_fs mk_mntpoint_1 mk_mntpoint_2 cleanup cleanup1 reaper); - - $test_count = 68; - - # Options: -v = Verbose, -d disable udisks(8) daemon + # Options: -v Verbose, -e enable udisks(8) daemon, -f filesystem type $v = " "; - $disable_udisks = 0; + $disable_udisks = 1; $udisks2_status = 0; + $quota_checks = 1; + $nfs_enabled = 0; + $vfat_enabled = 0; + + $i = 0; + $fs_type = " "; foreach $arg (@ARGV) { if ( $arg eq "-v" ) { $v = $arg; } - elsif ( $arg eq "-d" ) { - $disable_udisks = 1; + elsif ( $arg eq "-e" ) { + $disable_udisks = 0; + } + elsif ( $arg eq "-f" ) { + $fs_type = $ARGV[ $i + 1 ]; + } + $i++; + } + + # If NFS specified inform how to run + if ( $fs_type eq "nfs" or $fs_type eq "nfs4" ) { + plan skip_all => "To run NFS use 'tools/nfs.sh filesystem [-v]'"; + } + + # Get filesystem type if not specified + if ( $fs_type eq " " ) { + $fs_type = `findmnt -n -o FSTYPE -T $basedir`; + chomp $fs_type; + } + print "Testing filesystem fs_type: $fs_type\n"; + + # Obtain an appropriate set of mount options for NFS. + # rootcontext is not supported. + # $seclabel_type: 0 = No seclabel, 1 = fscontext, 2 = context + if ( $fs_type eq "nfs4" or $fs_type eq "nfs" ) { + ( $dev, $nfs_mount_opts, $nfs_inval_mount_opts, $seclabel_type ) = + nfs_gen_opts( $fs_type, $basedir, "filesystem" ); + $nfs_enabled = 1; + } + elsif ( $fs_type eq "vfat" ) { + $vfat_enabled = 1; + } + + # XFS supports quotas internally and therefore does not require calling + # security_quota_on(). There is a patch for selinux/hooks.c to add + # quotactl(2) triggers such as Q_XQUOTAOFF. + if ( $fs_type eq "xfs" ) { + $test_count = 62; + $quota_checks = 1; + } + elsif ( $fs_type eq "nfs4" or $fs_type eq "nfs" ) { + $test_count = 55; + $quota_checks = 0; + } + elsif ( $fs_type eq "vfat" ) { + $test_count = 55; + $quota_checks = 0; + } + else { + $test_count = 69; + } + + if ($nfs_enabled) { + + # hooks.c may_create() FILESYSTEM__ASSOCIATE is tested via the + # may_create_no_associate() test in nfs_filesystem/test + $test_count -= 3; + + # hooks.c selinux_inode_setxattr() FILESYSTEM__ASSOCIATE is tested + # via the inode_setxattr_no_associate() test in nfs_filesystem/test + $test_count -= 3; + + # Remove additional Test Invalid Mount tests + $test_count -= 1; + + # Remove tests involving multiple *context= options as invalid + $test_count -= 20; + + # Removed when no context option is set in a test + if ( $seclabel_type eq 0 ) { + $test_count -= 4; + } + + # Removed if fscontext option set in a test + elsif ( $seclabel_type eq 1 ) { + $test_count -= 1; } } + elsif ($vfat_enabled) { + + # For hooks.c may_create() FILESYSTEM__ASSOCIATE as not supported + $test_count -= 3; + + # For hooks.c selinux_inode_setxattr() FILESYSTEM__ASSOCIATE as + # not supported + $test_count -= 3; + + # For tests with defcontext= options as not supported + $test_count -= 6; + } # Check if watch and/or named type_transition rules configured - ( $addit, $test_watch, $test_name_trans ) = - check_config( $basedir, "$basedir/fanotify_fs" ); + ( $addit, $test_watch, $test_name_trans, $test_type_trans ) = + check_config( $basedir, "$basedir/fanotify_fs", $nfs_enabled, + $vfat_enabled ); - plan tests => ( $test_count += $addit ); + $test_count += $addit; + plan tests => $test_count; } # mount(2) MS_BIND | MS_PRIVATE requires an absolute path to a private mount @@ -46,9 +138,6 @@ else { $private_path = "$cwd/$basedir/mntpoint"; } -# Set initial filesystem type -$fs_type = "ext4"; - # Keep a list of devices used for removal at end of test. $device_count = 0; my @device_list; @@ -63,73 +152,108 @@ cleanup($basedir); system("mkdir -p $basedir/mntpoint 2>/dev/null"); print "Test setfscreatecon(3)\n"; -$result = system -"runcon -t test_setfscreatecon_t $basedir/fs_relabel $v -b $basedir/mntpoint -t test_setfscreatecon_newcon_t"; +$result = system( +"runcon -t test_setfscreatecon_t $basedir/fs_relabel $v -b $basedir/mntpoint -t test_setfscreatecon_newcon_t" +); ok( $result eq 0 ); -$result = system -"runcon -t test_no_setfscreatecon_t $basedir/fs_relabel $v -b $basedir/mntpoint -t test_setfscreatecon_newcon_t 2>&1"; +$result = system( +"runcon -t test_no_setfscreatecon_t $basedir/fs_relabel $v -b $basedir/mntpoint -t test_setfscreatecon_newcon_t 2>&1" +); ok( $result >> 8 eq 13 ); system("rm -rf $basedir/mntpoint 2>/dev/null"); ############### Test Basic Mount/Unmount ########################## mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$mount_opts1 = -"quota,usrquota,grpquota,defcontext=system_u:object_r:test_filesystem_file_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + + # For XFS quota tests. + if ( $fs_type eq "xfs" ) { + $mount_opts = +"uquota,prjquota,rootcontext=system_u:object_r:test_filesystem_file_t:s0"; + } + elsif ($quota_checks) { + $mount_opts = +"quota,usrquota,grpquota,rootcontext=system_u:object_r:test_filesystem_file_t:s0"; + } + else { + $mount_opts = "rootcontext=system_u:object_r:test_filesystem_file_t:s0"; + } +} print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$mount_opts1\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts1 $v" +"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); print "Then remount\n"; $result = system( -"runcon -t test_filesystem_t $basedir/mount -r -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts1 $v" +"runcon -t test_filesystem_t $basedir/mount -r -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); -print "Running quotacheck(8) to init user/group quota files\n"; +if ($quota_checks) { + if ( $fs_type eq "xfs" ) { + print "# XFS quota test with mount options: uquota,prjquota\n"; + $result = system( + "runcon -t test_filesystem_t $basedir/xfs_quotas_test $v -s $dev"); + ok( $result eq 0 ); + } + else { + print "Running quotacheck(8) to init user/group quota files\n"; -# On RHEL-6, there is a type transition to quota_t when running quotacheck -# as unconfined_t. Using "runcon `id -Z` quotacheck ..." resolves this. -$result = system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); -ok( $result eq 0 ); + # On RHEL-6, there is a type transition to quota_t when running quotacheck + # as unconfined_t. Using "runcon `id -Z` quotacheck ..." resolves this. + $result = + system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); + ok( $result eq 0 ); -print "Toggle User & Group quotas on/off\n"; -$result = system( + print "Toggle User & Group quotas on/off\n"; + $result = system( "runcon -t test_filesystem_t $basedir/quotas_test -s $dev -t $private_path/mp1/aquota.user $v" -); -ok( $result eq 0 ); -$result = system( + ); + ok( $result eq 0 ); + $result = system( "runcon -t test_filesystem_t $basedir/quotas_test -s $dev -t $private_path/mp1/aquota.group $v" -); -ok( $result eq 0 ); - + ); + ok( $result eq 0 ); + } +} print "Get statfs(2)\n"; $result = system( "runcon -t test_filesystem_t $basedir/statfs_test -t $basedir/mntpoint $v"); ok( $result eq 0 ); -print +if ($test_type_trans) { + print "Creating 'trans_test_file' and checking context changed via type_transition rule\n"; -$result = - system( + $result = system( "runcon -t test_filesystem_t $basedir/create_file -f $private_path/mp1/trans_test_file -e test_filesystem_filetranscon_t $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); +} print "Creating 'test_file' and changing its context via setfilecon(3)\n"; $result = system( "runcon -t test_filesystem_t $basedir/create_file_change_context -t test_filesystem_filecon_t -f $private_path/mp1/test_file $v" ); -ok( $result eq 0 ); +if ($vfat_enabled) { + ok( $result >> 8 eq 95 ); # EOPNOTSUPP +} +else { + ok( $result eq 0 ); +} if ($test_name_trans) { print @@ -171,10 +295,15 @@ cleanup1( $basedir, $dev ); ############### Test Move Mount ########################## mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$mount_opts2 = -"quota,usrquota,grpquota,rootcontext=system_u:object_r:test_filesystem_file_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = "rootcontext=system_u:object_r:test_filesystem_file_t:s0"; +} print "Set mount MS_BIND on filesystem\n"; $result = system( @@ -190,9 +319,9 @@ ok( $result eq 0 ); mk_mntpoint_2($private_path); print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$mount_opts2\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts2 $v" +"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -217,223 +346,317 @@ cleanup1( $basedir, $dev ); ############### Deny filesystem { relabelfrom } ########################## # hooks.c may_context_mount_sb_relabel() FILESYSTEM__RELABELFROM -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_relabelfrom = - "defcontext=system_u:object_r:test_filesystem_sb_relabel_no_relabelfrom_t:s0"; +# +# Also tested in nfs_filesystem/test +# +if ( ( $nfs_enabled and $seclabel_type ne 0 ) or not $nfs_enabled ) { + mk_mntpoint_1($private_path); -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_relabelfrom\n"; -$result = system( -"runcon -t test_filesystem_sb_relabel_no_relabelfrom_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_relabelfrom $v 2>&1" -); -ok( $result >> 8 eq 13 ); + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = +"rootcontext=system_u:object_r:test_filesystem_sb_relabel_no_relabelfrom_t:s0"; + } -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_sb_relabel_no_relabelfrom_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" + ); + ok( $result >> 8 eq 13 ); + + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} ############### Deny filesystem { relabelto } ########################## # hooks.c may_context_mount_sb_relabel() FILESYSTEM__RELABELTO -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_relabelto = - "fscontext=system_u:object_r:test_filesystem_sb_relabel_no_relabelto_t:s0"; +# +# Also tested in nfs_filesystem/test +# +if ( ( $nfs_enabled and $seclabel_type eq 1 ) or not $nfs_enabled ) { + mk_mntpoint_1($private_path); -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_relabelto\n"; -$result = system( -"runcon -t test_filesystem_sb_relabel_no_relabelto_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_relabelto $v 2>&1" -); -ok( $result >> 8 eq 13 ); + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = +"fscontext=system_u:object_r:test_filesystem_sb_relabel_no_relabelto_t:s0"; + } -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_sb_relabel_no_relabelto_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" + ); + ok( $result >> 8 eq 13 ); + + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} ############### Deny filesystem { relabelfrom } ########################## # hooks.c may_context_mount_inode_relabel() FILESYSTEM__RELABELFROM -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_relabelfrom = - "rootcontext=system_u:object_r:test_filesystem_no_inode_no_relabelfrom_t:s0"; +# +# Also tested in nfs_filesystem/test +# +if ( ( $nfs_enabled and $seclabel_type ne 0 ) or not $nfs_enabled ) { + mk_mntpoint_1($private_path); -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_relabelfrom\n"; -$result = system( -"runcon -t test_filesystem_no_inode_no_relabelfrom_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_relabelfrom $v 2>&1" -); -ok( $result >> 8 eq 13 ); + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = +"rootcontext=system_u:object_r:test_filesystem_no_inode_no_relabelfrom_t:s0"; + } -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_no_inode_no_relabelfrom_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" + ); + ok( $result >> 8 eq 13 ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} ############### Deny filesystem { associate } ########################## # hooks.c may_context_mount_inode_relabel() FILESYSTEM__ASSOCIATE -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); +# +# Tested in nfs_filesystem/test +# +if ( not $nfs_enabled ) { + mk_mntpoint_1($private_path); -# This defcontext will trigger denial. -$opts_no_associate = -"defcontext=system_u:object_r:test_filesystem_inode_relabel_no_associate_t:s0"; + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = +"rootcontext=system_u:object_r:test_filesystem_inode_relabel_no_associate_t:s0"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_associate\n"; -$result = system( -"runcon -t test_filesystem_inode_relabel_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_associate $v 2>&1" -); -ok( $result >> 8 eq 13 ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_inode_relabel_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" + ); + ok( $result >> 8 eq 13 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} ############### Deny filesystem { associate } ########################## # hooks.c may_create() FILESYSTEM__ASSOCIATE -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); +# +# Tested in nfs_filesystem/test +# +if ( not $nfs_enabled and not $vfat_enabled ) { + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); # Use this fscontext= to get sensible audit log entry of: # "allow unlabeled_t test_filesystem_may_create_no_associate_t:filesystem associate;" -$opts_no_associate_file = - "fscontext=system_u:object_r:test_filesystem_may_create_no_associate_t:s0"; + $mount_opts = +"fscontext=system_u:object_r:test_filesystem_may_create_no_associate_t:s0"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_associate_file\n"; -$result = system( -"runcon -t test_filesystem_may_create_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_associate_file $v" -); -ok( $result eq 0 ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_may_create_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" + ); + ok( $result eq 0 ); -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + print "Creating test file $basedir/mntpoint/mp1/test_file\n"; + $result = system( "runcon -t test_filesystem_may_create_no_associate_t $basedir/create_file_change_context -t unconfined_t -f $basedir/mntpoint/mp1/test_file $v 2>&1" - ); -ok( $result >> 8 eq 13 ); + ); + ok( $result >> 8 eq 13 ); # EACCES -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = - system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_may_create_no_associate_t $basedir/umount -t $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} -############### Deny filesystem { quotamod } ########################## -# hooks.c selinux_quotactl() FILESYSTEM__QUOTAMOD -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_quotamod = +if ($quota_checks) { + ############### Deny filesystem { quotamod } ########################## + # hooks.c selinux_quotactl() FILESYSTEM__QUOTAMOD + # + # This test requires a patch to hooks.c to implement: Q_XQUOTAOFF, + # Q_XQUOTAON and Q_XSETQLIM. + # + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + + if ( $fs_type eq "xfs" ) { + $opts_no_quotamod = +"quota,uquota,prjquota,fscontext=system_u:object_r:test_filesystem_no_quotamod_t:s0"; + } + else { + $opts_no_quotamod = "quota,usrquota,grpquota,fscontext=system_u:object_r:test_filesystem_no_quotamod_t:s0"; + } -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_quotamod\n"; -$result = system( + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$opts_no_quotamod\n"; + $result = system( "runcon -t test_filesystem_no_quotamod_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_quotamod $v 2>&1" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -# No need to run quotacheck(8) as never gets far enough to read quota file -print "Toggle User & Group quotas on/off\n"; -$result = system( + if ( $fs_type eq "xfs" ) { + print "Toggle xfs quotas on/off\n"; + $result = system( +"runcon -t test_filesystem_no_quotamod_t $basedir/xfs_quotas_test -s $dev $v 2>&1" + ); + ok( $result >> 8 eq 13 ); + } + else { + # No need to run quotacheck(8) as never gets far enough to read quota file + print "Toggle User & Group quotas on/off\n"; + $result = system( "runcon -t test_filesystem_no_quotamod_t $basedir/quotas_test -s $dev -t $private_path/mp1/aquota.user $v 2>&1" -); -ok( $result >> 8 eq 13 ); + ); + ok( $result >> 8 eq 13 ); + } -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_no_quotamod_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); -############### Deny filesystem { quotaget } ########################## -# hooks.c selinux_quotactl() FILESYSTEM__QUOTAGET -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_quotaget = + ############### Deny filesystem { quotaget } ########################## + # hooks.c selinux_quotactl() FILESYSTEM__QUOTAGET + # + # This test requires a patch to hooks.c to implement: Q_XGETQUOTA, + # Q_XGETQSTAT, Q_XGETQSTATV and Q_XGETNEXTQUOTA. + # + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + + if ( $fs_type eq "xfs" ) { + $opts_no_quotaget = +"quota,uquota,prjquota,context=system_u:object_r:test_filesystem_no_quotaget_t:s0"; + } + else { + $opts_no_quotaget = "quota,usrquota,grpquota,context=system_u:object_r:test_filesystem_no_quotaget_t:s0"; + } -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_quotaget\n"; -$result = system( + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$opts_no_quotaget\n"; + $result = system( "runcon -t test_filesystem_no_quotaget_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_quotaget $v" -); -ok( $result eq 0 ); - -print "Running quotacheck(8) to init user/group quota files\n"; -$result = system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Toggle User & Group quotas on/off\n"; -$result = system( + if ( $fs_type eq "xfs" ) { + print "Toggle xfs quotas on/off\n"; + $result = system( +"runcon -t test_filesystem_no_quotaget_t $basedir/xfs_quotas_test -s $dev $v 2>&1" + ); + ok( $result >> 8 eq 13 ); + } + else { + print "Running quotacheck(8) to init user/group quota files\n"; + $result = + system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); + ok( $result eq 0 ); + + print "Toggle User & Group quotas on/off\n"; + $result = system( "runcon -t test_filesystem_no_quotaget_t $basedir/quotas_test -s $dev -t $private_path/mp1/aquota.user $v 2>&1" -); -ok( $result >> 8 eq 13 ); + ); + ok( $result >> 8 eq 13 ); + } -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_no_quotaget_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); - -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + ); + ok( $result eq 0 ); -############### Deny file { quotaon } ########################## -# hooks.c selinux_quota_on() FILE__QUOTAON -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_quotaon = - "quota,usrquota,grpquota,context=system_u:object_r:test_file_no_quotaon_t:s0"; + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_quotaon\n"; -$result = system( + ############### Deny file { quotaon } ########################## + # hooks.c selinux_quota_on() FILE__QUOTAON + # XFS does not require this test + # + if ( not $fs_type eq "xfs" ) { + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + + $opts_no_quotaon = +"quota,usrquota,grpquota,context=system_u:object_r:test_file_no_quotaon_t:s0"; + + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$opts_no_quotaon\n"; + $result = system( "runcon -t test_file_no_quotaon_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_quotaon $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Running quotacheck(8) to init user/group quota files\n"; -$result = system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); -ok( $result eq 0 ); + print "Running quotacheck(8) to init user/group quota files\n"; + $result = + system("runcon `id -Z` quotacheck -ugF vfsv0 $private_path/mp1"); + ok( $result eq 0 ); -print "Toggle User quotas on/off\n"; -$result = system( + print "Toggle User quotas on/off\n"; + $result = system( "runcon -t test_file_no_quotaon_t $basedir/quotas_test -s $dev -t $private_path/mp1/aquota.user $v 2>&1" -); -ok( $result >> 8 eq 13 ); + ); + ok( $result >> 8 eq 13 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_file_no_quotaon_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); + } +} # End quota checks ############### Deny filesystem { mount } ########################## # hooks.c selinux_sb_kern_mount() FILESYSTEM__MOUNT mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_mount = "rootcontext=system_u:object_r:test_filesystem_no_mount_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = "rootcontext=system_u:object_r:test_filesystem_no_mount_t:s0"; +} print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_mount\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_mount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_mount $v 2>&1" +"runcon -t test_filesystem_no_mount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" ); ok( $result >> 8 eq 13 ); @@ -443,15 +666,21 @@ cleanup1( $basedir, $dev ); ############### Deny filesystem { getattr } ########################## # hooks.c selinux_sb_statfs() FILESYSTEM__GETATTR mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_getattr = - "rootcontext=system_u:object_r:test_filesystem_no_getattr_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = + "rootcontext=system_u:object_r:test_filesystem_no_getattr_t:s0"; +} print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_getattr\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_getattr_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_getattr $v" +"runcon -t test_filesystem_no_getattr_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -472,21 +701,27 @@ cleanup1( $basedir, $dev ); ############### Deny filesystem { remount } ########################## # hooks.c selinux_mount() FILESYSTEM__REMOUNT mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_remount = - "rootcontext=system_u:object_r:test_filesystem_no_remount_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = + "rootcontext=system_u:object_r:test_filesystem_no_remount_t:s0"; +} print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_remount\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_remount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_remount $v" +"runcon -t test_filesystem_no_remount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); print "Then remount\n"; $result = system( -"runcon -t test_filesystem_no_remount_t $basedir/mount -r -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_remount $v 2>&1" +"runcon -t test_filesystem_no_remount_t $basedir/mount -r -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v 2>&1" ); ok( $result >> 8 eq 13 ); @@ -502,15 +737,21 @@ cleanup1( $basedir, $dev ); ############### Deny filesystem { unmount } ########################## # hooks.c selinux_umount() FILESYSTEM__UNMOUNT mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_unmount = - "rootcontext=system_u:object_r:test_filesystem_no_unmount_t:s0"; + +if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = + "rootcontext=system_u:object_r:test_filesystem_no_unmount_t:s0"; +} print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_unmount\n"; +print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_unmount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_unmount $v" +"runcon -t test_filesystem_no_unmount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -532,48 +773,56 @@ cleanup1( $basedir, $dev ); ############### Deny filesystem { associate } ########################## # hooks.c selinux_inode_setxattr() FILESYSTEM__ASSOCIATE -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$opts_no_associate_xattr = -"defcontext=system_u:object_r:test_filesystem_inode_setxattr_no_associate_t:s0,fscontext=system_u:object_r:test_filesystem_inode_setxattr_no_associate_t:s0"; +# +# Tested in nfs_filesystem/test +# +if ( not $nfs_enabled and not $vfat_enabled ) { + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = +"rootcontext=system_u:object_r:test_filesystem_inode_setxattr_no_associate_t:s0,fscontext=system_u:object_r:test_filesystem_inode_setxattr_no_associate_t:s0"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$opts_no_associate_xattr\n"; -$result = system( -"runcon -t test_filesystem_inode_setxattr_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_associate_xattr $v" -); -ok( $result eq 0 ); + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_inode_setxattr_no_associate_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" + ); + ok( $result eq 0 ); -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + $result = system( "runcon -t test_filesystem_inode_setxattr_no_associate_t $basedir/create_file_change_context -t unconfined_t -f $basedir/mntpoint/mp1/test_file $v 2>&1" - ); -ok( $result >> 8 eq 13 ); + ); + ok( $result >> 8 eq 13 ); # EACCES -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = - system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_inode_setxattr_no_associate_t $basedir/umount -t $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} if ($test_watch) { ############### Deny filesystem { watch } ########################## # hooks.c selinux_path_notify() FILESYSTEM__WATCH mk_mntpoint_1($private_path); - ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); - make_fs( $fs_type, $dev, $basedir ); - $opts_no_watch = "context=system_u:object_r:test_filesystem_no_watch_t:s0"; + + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = "context=system_u:object_r:test_filesystem_no_watch_t:s0"; + } print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; - print "Using mount options:\n\t$opts_no_watch\n"; + print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_watch_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_watch $v" +"runcon -t test_filesystem_no_watch_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -595,15 +844,21 @@ if ($test_watch) { ############### Deny file { watch_sb } ########################## # hooks.c selinux_path_notify() FILE__WATCH_SB mk_mntpoint_1($private_path); - ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); - make_fs( $fs_type, $dev, $basedir ); - $opts_no_watch_sb = - "context=system_u:object_r:test_filesystem_no_watch_sb_t:s0"; + + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = + "context=system_u:object_r:test_filesystem_no_watch_sb_t:s0"; + } print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; - print "Using mount options:\n\t$opts_no_watch_sb\n"; + print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_watch_sb_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_watch_sb $v" +"runcon -t test_filesystem_no_watch_sb_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -625,15 +880,21 @@ if ($test_watch) { ############### Deny file { watch_mount } ########################## # hooks.c selinux_path_notify() FILE__WATCH_MOUNT mk_mntpoint_1($private_path); - ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); - make_fs( $fs_type, $dev, $basedir ); - $opts_no_watch_mount = - "context=system_u:object_r:test_filesystem_no_watch_mount_t:s0"; + + if ($nfs_enabled) { + $mount_opts = $nfs_mount_opts; + } + else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = + "context=system_u:object_r:test_filesystem_no_watch_mount_t:s0"; + } print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; - print "Using mount options:\n\t$opts_no_watch_mount\n"; + print "Using mount options:\n\t$mount_opts\n"; $result = system( -"runcon -t test_filesystem_no_watch_mount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $opts_no_watch_mount $v" +"runcon -t test_filesystem_no_watch_mount_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $mount_opts $v" ); ok( $result eq 0 ); @@ -653,236 +914,294 @@ if ($test_watch) { cleanup1( $basedir, $dev ); } -########################################################################## -# context - Useful when mounting filesystems that do not support extended -# attributes. -# Tested by - Creating a filesystem that has xattrs set to a different value, -# then mount with context= and confirm that the files have that -# context as well as any newly created files (even if fscreate -# was set to something else), and that setfilecon/setxattr() on -# files within the mount fails with errno EOPNOTSUPP. -########################################################################## +############### Test Invalid Mount ########################## +# This will generate a log entry "SELinux: mount invalid. Same superblock, +# different security settings for (dev 0:49, type nfs4)" +# Note that NFS is already mounted at this point by nfs.sh +# mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -# Mount with xttrs to create a file with specific context. -$context1_opts = - "defcontext=system_u:object_r:test_filesystem_context_file_t:s0"; +if ($nfs_enabled) { + $mount_inval_opts = $nfs_inval_mount_opts; +} +else { + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $mount_opts = "rootcontext=system_u:object_r:test_filesystem_file_t:s0"; + $mount_inval_opts = "fscontext=system_u:object_r:test_filesystem_file_t:s0"; -print "Testing 'context=' mount option\n"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$context1_opts\n"; + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$mount_opts\n"; + $result = system( +"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_opts $v" + ); + ok( $result eq 0 ); +} + +print "Test 'Invalid Mount' $fs_type filesystem on $private_path/mp1\n"; +print "Mount $fs_type filesystem on $private_path/mp1\n"; +print "Using mount options:\n\t$mount_inval_opts\n"; $result = system( -"runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $context1_opts $v" +"runcon -t test_filesystem_t $basedir/mount -s $dev -t $private_path/mp1 -f $fs_type -o $mount_inval_opts $v 2>&1" ); -ok( $result eq 0 ); +if ( $nfs_enabled and $result >> 8 eq 16 ) { + ok( 1, "Returned EBUSY, known bug" ); +} +else { + system( +"runcon -t test_filesystem_t $basedir/umount -t $private_path/mp1 $v 2>&1" + ); + ok( $result >> 8 eq 22 ); # EINVAL +} -# Create file with 'test_filesystem_filecon_t' context -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( +print "Removing: $basedir/mntpoint\n"; +cleanup1( $basedir, $dev ); + +if ( not $nfs_enabled ) { + ########################################################################## + # context - Useful when mounting filesystems that do not support + # extended attributes. + # Note when testing vfat the test will fail earlier, but + # just carry on + # Tested by - Creating a filesystem that has xattrs set to a different + # value, then mount with context= and confirm that the files + # have that context as well as any newly created files (even + # if fscreate was set to something else), and that + # setfilecon/setxattr() on files within the mount fails with + # errno EOPNOTSUPP. + ########################################################################## + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + + # Mount with xttrs to create a file with specific context. + $context1_opts = + "rootcontext=system_u:object_r:test_filesystem_context_file_t:s0"; + + print "Testing 'context=' mount option\n"; + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$context1_opts\n"; + $result = system( +"runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $context1_opts $v" + ); + ok( $result eq 0 ); + + # Create file with 'test_filesystem_filecon_t' context + print "Creating test file $basedir/mntpoint/mp1/test_file\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/create_file_change_context -t test_filesystem_filecon_t -f $private_path/mp1/test_file $v" - ); -ok( $result eq 0 ); + ); + if ($vfat_enabled) { + ok( $result >> 8 eq 95 ); # EOPNOTSUPP + } + else { + ok( $result eq 0 ); + } -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -# Need to free the loop device, then get new one and attach -system("losetup -d $dev 2>/dev/null"); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -attach_dev( $dev, $basedir ); + # Need to free the loop device, then get new one and attach + system("losetup -d $dev 2>/dev/null"); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + attach_dev( $dev, $basedir ); -# Mount again with no xttr support -$context2_opts = "context=system_u:object_r:test_filesystem_context_file_t:s0"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$context2_opts\n"; -$result = system( + # Mount again with no xttr support + $context2_opts = + "context=system_u:object_r:test_filesystem_context_file_t:s0"; + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$context2_opts\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $context2_opts $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); # Now check the context on file is system_u:object_r:test_filesystem_context_file_t:s0 -print "Check test file context $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + print "Check test file context $basedir/mntpoint/mp1/test_file\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/check_file_context -f $private_path/mp1/test_file -e system_u:object_r:test_filesystem_context_file_t:s0 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); # Then create a file with 'test_filesystem_filecon_t' context, this should fail with EOPNOTSUPP -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + print "Creating test file $basedir/mntpoint/mp1/test_file\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/create_file_change_context -t test_filesystem_filecon_t -f $private_path/mp1/test_file $v 2>/dev/null" - ); -ok( $result >> 8 eq 95 ); + ); + ok( $result >> 8 eq 95 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = - system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/umount -t $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); -########################################################################## -# rootcontext - Explicitly label the root inode of the filesystem being -# mounted before that filesystem or inode becomes visible -# to userspace. -# Tested by - Set mountpoint to unlabeled_t and then check that the -# context of the root directory matches rootcontext= after -# the mount operation. -########################################################################## -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$root_opts = "rootcontext=system_u:object_r:test_filesystem_context_file_t:s0"; + ########################################################################## + # rootcontext - Explicitly label the root inode of the filesystem being + # mounted before that filesystem or inode becomes visible + # to userspace. + # Tested by - Set mountpoint to unlabeled_t and then check that the + # context of the root directory matches rootcontext= after + # the mount operation. + ########################################################################## + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $root_opts = + "rootcontext=system_u:object_r:test_filesystem_context_file_t:s0"; -print "Testing 'rootcontext=' mount option\n"; + print "Testing 'rootcontext=' mount option\n"; # Reset mountpoint to 'unlabeled_t' so it is different to any other possible test values. -print "Resetting MP to unlabeled_t $basedir/mntpoint/mp1\n"; -$result = - system( + print "Resetting MP to unlabeled_t $basedir/mntpoint/mp1\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/check_mount_context -r -m $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$root_opts\n"; -$result = system( + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$root_opts\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $root_opts $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -# Now check the mountpoint is the 'rootcontext=' value -print "Check MP context $basedir/mntpoint/mp1\n"; -$result = - system( + # Now check the mountpoint is the 'rootcontext=' value + print "Check MP context $basedir/mntpoint/mp1\n"; + $result = + system( "runcon -t test_filesystem_context_t $basedir/check_mount_context -m $basedir/mntpoint/mp1 -e system_u:object_r:test_filesystem_context_file_t:s0 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); - -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + ); + ok( $result eq 0 ); -########################################################################## -# defcontext - Set default security context for unlabeled files. -# This overrides the value set for unlabeled files in policy -# and requires a filesystem that supports xattr labeling. -# Tested by - Create filesystem that has files w/o xattrs and then confirm -# that they are mapped to the specified defcontext upon mount, -# where defcontext differs from the policy default. -########################################################################## -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -make_fs( $fs_type, $dev, $basedir ); -$test_opts = "context=system_u:object_r:test_filesystem_context_file_t:s0"; + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); -print "Testing 'defcontext=' mount option\n"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$test_opts\n"; -$result = system( + if ( not $vfat_enabled ) { + ####################################################################### + # defcontext - Set default security context for unlabeled files. + # This overrides the value set for unlabeled files in policy + # and requires a filesystem that supports xattr labeling. + # Tested by - Create filesystem that has files w/o xattrs and then + # confirm that they are mapped to the specified defcontext + # upon mount, where defcontext differs from the policy + # default. + ####################################################################### + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + make_fs( $fs_type, $dev, $basedir ); + $test_opts = + "context=system_u:object_r:test_filesystem_context_file_t:s0"; + + print "Testing 'defcontext=' mount option\n"; + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$test_opts\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $test_opts $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -# Create file, its context will be system_u:object_r:test_filesystem_context_file_t:s0 from $test_opts -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + # Create file, its context will be: + # system_u:object_r:test_filesystem_context_file_t:s0 from $test_opts + print "Creating test file $basedir/mntpoint/mp1/test_file\n"; + $result = system( "runcon -u system_u -t test_filesystem_fscontext_t $basedir/create_file -f $basedir/mntpoint/mp1/test_file -e test_filesystem_context_file_t $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/umount -t $basedir/mntpoint/mp1 $v" -); -ok( $result eq 0 ); - -# Need to free the loop device, then get new dev one and attach -system("losetup -d $dev 2>/dev/null"); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -attach_dev( $dev, $basedir ); - -# Mount again with defcontext= -$defcontext_opts = "defcontext=system_u:object_r:test_filesystem_filecon_t:s0"; -print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$defcontext_opts\n"; -$result = system( + ); + ok( $result eq 0 ); + + # Need to free the loop device, then get new dev one and attach + system("losetup -d $dev 2>/dev/null"); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + attach_dev( $dev, $basedir ); + + # Mount again with defcontext= + $defcontext_opts = + "defcontext=system_u:object_r:test_filesystem_filecon_t:s0"; + print "Mount $fs_type filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$defcontext_opts\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $defcontext_opts $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); # Now check the file context is now system_u:object_r:test_filesystem_filecon_t:s0 -print "Check test file context $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + print "Check test file context $basedir/mntpoint/mp1/test_file\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/check_file_context -f $basedir/mntpoint/mp1/test_file -e system_u:object_r:test_filesystem_filecon_t:s0 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = - system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = system( "runcon -t test_filesystem_context_t $basedir/umount -t $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); + } -########################################################################## -# fscontext - Sets the overarching filesystem label to a specific security -# context. This filesystem label is separate from the individual -# labels on the files. -# Tested by - Mount a tmpfs (fs_use_trans) filesystem with fscontext= and -# then create a file within it, checking its context. -########################################################################## -$fs_type = "tmpfs"; -mk_mntpoint_1($private_path); -( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); -$fscontext_opts = + ########################################################################## + # fscontext - Sets the overarching filesystem label to a specific + # security context. This filesystem label is separate from + # the individual labels on the files. + # Tested by - Mount a tmpfs (fs_use_trans) filesystem with fscontext= + # and then create a file within it, checking its context. + ########################################################################## + $fs_type = "tmpfs"; + mk_mntpoint_1($private_path); + ( $dev, $device_count ) = get_loop_dev( \@device_list, $device_count ); + $fscontext_opts = "fscontext=system_u:object_r:test_filesystem_fscontext_fs_t:s0,size=10M,mode=0770"; -print "Testing 'fscontext=' mount option\n"; -print "Mount tmpfs filesystem on $basedir/mntpoint/mp1\n"; -print "Using mount options:\n\t$fscontext_opts\n"; -$result = system( + print "Testing 'fscontext=' mount option\n"; + print "Mount tmpfs filesystem on $basedir/mntpoint/mp1\n"; + print "Using mount options:\n\t$fscontext_opts\n"; + $result = system( "runcon -t test_filesystem_fscontext_t $basedir/mount -s $dev -t $basedir/mntpoint/mp1 -f $fs_type -o $fscontext_opts $v" -); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Creating test file $basedir/mntpoint/mp1/test_file\n"; -$result = - system( + print "Creating test file $basedir/mntpoint/mp1/test_file\n"; + $result = + system( "runcon -t test_filesystem_fscontext_t $basedir/create_file_change_context -t test_filesystem_filecon_t -f $private_path/mp1/test_file $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Unmount filesystem from $basedir/mntpoint/mp1\n"; -$result = - system( + print "Unmount filesystem from $basedir/mntpoint/mp1\n"; + $result = + system( "runcon -t test_filesystem_fscontext_t $basedir/umount -t $basedir/mntpoint/mp1 $v" - ); -ok( $result eq 0 ); + ); + ok( $result eq 0 ); -print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; -cleanup1( $basedir, $dev ); + print "Removing: $dev $basedir/mntpoint $basedir/fstest\n"; + cleanup1( $basedir, $dev ); +} reaper( \@device_list, $basedir, $v ); diff --git a/tests/filesystem/xfs_quotas_test.c b/tests/filesystem/xfs_quotas_test.c new file mode 100644 index 0000000..fd4475f --- /dev/null +++ b/tests/filesystem/xfs_quotas_test.c @@ -0,0 +1,96 @@ +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <unistd.h> +#include <errno.h> +#include <stdbool.h> +#include <sys/quota.h> +#include <xfs/xqm.h> +#include <selinux/selinux.h> + +static void print_usage(char *progname) +{ + fprintf(stderr, + "usage: %s -s src [-v]\n" + "Where:\n\t" + "-s Source\n\t" + "-v Print information.\n", progname); + exit(-1); +} + +int main(int argc, char *argv[]) +{ + int opt, result, qcmd, save_err; + char *context, *src = NULL; + bool verbose = false; + int on_flags = XFS_QUOTA_UDQ_ACCT | XFS_QUOTA_UDQ_ENFD; + int off_flags = XFS_QUOTA_UDQ_ENFD; + struct fs_quota_stat q_stat; + + while ((opt = getopt(argc, argv, "s:v")) != -1) { + switch (opt) { + case 's': + src = optarg; + break; + case 'v': + verbose = true; + break; + default: + print_usage(argv[0]); + } + } + + if (!src) + print_usage(argv[0]); + + if (verbose) { + result = getcon(&context); + if (result < 0) { + fprintf(stderr, "Failed to obtain process context\n"); + return -1; + } + printf("Process context:\n\t%s\n", context); + free(context); + } + + /* This requires FILESYSTEM__QUOTAGET */ + qcmd = QCMD(Q_XGETQSTAT, USRQUOTA); + result = quotactl(qcmd, src, 0, (void *)&q_stat); + save_err = errno; + if (result < 0) { + fprintf(stderr, "quotactl(Q_XGETQSTAT, USRQUOTA) Failed: %s\n", + strerror(errno)); + return save_err; + } + if (verbose) + printf("XFS Q_XGETQSTAT Version: %d Flags: 0x%04x Number of dquots: %d\n", + q_stat.qs_version, q_stat.qs_flags, q_stat.qs_incoredqs); + + /* + * The tests turn XFS quotas on, therefore need to turn off then on + * These require FILESYSTEM__QUOTAMOD + */ + qcmd = QCMD(Q_XQUOTAOFF, USRQUOTA); + result = quotactl(qcmd, src, 0, (void *)&off_flags); + save_err = errno; + if (result < 0) { + fprintf(stderr, "quotactl(Q_XQUOTAOFF, USRQUOTA) Failed: %s\n", + strerror(errno)); + return save_err; + } + if (verbose) + printf("XFS User Quota - OFF\n"); + + qcmd = QCMD(Q_XQUOTAON, USRQUOTA); + result = quotactl(qcmd, src, 0, (void *)&on_flags); + save_err = errno; + if (result < 0) { + fprintf(stderr, "quotactl(Q_XQUOTAON, USRQUOTA) Failed: %s\n", + strerror(errno)); + return save_err; + } + if (verbose) + printf("XFS User Quota - ON\n"); + + return 0; +} diff --git a/tests/nfsruntests.pl b/tests/nfsruntests.pl new file mode 100755 index 0000000..c3f0626 --- /dev/null +++ b/tests/nfsruntests.pl @@ -0,0 +1,5 @@ +#!/usr/bin/perl +use Test::Harness; + +@test = "$ARGV[0]"; +runtests(@test); diff --git a/tools/nfs.sh b/tools/nfs.sh index 7ba4cfc..d4c5c3f 100755 --- a/tools/nfs.sh +++ b/tools/nfs.sh @@ -1,12 +1,16 @@ #!/bin/sh -e MOUNT=`stat --print %m .` TESTDIR=`pwd` -MAKE_TEST=0 +POPD=0 +FS_CTX="fscontext=system_u:object_r:test_filesystem_file_t:s0" +# To run individual tests on NFS with -v option: +RUN_TEST=$1 +V=$2 function err_exit() { - if [ $MAKE_TEST -eq 1 ]; then - echo "Closing down NFS" - popd + if [ $POPD -eq 1 ]; then + echo "Test failed on line: $1 - Closing down NFS" + popd >/dev/null 2>&1 else echo "Error on line: $1 - Closing down NFS" fi @@ -19,52 +23,85 @@ function err_exit() { trap 'err_exit $LINENO' ERR +function run_test() { + # Make all required for tests + make -C tests/fs_filesystem + if [ $2 ]; then + cd tests/$1 + ./test $2 + cd ../../ + else + cd tests + ./nfsruntests.pl $1/test + cd ../ + fi + if [ $POPD -eq 1 ]; then + popd >/dev/null 2>&1 + umount /mnt/selinux-testsuite + fi + exportfs -u localhost:$MOUNT + rmdir /mnt/selinux-testsuite + systemctl stop nfs-server + echo "NFS test $1 complete" + exit 0 +} + +# Required by nfs_filesystem/test +export NFS_TESTDIR=$TESTDIR +export NFS_MOUNT=$MOUNT +# systemctl start nfs-server -# Run the full testsuite on a labeled NFS mount. +# Run the testsuite on a labeled NFS mount. exportfs -orw,no_root_squash,security_label localhost:$MOUNT mkdir -p /mnt/selinux-testsuite +# +if [ $RUN_TEST ] && [ $RUN_TEST = 'nfs_filesystem' ]; then + run_test $RUN_TEST $V +fi +# +echo "Run selinux-testsuite with no NFS mount context options" mount -t nfs -o vers=4.2 localhost:$TESTDIR /mnt/selinux-testsuite -pushd /mnt/selinux-testsuite -MAKE_TEST=1 -make test -MAKE_TEST=0 -popd -umount /mnt/selinux-testsuite - -# Test context mounts when exported with security_label. -mount -t nfs -o vers=4.2,context=system_u:object_r:etc_t:s0 localhost:$TESTDIR /mnt/selinux-testsuite -echo "Testing context mount of a security_label export." -fctx=`secon -t -f /mnt/selinux-testsuite` -if [ "$fctx" != "etc_t" ]; then - echo "Context mount failed: got $fctx instead of etc_t." - err_exit $LINENO +pushd /mnt/selinux-testsuite >/dev/null 2>&1 +POPD=1 +if [ $RUN_TEST ]; then + run_test $RUN_TEST $V +else + make -C policy load + make -C tests test fi +POPD=0 +popd >/dev/null 2>&1 umount /mnt/selinux-testsuite -exportfs -u localhost:$MOUNT - -# Test context mounts when not exported with security_label. -exportfs -orw,no_root_squash localhost:$MOUNT -mount -t nfs -o vers=4.2,context=system_u:object_r:etc_t:s0 localhost:$TESTDIR /mnt/selinux-testsuite -echo "Testing context mount of a non-security_label export." -fctx=`secon -t -f /mnt/selinux-testsuite` -if [ "$fctx" != "etc_t" ]; then - echo "Context mount failed: got $fctx instead of etc_t." - err_exit $LINENO -fi +# +echo -e "Run 'filesystem' tests with mount context option:\n\t$FS_CTX" +mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite +pushd /mnt/selinux-testsuite >/dev/null 2>&1 +POPD=1 +cd tests +./nfsruntests.pl filesystem/test +cd ../ +POPD=0 +popd >/dev/null 2>&1 umount /mnt/selinux-testsuite - -# Test non-context mount when not exported with security_label. -mount -t nfs -o vers=4.2 localhost:$TESTDIR /mnt/selinux-testsuite -echo "Testing non-context mount of a non-security_label export." -fctx=`secon -t -f /mnt/selinux-testsuite` -if [ "$fctx" != "nfs_t" ]; then - echo "Context mount failed: got $fctx instead of nfs_t." - err_exit $LINENO -fi +# +echo -e "Run 'fs_filesystem' tests with mount context option:\n\t$FS_CTX" +mount -t nfs -o vers=4.2,$FS_CTX localhost:$TESTDIR /mnt/selinux-testsuite +pushd /mnt/selinux-testsuite >/dev/null 2>&1 +POPD=1 +cd tests +./nfsruntests.pl fs_filesystem/test +cd ../ +POPD=0 +popd >/dev/null 2>&1 umount /mnt/selinux-testsuite - -# All done. -echo "Done" +# +echo "Run NFS context specific tests" +cd tests +./nfsruntests.pl nfs_filesystem/test +cd ../ +# +echo "NFS tests successfully completed" +make -C policy unload exportfs -u localhost:$MOUNT -rmdir /mnt/selinux-testsuite +rm -rf /mnt/selinux-testsuite systemctl stop nfs-server

[RFC,V3,1/2] selinux-testsuite: Use native filesystem for tests - Part 1

Commit Message

Patch