diff mbox series

[v2] README: update kernel-devel package in dnf command

Message ID 20200515210154.23408-1-william.c.roberts@intel.com (mailing list archive)
State Changes Requested
Headers show
Series [v2] README: update kernel-devel package in dnf command | expand

Commit Message

Roberts, William C May 15, 2020, 9:01 p.m. UTC
From: William Roberts <william.c.roberts@intel.com>

The README.md file in the selinux-testsuite states that kernel-devel
package is needed. However, for everything to work you need the
kernel-devel package specific to your kernel version.
Update the dnf command to include uname -r, so that a copy + paste
of the dnf command, results in a system with dependencies filled
for recent Fedora distro's like Fedora 32.

Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Moore May 15, 2020, 9:06 p.m. UTC | #1
On Fri, May 15, 2020 at 5:02 PM <william.c.roberts@intel.com> wrote:
>
> From: William Roberts <william.c.roberts@intel.com>
>
> The README.md file in the selinux-testsuite states that kernel-devel
> package is needed. However, for everything to work you need the
> kernel-devel package specific to your kernel version.
> Update the dnf command to include uname -r, so that a copy + paste
> of the dnf command, results in a system with dependencies filled
> for recent Fedora distro's like Fedora 32.
>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>
> ---
>  README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index 1f7e5d92a100..4d5d6d22203a 100644
> --- a/README.md
> +++ b/README.md
> @@ -74,7 +74,7 @@ following command:
>                 attr \
>                 libbpf-devel \
>                 keyutils-libs-devel \
> -               kernel-devel \
> +               kernel-devel-$(uname -r)

I \
think \
you \
forgot \
the \
trailing \
slash \

>                 quota \
>                 xfsprogs-devel \
>                 libuuid-devel
> --
> 2.17.1
William Roberts May 15, 2020, 9:20 p.m. UTC | #2
On Fri, May 15, 2020 at 4:09 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Fri, May 15, 2020 at 5:02 PM <william.c.roberts@intel.com> wrote:
> >
> > From: William Roberts <william.c.roberts@intel.com>
> >
> > The README.md file in the selinux-testsuite states that kernel-devel
> > package is needed. However, for everything to work you need the
> > kernel-devel package specific to your kernel version.
> > Update the dnf command to include uname -r, so that a copy + paste
> > of the dnf command, results in a system with dependencies filled
> > for recent Fedora distro's like Fedora 32.
> >
> > Signed-off-by: William Roberts <william.c.roberts@intel.com>
> > ---
> >  README.md | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.md b/README.md
> > index 1f7e5d92a100..4d5d6d22203a 100644
> > --- a/README.md
> > +++ b/README.md
> > @@ -74,7 +74,7 @@ following command:
> >                 attr \
> >                 libbpf-devel \
> >                 keyutils-libs-devel \
> > -               kernel-devel \
> > +               kernel-devel-$(uname -r)
>
> I \
> think \
> you \
> forgot \
> the \
> trailing \
> slash \

fsck \

>
> >                 quota \
> >                 xfsprogs-devel \
> >                 libuuid-devel
> > --
> > 2.17.1
>
> --
> paul moore
> www.paul-moore.com
diff mbox series

Patch

diff --git a/README.md b/README.md
index 1f7e5d92a100..4d5d6d22203a 100644
--- a/README.md
+++ b/README.md
@@ -74,7 +74,7 @@  following command:
 		attr \
 		libbpf-devel \
 		keyutils-libs-devel \
-		kernel-devel \
+		kernel-devel-$(uname -r)
 		quota \
 		xfsprogs-devel \
 		libuuid-devel