| Message ID | 20201009130052.52409-7-plautrba@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/6] libsepol: Get rid of the old and duplicated symbols | expand |
On Fri, Oct 9, 2020 at 9:48 AM Petr Lautrbach <plautrba@redhat.com> wrote: > > Previous commits removed some symbols and broke ABI, therefore we need to change > SONAME. > > See the following quotes from distribution guidelines: > > https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#run-time-shared-libraries > > Every time the shared library ABI changes in a way that may break > binaries linked against older versions of the shared library, the SONAME > of the library and the corresponding name for the binary package > containing the runtime shared library should change. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning > > When new versions of the library are released, you should use an ABI > comparison tool to check for ABI differences in the built shared > libraries. If it detects any incompatibilities, bump the n number by > one. > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> Acked-by: James Carter <jwcart2@gmail.com> > --- > libsemanage/src/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libsemanage/src/Makefile b/libsemanage/src/Makefile > index a0eb3747d74b..ab6cae51f5c3 100644 > --- a/libsemanage/src/Makefile > +++ b/libsemanage/src/Makefile > @@ -32,7 +32,7 @@ YACC = bison > YFLAGS = -d > > VERSION = $(shell cat ../VERSION) > -LIBVERSION = 1 > +LIBVERSION = 2 > > LIBA=libsemanage.a > TARGET=libsemanage.so > -- > 2.28.0 >
diff --git a/libsemanage/src/Makefile b/libsemanage/src/Makefile index a0eb3747d74b..ab6cae51f5c3 100644 --- a/libsemanage/src/Makefile +++ b/libsemanage/src/Makefile @@ -32,7 +32,7 @@ YACC = bison YFLAGS = -d VERSION = $(shell cat ../VERSION) -LIBVERSION = 1 +LIBVERSION = 2 LIBA=libsemanage.a TARGET=libsemanage.so
Previous commits removed some symbols and broke ABI, therefore we need to change SONAME. See the following quotes from distribution guidelines: https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#run-time-shared-libraries Every time the shared library ABI changes in a way that may break binaries linked against older versions of the shared library, the SONAME of the library and the corresponding name for the binary package containing the runtime shared library should change. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning When new versions of the library are released, you should use an ABI comparison tool to check for ABI differences in the built shared libraries. If it detects any incompatibilities, bump the n number by one. Signed-off-by: Petr Lautrbach <plautrba@redhat.com> --- libsemanage/src/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)