| Message ID | 20220125141422.32655-7-cgzones@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Paul Moore |
| Headers | show |
| Series | [1/9] selinux: check return value of sel_make_avc_files | expand |
On Tue, Jan 25, 2022 at 9:15 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > The parameter of selinux_cred() is declared const, so an explicit cast > dropping the const qualifier is not necessary. Without the cast the > local variable cred serves no purpose. > > Reported by clang [-Wcast-qual] > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/hooks.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Merged, thanks.
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 5b6895e4fc29..a840c8c1ec35 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -211,10 +211,9 @@ static int selinux_lsm_notifier_avc_callback(u32 event) */ static void cred_init_security(void) { - struct cred *cred = (struct cred *) current->real_cred; struct task_security_struct *tsec; - tsec = selinux_cred(cred); + tsec = selinux_cred(current->real_cred); tsec->osid = tsec->sid = SECINITSID_KERNEL; }
The parameter of selinux_cred() is declared const, so an explicit cast dropping the const qualifier is not necessary. Without the cast the local variable cred serves no purpose. Reported by clang [-Wcast-qual] Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- security/selinux/hooks.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)