diff mbox series

policycoreutils/setfiles: Improve description of -d switch

Message ID 20220401112730.108257-1-plautrba@redhat.com (mailing list archive)
State Superseded
Headers show
Series policycoreutils/setfiles: Improve description of -d switch | expand

Commit Message

Petr Lautrbach April 1, 2022, 11:27 a.m. UTC
From: Vit Mojzis <vmojzis@redhat.com>

The "-q" switch is becoming obsolete (completely unused in fedora) and
debug output ("-d" switch) makes sense in any scenario. Therefore both
options can be specified at once.

Resolves: rhbz#1271327

Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
---
 policycoreutils/setfiles/setfiles.8 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Carter April 4, 2022, 2:53 p.m. UTC | #1
On Fri, Apr 1, 2022 at 9:45 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> From: Vit Mojzis <vmojzis@redhat.com>
>
> The "-q" switch is becoming obsolete (completely unused in fedora) and
> debug output ("-d" switch) makes sense in any scenario. Therefore both
> options can be specified at once.
>
> Resolves: rhbz#1271327
>
> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
> ---
>  policycoreutils/setfiles/setfiles.8 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
> index 15f939d1bee0..0aab2aa24681 100644
> --- a/policycoreutils/setfiles/setfiles.8
> +++ b/policycoreutils/setfiles/setfiles.8
> @@ -59,7 +59,7 @@ option will force a replacement of the entire context.
>  check the validity of the contexts against the specified binary policy.
>  .TP
>  .B \-d
> -show what specification matched each file.
> +show what specification matched each file. Not affected by "\-q".
>  .TP
>  .BI \-e \ directory
>  directory to exclude (repeat option for more than one directory).
> --
> 2.35.1
>

Looking at setfiles.c, specifying "-q" doesn't do anything at all, so
it makes more sense to me to change what it says for "-q".

Maybe:
Deprecated and replaced by "-v". Has no effect on other options or on
program behavior.

Jim
diff mbox series

Patch

diff --git a/policycoreutils/setfiles/setfiles.8 b/policycoreutils/setfiles/setfiles.8
index 15f939d1bee0..0aab2aa24681 100644
--- a/policycoreutils/setfiles/setfiles.8
+++ b/policycoreutils/setfiles/setfiles.8
@@ -59,7 +59,7 @@  option will force a replacement of the entire context.
 check the validity of the contexts against the specified binary policy.
 .TP
 .B \-d
-show what specification matched each file.
+show what specification matched each file. Not affected by "\-q".
 .TP
 .BI \-e \ directory
 directory to exclude (repeat option for more than one directory).