| Message ID | 20230814132025.45364-23-cgzones@googlemail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dcb8e1bfbbb2 |
| Delegated to: | Petr Lautrbach |
| Headers | show |
| Series | libselinux: rework selabel_file(5) database | expand |
On Mon, Aug 14, 2023 at 9:42 AM Christian Göttsche <cgzones@googlemail.com> wrote: > > selabel_get_digest_all_partial_matches is dynamically linked against > libselinux, so it should not depend on any internals and thus do not > make use of an internal header file > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> Acked-by: James Carter <jwcart2@gmail.com> > --- > libselinux/utils/selabel_get_digests_all_partial_matches.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libselinux/utils/selabel_get_digests_all_partial_matches.c b/libselinux/utils/selabel_get_digests_all_partial_matches.c > index c4e0f836..e2733b41 100644 > --- a/libselinux/utils/selabel_get_digests_all_partial_matches.c > +++ b/libselinux/utils/selabel_get_digests_all_partial_matches.c > @@ -8,8 +8,6 @@ > #include <selinux/selinux.h> > #include <selinux/label.h> > > -#include "../src/label_file.h" > - > static __attribute__ ((__noreturn__)) void usage(const char *progname) > { > fprintf(stderr, > -- > 2.40.1 >
On Wed, Oct 11, 2023 at 2:49 PM James Carter <jwcart2@gmail.com> wrote: > > On Mon, Aug 14, 2023 at 9:42 AM Christian Göttsche > <cgzones@googlemail.com> wrote: > > > > selabel_get_digest_all_partial_matches is dynamically linked against > > libselinux, so it should not depend on any internals and thus do not > > make use of an internal header file > > > > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > > Acked-by: James Carter <jwcart2@gmail.com> > Merged. Thanks, Jim > > --- > > libselinux/utils/selabel_get_digests_all_partial_matches.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/libselinux/utils/selabel_get_digests_all_partial_matches.c b/libselinux/utils/selabel_get_digests_all_partial_matches.c > > index c4e0f836..e2733b41 100644 > > --- a/libselinux/utils/selabel_get_digests_all_partial_matches.c > > +++ b/libselinux/utils/selabel_get_digests_all_partial_matches.c > > @@ -8,8 +8,6 @@ > > #include <selinux/selinux.h> > > #include <selinux/label.h> > > > > -#include "../src/label_file.h" > > - > > static __attribute__ ((__noreturn__)) void usage(const char *progname) > > { > > fprintf(stderr, > > -- > > 2.40.1 > >
diff --git a/libselinux/utils/selabel_get_digests_all_partial_matches.c b/libselinux/utils/selabel_get_digests_all_partial_matches.c index c4e0f836..e2733b41 100644 --- a/libselinux/utils/selabel_get_digests_all_partial_matches.c +++ b/libselinux/utils/selabel_get_digests_all_partial_matches.c @@ -8,8 +8,6 @@ #include <selinux/selinux.h> #include <selinux/label.h> -#include "../src/label_file.h" - static __attribute__ ((__noreturn__)) void usage(const char *progname) { fprintf(stderr,
selabel_get_digest_all_partial_matches is dynamically linked against libselinux, so it should not depend on any internals and thus do not make use of an internal header file Signed-off-by: Christian Göttsche <cgzones@googlemail.com> --- libselinux/utils/selabel_get_digests_all_partial_matches.c | 2 -- 1 file changed, 2 deletions(-)