mbox series

[v3,0/2] spi: realtek-rtl: two small improvements

Message ID 20220731202152.1358252-1-martin.blumenstingl@googlemail.com (mailing list archive)
Headers show
Series spi: realtek-rtl: two small improvements | expand

Message

Martin Blumenstingl July 31, 2022, 8:21 p.m. UTC
This is a successor to my single patch [0] "spi: realtek-rtl: Fix
clearing some register bits"

Changes since v2 at [1]:
- Added Sander's Tested-by to the second patch (thank you!)
- Dropped HAS_IOMEM dependency as this is already implied by CONFIG_SPI
  (thanks Sander for spotting this!)
- Extended Kconfig help text with the module name to make the Realtek
  driver consistent with others. Thanks to Sander for the suggestion!

Changes since v1 at [0]:
- Added new patch to enable compile testing for the spi-realtek-rtl
  driver. This makes it easier to verify coding style changes (such as
  patch #2 in this series) where the binary result is not supposed to
  change.
- Updated the original patch to drop the RTL_SPI_SFCSR_CS change as
  it's not fully clear why that code is written as-is (and due to
  lack of hardware I am unable to runtime test the changes). Also
  move the ~ operator from the RTL_SPI_SFCSR_LEN_MASK definition to
  the place where it's used. Thanks to Sander for spotting the mistake
  in my initial patch!


[0] https://lore.kernel.org/lkml/78673dc7438a03bf9ed0103a935abf0172f146ce.camel@svanheule.net/T/
[1] https://lore.kernel.org/linux-spi/20220728152118.1429161-1-martin.blumenstingl@googlemail.com/T/


Martin Blumenstingl (2):
  spi: realtek-rtl: Add compile testing support
  spi: realtek-rtl: Improve readability when clearing the size mask

 drivers/spi/Kconfig           | 11 +++++++++++
 drivers/spi/Makefile          |  2 +-
 drivers/spi/spi-realtek-rtl.c |  4 ++--
 3 files changed, 14 insertions(+), 3 deletions(-)