| Message ID | 20230130030656.12127-1-xiangsheng.hou@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add MediaTek MT7986 SPI NAND and ECC support | expand |
Hi Xiangsheng, xiangsheng.hou@mediatek.com wrote on Mon, 30 Jan 2023 11:06:46 +0800: > This patch series add MediaTek MT7986 SPI NAND and ECC controller > support, split ECC engine with rawnand controller in bindings and > change to YAML schema. I would like to pick-up patches 3, 7 and 10 and apply them in the mtd tree as they look completely orthogonal with all the other (spi/DT) changes, am I right? Mark, is it okay for you? Thanks, Miquèl > > Changes since V4: > - Split arm and arm64 dts patch for fix existing NAND controller node name. > > Changes since V3: > - Correct mediatek,mtk-nfc.yaml dt-bindings. > > Changes since V2: > - Change ECC err_mask value with GENMASK macro. > - Change snfi mediatek,rx-latch-latency to mediatek,rx-latch-latency-ns. > - Add a separate patch for DTS change. > - Move common description to top-level pattern properties. > - Drop redundant parts in dt-bindings. > > Changes since V1: > - Use existing sample delay property. > - Add restricting for optional nfi_hclk. > - Improve and perfect dt-bindings documentation. > - Change existing node name to match NAND controller DT bingings. > - Fix issues reported by dt_binding_check. > - Fix issues reported by dtbs_check. > > Xiangsheng Hou (10): > spi: mtk-snfi: Change default page format to setup default setting > spi: mtk-snfi: Add optional nfi_hclk which is needed for MT7986 > mtd: nand: ecc-mtk: Add ECC support fot MT7986 IC > dt-bindings: spi: mtk-snfi: Add compatible for MT7986 > spi: mtk-snfi: Add snfi sample delay and read latency adjustment > dt-bindings: spi: mtk-snfi: Add read latch latency property > dt-bindings: mtd: Split ECC engine with rawnand controller > arm64: dts: mediatek: Fix existing NAND controller node name > arm: dts: mediatek: Fix existing NAND controller node name > dt-bindings: mtd: mediatek,nand-ecc-engine: Add compatible for MT7986 > > .../bindings/mtd/mediatek,mtk-nfc.yaml | 155 +++++++++++++++ > .../mtd/mediatek,nand-ecc-engine.yaml | 63 +++++++ > .../devicetree/bindings/mtd/mtk-nand.txt | 176 ------------------ > .../bindings/spi/mediatek,spi-mtk-snfi.yaml | 54 +++++- > arch/arm/boot/dts/mt2701.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 2 +- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +- > drivers/mtd/nand/ecc-mtk.c | 28 ++- > drivers/spi/spi-mtk-snfi.c | 41 +++- > 9 files changed, 330 insertions(+), 193 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/mediatek,mtk-nfc.yaml > create mode 100644 Documentation/devicetree/bindings/mtd/mediatek,nand-ecc-engine.yaml > delete mode 100644 Documentation/devicetree/bindings/mtd/mtk-nand.txt >
On Mon, Jan 30, 2023 at 05:11:45PM +0100, Miquel Raynal wrote: > xiangsheng.hou@mediatek.com wrote on Mon, 30 Jan 2023 11:06:46 +0800: > > This patch series add MediaTek MT7986 SPI NAND and ECC controller > > support, split ECC engine with rawnand controller in bindings and > > change to YAML schema. > I would like to pick-up patches 3, 7 and 10 and apply them in the mtd > tree as they look completely orthogonal with all the other (spi/DT) > changes, am I right? > Mark, is it okay for you? That's fine, assuming there's no dependency issues. Xiangsheng, it's generally best to avoid mixing patches for multiple subsystems into a single series when it's not needed since it makes merging things more complex.
Hi Xiangsheng, broonie@kernel.org wrote on Mon, 30 Jan 2023 16:18:56 +0000: > On Mon, Jan 30, 2023 at 05:11:45PM +0100, Miquel Raynal wrote: > > xiangsheng.hou@mediatek.com wrote on Mon, 30 Jan 2023 11:06:46 +0800: > > > > This patch series add MediaTek MT7986 SPI NAND and ECC controller > > > support, split ECC engine with rawnand controller in bindings and > > > change to YAML schema. > > > I would like to pick-up patches 3, 7 and 10 and apply them in the mtd > > tree as they look completely orthogonal with all the other (spi/DT) > > changes, am I right? > > > Mark, is it okay for you? > > That's fine, assuming there's no dependency issues. Xiangsheng, it's > generally best to avoid mixing patches for multiple subsystems into a > single series when it's not needed since it makes merging things more > complex. Well, kernel test robot just reported an issue with a wrong file name, so let's split the series. I now expect a series with the spi and relevant changes (for Mark) and another series with the three mtd patches -fixed, of course- which I'll apply on my side. Thanks, Miquèl
Hi Miquel, On Mon, 2023-01-30 at 17:33 +0100, Miquel Raynal wrote: > Hi Xiangsheng, > > broonie@kernel.org wrote on Mon, 30 Jan 2023 16:18:56 +0000: > > > On Mon, Jan 30, 2023 at 05:11:45PM +0100, Miquel Raynal wrote: > > > xiangsheng.hou@mediatek.com wrote on Mon, 30 Jan 2023 11:06:46 > > > +0800: > > > > This patch series add MediaTek MT7986 SPI NAND and ECC > > > > controller > > > > support, split ECC engine with rawnand controller in bindings > > > > and > > > > change to YAML schema. > > > I would like to pick-up patches 3, 7 and 10 and apply them in the > > > mtd > > > tree as they look completely orthogonal with all the other > > > (spi/DT) > > > changes, am I right? > > > Mark, is it okay for you? > > > > That's fine, assuming there's no dependency issues. Xiangsheng, > > it's > > generally best to avoid mixing patches for multiple subsystems into > > a > > single series when it's not needed since it makes merging things > > more > > complex. > > Well, kernel test robot just reported an issue with a wrong file > name, > so let's split the series. I now expect a series with the spi and > relevant changes (for Mark) and another series with the three mtd > patches -fixed, of course- which I'll apply on my side. I will pick-up patches 3, 7, 10 and 8, 9 as a series for you, since patches 8, 9 change the existing NAND controller node name. And another patches as a series for Mark. Thanks Xiangsheng Hou