From patchwork Thu Mar 23 17:30:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 13185915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786C6C76196 for ; Thu, 23 Mar 2023 17:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjCWRbT (ORCPT ); Thu, 23 Mar 2023 13:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231556AbjCWRbS (ORCPT ); Thu, 23 Mar 2023 13:31:18 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFC222B9D8 for ; Thu, 23 Mar 2023 10:31:08 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id q23so7916719pfs.2 for ; Thu, 23 Mar 2023 10:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679592668; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wNlWMVOfIBJ5sYCGk8cV0F2Gur6V9aihLXHyK/3m6GA=; b=D1RO0Cz6QFWcPTByVwzHxkejA8/LZKJHXqOZ52+1fJ13P+NhalK/oDMzGRpbyvCpSo uTvXg9zRZarU4aMWWUX/LajFQET4gAUxlsx714/9xguyX2PZIIwrdEQkNw+Py97QDJ8w KHoes0QMnx09cpXmq5K0lMxqq02IAF2kNq9ZU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679592668; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wNlWMVOfIBJ5sYCGk8cV0F2Gur6V9aihLXHyK/3m6GA=; b=LEOkGYscr+8PcLHRfglWy/TIvZtCAccyVAtWSiSEq6I4vq+9zIg0mvFDJte4+Iri9u KkvyZ8/csqrDcckQrvjmNK5uPmIJSyPbmtwewSjtV4k1iwkk86+d//QCEwJbx9CTwrsL B1FMMEy2Mn96IugeXzUqvMFD9AWRVO/yuGqTdBZJ7tZKGcT+Nv9cotaN0y0dc+e2xKXf IEiPMK/suPfDJD7CTmLqRicd2+lJrzgu7OYiIkCQZtfwWM1vrgXbr/pzFXMp5bGpP55q ONsRDL2JxK6QylsXSJQKYVPAWng7QfI+tuXy8NlRJnfw5/HFAl0G4taU4TN4k4PPQbI+ bmIg== X-Gm-Message-State: AAQBX9cwbYTlaJArz6Wh0W0vcboOZx5RmJ9XTtScUuEkmi840r5v2AEF arL9UFUa4nVhKBeNvmmDjwytK0D8inbYOLXHz1U= X-Google-Smtp-Source: AKy350aVBE8amoEnujDOw4ZJ3MN4p91l6YRmGHGGL84SD74zqJPXm29xNcOOhDNThqjqrWETQpaaPQ== X-Received: by 2002:a62:1d85:0:b0:62a:4503:53b8 with SMTP id d127-20020a621d85000000b0062a450353b8mr248927pfd.1.1679592667856; Thu, 23 Mar 2023 10:31:07 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16d3:ef20:206a:6521]) by smtp.gmail.com with ESMTPSA id x13-20020a62fb0d000000b0061a6f4c1b2bsm12613546pfm.171.2023.03.23.10.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 10:31:07 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Mark Brown , Linus Walleij Cc: Matthias Kaehlcke , Konrad Dybcio , linux-gpio@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, Douglas Anderson , Andy Gross , Rajendra Nayak , Rajesh Patil , Roja Rani Yarubandi , linux-kernel@vger.kernel.org Subject: [PATCH 00/14] Control Quad SPI pinctrl better on Qualcomm Chromebooks Date: Thu, 23 Mar 2023 10:30:04 -0700 Message-Id: <20230323173019.3706069-1-dianders@chromium.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org The main goal of this series is to do a better job of controling the pins related to the "Quad SPI" IP block on Qualcomm Chromebooks. This is essentially 'v2' of my previous attempt in the patch ("arm64: dts: qcom: sc7180: Fix trogdor qspi pull direction") [1] but since it's spiraled out a bit and there are no patches that are exactly the same I've reset to v1. The early patches in this series are just no-op cleanup patches that can be applied. They're not terribly critical but since they are "Fixes" I've listed them first. The next patch in the series is a very simple and (hopefully) non-controversial SPI patch. It can be applied independently if anything else. Next, we have a bunch of pinctrl patches (including the device tree bindings related to them). I dunno what folks are going to think about these. If everyone hates them, we can drop them and just change the later patches in the series to use "input-enable" instead of "output-disable". It feels ugly to me, but it maybe less upheval. Next I removed the now-deprecated "input-enable" property from all Chromebooks. None of them were necessary. Finally, I did what I really wanted to do in the first place: attempt to cleanup the pinctrl states of the Quad SPI. These patches have a hard requirement on the pinctrl change. [1] https://lore.kernel.org/r/20230213165743.1.I6f03f86546e6ce9abb1d24fd9ece663c3a5b950c@changeid Douglas Anderson (14): arm64: dts: sc7180: Rename qspi data12 as data23 arm64: dts: sc7280: Rename qspi data12 as data23 arm64: dts: sdm845: Rename qspi data12 as data23 arm64: dts: qcom: sc7180: Annotate l13a on trogdor to always-on spi: spi-qcom-qspi: Support pinctrl sleep states dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable dt-bindings: pinctrl: qcom: Add output-enable pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE arm64: dts: qcom: sc7180: Remove superfluous "input-enable"s from trogdor arm64: dts: qcom: sc7280: Remove superfluous "input-enable"s from idp-ec-h1 arm64: dts: qcom: sdm845: Remove superfluous "input-enable"s from cheza arm64: dts: qcom: sc7180: Fix trogdor qspi pin config arm64: dts: qcom: sc7280: Fix qspi pin config arm64: dts: qcom: sdm845: Fix cheza qspi pin config .../bindings/pinctrl/qcom,tlmm-common.yaml | 4 +- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 9 ++-- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 41 +++++++++++++------ arch/arm64/boot/dts/qcom/sc7180.dtsi | 11 +++-- .../boot/dts/qcom/sc7280-chrome-common.dtsi | 25 ++++++++++- .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++--- .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi | 2 - arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 13 +++--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 11 +++-- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 37 ++++++++++++----- arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++-- drivers/pinctrl/qcom/pinctrl-msm.c | 36 +++++++++++++--- drivers/spi/spi-qcom-qspi.c | 5 +++ 13 files changed, 165 insertions(+), 54 deletions(-) Acked-by: Linus Walleij