| Message ID | 20230511231317.158214-1-bstruempfel@ultratronik.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: Add option to keep the MOSI line low, when it is idle | expand |
On Fri, May 12, 2023 at 01:13:13AM +0200, Boerge Struempfel wrote: > Some spi controller like the imx spi controller switch the mosi line to > high, whenever they are idle. This may not be desired in all use cases. > For example neopixel leds can get confused and flicker due to > misinterpreting the idle state. Therefore, we introduce a new spi-mode > bit, with which the idle behaviour can be overwritten on a per device > basis. Please don't send new patches in reply to old patches or serieses, this makes it harder for both people and tools to understand what is going on - it can bury things in mailboxes and make it difficult to keep track of what current patches are, both for the new patches and the old ones.
Some spi controller like the imx spi controller switch the mosi line to high, whenever they are idle. This may not be desired in all use cases. For example neopixel leds can get confused and flicker due to misinterpreting the idle state. Therefore, we introduce a new spi-mode bit, with which the idle behaviour can be overwritten on a per device basis. Changes from V1: - Added patch, introducing the new devicetree binding flag - Split the generic spi part of the patch from the imx-spi specific part - Replaced SPI_CPOL and SPI_CPHA by the combined SPI_MODE_X_MASK bit in the imx-spi.c modebits. - Added the SPI_MOSI_IDLE_LOW bit to spidev Boerge Struempfel (4): spi: dt-bindings: Introduce spi-mosi-idle-low flag spi: add SPI_MOSI_IDLE_LOW mode bit spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit spi: spidev: add SPI_MOSI_IDLE_LOW mode bit .../devicetree/bindings/spi/spi-peripheral-props.yaml | 6 ++++++ drivers/spi/spi-imx.c | 9 ++++++++- drivers/spi/spi.c | 2 ++ drivers/spi/spidev.c | 2 +- include/uapi/linux/spi/spi.h | 3 ++- 5 files changed, 19 insertions(+), 3 deletions(-)