| Message ID | 20231204-axi-spi-engine-series-2-v1-0-063672323fce@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: axi-spi-engine: improvements round 2 | expand |
On Mon, 2023-12-04 at 11:33 -0600, David Lechner wrote: > We are working towards adding support for the offload feature [1] of the > AXI SPI Engine IP core. Before we can do that, we want to make some > general fixes and improvements to the driver. In order to avoid a giant > series with 35+ patches, we are splitting this up into a few smaller > series. > > This is a continuation of the work started in [2] which has been applied > to spi/for-6.8 [3]. This series must be applied on top of that series to > apply cleanly. > > Once this series is applied, we will follow up with the 3rd series that > implements the offload support. The offload support will also involve > the IIO subsystem (a new IIO driver will depend on the new SPI offload > feature), so I'm mentioning this now in case we want to do anything > ahead of time to prepare for that (e.g. putting all of these changes on > a separate branch). > > [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload > [2]: > https://lore.kernel.org/linux-spi/20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/ > [3]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-6.8 > > --- Acked-by: Nuno Sa <nuno.sa@analog.com> > David Lechner (9): > spi: axi-spi-engine: return void from spi_engine_compile_message() > spi: axi-spi-engine: populate xfer->effective_speed_hz > spi: axi-spi-engine: remove spi_engine_get_clk_div() > spi: axi-spi-engine: fix sleep ticks calculation > spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() > spi: axi-spi-engine: implement xfer->cs_change_delay > spi: axi-spi-engine: restore clkdiv at end of message > spi: axi-spi-engine: remove delay from CS assertion > spi: axi-spi-engine: add watchdog timer > > drivers/spi/spi-axi-spi-engine.c | 116 ++++++++++++++++++++++++++------------- > 1 file changed, 77 insertions(+), 39 deletions(-) > --- > base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 > change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0
> -----Original Message----- > From: Nuno Sá <noname.nuno@gmail.com> > Sent: Dienstag, 5. Dezember 2023 16:12 > To: David Lechner <dlechner@baylibre.com>; linux-spi@vger.kernel.org > Cc: Mark Brown <broonie@kernel.org>; Hennerich, Michael > <Michael.Hennerich@analog.com>; Sa, Nuno <Nuno.Sa@analog.com>; linux- > kernel@vger.kernel.org; Lars-Peter Clausen <lars@metafoo.de> > Subject: Re: [PATCH 0/9] spi: axi-spi-engine: improvements round 2 > > > On Mon, 2023-12-04 at 11:33 -0600, David Lechner wrote: > > We are working towards adding support for the offload feature [1] of > > the AXI SPI Engine IP core. Before we can do that, we want to make > > some general fixes and improvements to the driver. In order to avoid a > > giant series with 35+ patches, we are splitting this up into a few > > smaller series. > > > > This is a continuation of the work started in [2] which has been > > applied to spi/for-6.8 [3]. This series must be applied on top of that > > series to apply cleanly. > > > > Once this series is applied, we will follow up with the 3rd series > > that implements the offload support. The offload support will also > > involve the IIO subsystem (a new IIO driver will depend on the new SPI > > offload feature), so I'm mentioning this now in case we want to do > > anything ahead of time to prepare for that (e.g. putting all of these > > changes on a separate branch). > > > > [1]: > > https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload > > [2]: > > https://urldefense.com/v3/__https://lore.kernel.org/linux-spi/20231117 > > -axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/__;!!A3Ni8CS0y > > > 2Y!4P8x0PlUachyveotKnjDl76l9lcBm5HvGgZVXAfsa26fHvTXZ7Cvmq2lt_ZPP58 > nPhJ > > K_sGO56g48deUWlcDSsY8qg$ > > [3]: > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kerne > > l/git/broonie/spi.git/log/?h=for-6.8__;!!A3Ni8CS0y2Y!4P8x0PlUachyveotK > > > njDl76l9lcBm5HvGgZVXAfsa26fHvTXZ7Cvmq2lt_ZPP58nPhJK_sGO56g48deU > Wlfwzsn > > PJw$ > > > > --- > > Acked-by: Nuno Sa <nuno.sa@analog.com> Acked-by: Michael Hennerich <michael.hennerich@analog.com> > > > David Lechner (9): > > spi: axi-spi-engine: return void from > > spi_engine_compile_message() > > spi: axi-spi-engine: populate xfer->effective_speed_hz > > spi: axi-spi-engine: remove spi_engine_get_clk_div() > > spi: axi-spi-engine: fix sleep ticks calculation > > spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() > > spi: axi-spi-engine: implement xfer->cs_change_delay > > spi: axi-spi-engine: restore clkdiv at end of message > > spi: axi-spi-engine: remove delay from CS assertion > > spi: axi-spi-engine: add watchdog timer > > > > drivers/spi/spi-axi-spi-engine.c | 116 > > ++++++++++++++++++++++++++------------- > > 1 file changed, 77 insertions(+), 39 deletions(-) > > --- > > base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 > > change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0
On Mon, 04 Dec 2023 11:33:26 -0600, David Lechner wrote: > We are working towards adding support for the offload feature [1] of the > AXI SPI Engine IP core. Before we can do that, we want to make some > general fixes and improvements to the driver. In order to avoid a giant > series with 35+ patches, we are splitting this up into a few smaller > series. > > This is a continuation of the work started in [2] which has been applied > to spi/for-6.8 [3]. This series must be applied on top of that series to > apply cleanly. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/9] spi: axi-spi-engine: return void from spi_engine_compile_message() commit: 2e0d75f8dd9e31b3fb175f780494dd7dd988ceae [2/9] spi: axi-spi-engine: populate xfer->effective_speed_hz commit: 9d023ecc31859c7f7c8ca27b5fec52b2dbb8086f [3/9] spi: axi-spi-engine: remove spi_engine_get_clk_div() commit: 1fc8dc5721bbc7a21cb4cc60c35eb8031942542b [4/9] spi: axi-spi-engine: fix sleep ticks calculation commit: be9070bcf67057b7b03c5acc1980d3897448ad20 [5/9] spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() commit: e006c181dd9ab006d7b0982d35ef7951fbffe825 [6/9] spi: axi-spi-engine: implement xfer->cs_change_delay commit: 125a8390995df1a350e9e16e6da11d010e1e7f76 [7/9] spi: axi-spi-engine: restore clkdiv at end of message commit: 3106edac599f59e1298b034a19a43e7da002fccc [8/9] spi: axi-spi-engine: remove delay from CS assertion commit: 0db60d821e485a1c9b8080dbec1ba9871efb6a65 [9/9] spi: axi-spi-engine: add watchdog timer commit: 07d33c2810bb5fe67747d11f76980ed68602e287 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
We are working towards adding support for the offload feature [1] of the AXI SPI Engine IP core. Before we can do that, we want to make some general fixes and improvements to the driver. In order to avoid a giant series with 35+ patches, we are splitting this up into a few smaller series. This is a continuation of the work started in [2] which has been applied to spi/for-6.8 [3]. This series must be applied on top of that series to apply cleanly. Once this series is applied, we will follow up with the 3rd series that implements the offload support. The offload support will also involve the IIO subsystem (a new IIO driver will depend on the new SPI offload feature), so I'm mentioning this now in case we want to do anything ahead of time to prepare for that (e.g. putting all of these changes on a separate branch). [1]: https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload [2]: https://lore.kernel.org/linux-spi/20231117-axi-spi-engine-series-1-v1-0-cc59db999b87@baylibre.com/ [3]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/log/?h=for-6.8 --- David Lechner (9): spi: axi-spi-engine: return void from spi_engine_compile_message() spi: axi-spi-engine: populate xfer->effective_speed_hz spi: axi-spi-engine: remove spi_engine_get_clk_div() spi: axi-spi-engine: fix sleep ticks calculation spi: axi-spi-engine: remove xfer arg from spi_engine_gen_sleep() spi: axi-spi-engine: implement xfer->cs_change_delay spi: axi-spi-engine: restore clkdiv at end of message spi: axi-spi-engine: remove delay from CS assertion spi: axi-spi-engine: add watchdog timer drivers/spi/spi-axi-spi-engine.c | 116 ++++++++++++++++++++++++++------------- 1 file changed, 77 insertions(+), 39 deletions(-) --- base-commit: 8e6a43961f24cf841d3c0d199521d0b284d948b9 change-id: 20231129-axi-spi-engine-series-2-5f0a6053dea0