[v2,0/2] spi: tegra210-quad: Improve messages on pathological case

Message

Breno Leitao April 1, 2025, 1:47 p.m. UTC

I maintain several hosts with tegra210-quad controllers, some of which
experience data transmission failures. Debugging these issues has been
challenging due to excessive log messages from the driver.

Since these devices do not have a way to reset[1], then we want to avoid
warning and printing a bunch of messages, otherwise the host will
overflow the serial. Fix it by:

 1. Using WARN_ON_ONCE instead of WARN_ON to reduce stack trace spam
 2. Rate-limiting error messages and removing redundant information

These improvements maintain necessary error reporting while
significantly reducing log noise, making debugging of actual issues more
feasible.

Link: https://lore.kernel.org/all/q53apce4sltvnyd75j4o7taatocxiduq56fqsoxp3vrjmaqphk@o5kce2wb3dnz/ [1]

Signed-off-by: Breno Leitao <[e-mail]>
---
Changes in v2:
- Dropped patch 1, which is still being discussed. 
   * See https://lore.kernel.org/all/20250328-cinnamon-mushroom-of-proficiency-a17ba8@leitao/

- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Breno Leitao (2):
      spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
      spi: tegra210-quad: add rate limiting and simplify timeout error message

 drivers/spi/spi-tegra210-quad.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 4701f33a10702d5fc577c32434eb62adde0a1ae1
change-id: 20250317-tegra-1712e60604e6

Best regards,