From patchwork Tue Apr 29 08:19:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 4085951 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CA0F89F169 for ; Tue, 29 Apr 2014 08:23:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0AE6A201F2 for ; Tue, 29 Apr 2014 08:23:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21B6920155 for ; Tue, 29 Apr 2014 08:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756812AbaD2ITp (ORCPT ); Tue, 29 Apr 2014 04:19:45 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:43942 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755863AbaD2ITm (ORCPT ); Tue, 29 Apr 2014 04:19:42 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4S00BXL9SRWS70@mailout4.samsung.com> for linux-spi@vger.kernel.org; Tue, 29 Apr 2014 17:19:39 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 4E.66.11496.B906F535; Tue, 29 Apr 2014 17:19:39 +0900 (KST) X-AuditID: cbfee691-b7f3e6d000002ce8-8a-535f609b2fe8 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 7E.D7.25708.A906F535; Tue, 29 Apr 2014 17:19:39 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4S000JQ9SQSM00@mmp2.samsung.com>; Tue, 29 Apr 2014 17:19:38 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, 'Jingoo Han' , 'Mika Westerberg' References: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> In-reply-to: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> Subject: [PATCH 2/7] spi: pxa2xx: remove unnecessary OOM messages Date: Tue, 29 Apr 2014 17:19:38 +0900 Message-id: <002601cf6383$c36eae30$4a4c0a90$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9jg36HlbCqKDpQT3SMVWTyuXezSgAADCDA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFIsWRmVeSWpSXmKPExsVy+t8zI93ZCfHBBkfus1tMffiEzeLywkus Fo0fb7JbTNl+hN2BxWPTqk42j3knAz36tqxi9Pi8SS6AJYrLJiU1J7MstUjfLoErY37Da/aC dZwVb1f9ZW1gPMLexcjJISFgInFl628WCFtM4sK99WxdjFwcQgLLGCUeXdsAV3T+fQczRGI6 o0TX7i9Qzm9Gidbu6WDtbAJqEl++HAbq4OAQEVCV+P/KHSTMLFAhsePEN2aQsJCArUTL+1IQ k1PATmL2aVOQCmEBR4kPq5aDDWEBalzTuRjM5gWqnnL4FjOELSjxY/I9FoiJWhLrdx5ngrDl JTaveQs2XUJAXeLRX12QsIiAkcTvpkVQ5SIS+168YwQ5WELgFLvEjQk3GSF2CUh8m3yIBaJX VmLTAWaIbyUlDq64wTKBUWIWks2zkGyehWTzLCQrFjCyrGIUTS1ILihOSi8y1StOzC0uzUvX S87P3cQIiceJOxjvH7A+xJgMtH4is5Rocj4wnvNK4g2NzYwsTE1MjY3MLc1IE1YS501/lBQk JJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgXH6P4uPMkGsuzrTRB9q/ZQu+LP5ydvT/DOTvTVZ /733yHjU3/zRfcuun4+EhAzc509cl5NdyNqsveXjNbErd/JKD7zk9vrzTOlYjo32rmNsthmn b3A76ey5by+6tUS5tf/mj9b82F/HV3n9X/rr3uTOCyu5Hr15lPjtw7XHfVtPr7QJmW7sIbpA iaU4I9FQi7moOBEArrckKt0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsVy+t9jQd3ZCfHBBnubWCymPnzCZnF54SVW i8aPN9ktpmw/wu7A4rFpVSebx7yTgR59W1YxenzeJBfAEtXAaJORmpiSWqSQmpecn5KZl26r 5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtFJJoSwxpxQoFJBYXKykb4dpQmiIm64F TGOErm9IEFyPkQEaSFjHmDG/4TV7wTrOirer/rI2MB5h72Lk5JAQMJE4/76DGcIWk7hwbz1b FyMXh5DAdEaJrt1fmCGc34wSrd3TWUCq2ATUJL58OQzUzcEhIqAq8f+VO0iYWaBCYseJb8wg YSEBW4mW96UgJqeAncTs06YgFcICjhIfVi0HG8IC1LimczGYzQtUPeXwLWYIW1Dix+R7LBAT tSTW7zzOBGHLS2xe8xZsuoSAusSjv7ogYREBI4nfTYugykUk9r14xziBUWgWkkmzkEyahWTS LCQtCxhZVjGKphYkFxQnpeca6RUn5haX5qXrJefnbmIER/sz6R2MqxosDjEKcDAq8fB2xMQF C7EmlhVX5h5ilOBgVhLhzbeKDxbiTUmsrEotyo8vKs1JLT7EmAz06ERmKdHkfGAiyiuJNzQ2 MTOyNDKzMDIxNydNWEmc92CrdaCQQHpiSWp2ampBahHMFiYOTqkGRluhCD6lbX3PNtas/H/Z XeGF53HDNwt0o3IU72iYb/VRUNhgv2tf1UvrzU+3MadI1dzYskj08Jn1kqc33/CVPcm5KiTW d8UkntUfZTnvBaWdLNq+6nmSGJNJzdylBrPyp7tcippy5/2irUH2azWanG00uB/3z/E6wH00 0HXx5vS4iNee8/VPuSqxFGckGmoxFxUnAgA3LvjIOgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han --- drivers/spi/spi-pxa2xx.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index d0fc8e0..65df9b1 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -885,11 +885,8 @@ static int setup(struct spi_device *spi) chip = spi_get_ctldata(spi); if (!chip) { chip = kzalloc(sizeof(struct chip_data), GFP_KERNEL); - if (!chip) { - dev_err(&spi->dev, - "failed setup: can't allocate chip data\n"); + if (!chip) return -ENOMEM; - } if (drv_data->ssp_type == CE4100_SSP) { if (spi->chip_select > 4) { @@ -1036,11 +1033,8 @@ pxa2xx_spi_acpi_get_pdata(struct platform_device *pdev) return NULL; pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); - if (!pdata) { - dev_err(&pdev->dev, - "failed to allocate memory for platform data\n"); + if (!pdata) return NULL; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res)