From patchwork Tue Apr 29 08:20:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 4085891 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 53480BFF02 for ; Tue, 29 Apr 2014 08:23:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8AEDB201F2 for ; Tue, 29 Apr 2014 08:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C0B220155 for ; Tue, 29 Apr 2014 08:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757052AbaD2IU0 (ORCPT ); Tue, 29 Apr 2014 04:20:26 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:11301 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756574AbaD2IUW (ORCPT ); Tue, 29 Apr 2014 04:20:22 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4S000N19TXWJ50@mailout3.samsung.com> for linux-spi@vger.kernel.org; Tue, 29 Apr 2014 17:20:21 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id B9.53.18501.5C06F535; Tue, 29 Apr 2014 17:20:21 +0900 (KST) X-AuditID: cbfee68d-b7f4e6d000004845-b2-535f60c52fab Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B4.4E.27725.5C06F535; Tue, 29 Apr 2014 17:20:21 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4S008CG9TXXXB0@mmp1.samsung.com>; Tue, 29 Apr 2014 17:20:21 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, 'Jingoo Han' References: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> In-reply-to: <002401cf6383$7e9ce1f0$7bd6a5d0$%han@samsung.com> Subject: [PATCH 4/7] spi: s3c64xx: remove unnecessary OOM messages Date: Tue, 29 Apr 2014 17:20:20 +0900 Message-id: <002801cf6383$dca4b0c0$95ee1240$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9jg36HlbCqKDpQT3SMVWTyuXezSgAAFOXg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t8zfd2jCfHBBs+/CVpMffiEzeLywkus Fo0fb7I7MHtsWtXJ5tG3ZRWjx+dNcgHMUVw2Kak5mWWpRfp2CVwZu44vZiyYzVkxr6+FqYHx PHsXIyeHhICJxP45e9ggbDGJC/fWg9lCAssYJR4cY4SpeXp9PUsXIxdQfBGjxJU7T9kgnN+M EiseHGUCqWITUJP48uUw0FQODhEBVYn/r9xBwswCjhK7/l9mBQkLCdhKtLwvBTE5BewkZp82 BTGFBZwkWr/agRSzAPWtP7cWbCsvUPG62S+YIWxBiR+T77FADNSSWL/zOBOELS+xec1bZpAx EgLqEo/+6oKERQSMJDafvwFVIiKx78U7RpB7JQT2sUv0dB5ghNglIPFt8iEWiF5ZiU0HmCGe lZQ4uOIGywRGiVlINs9CsnkWks2zkKxYwMiyilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMk 8np3MN4+YH2IMRlo/URmKdHkfGDk5pXEGxqbGVmYmpgaG5lbmpEmrCTOm/QwKUhIID2xJDU7 NbUgtSi+qDQntfgQIxMHp1QD4yzpkLdnzc89PiLmze+/TmdLlkSRaJ1CuJPpUuVVwet+yS27 nHPjbdcmlzM1a+3vfeWeq6byjr/01uu2qB8he2SNkpU5N221eFP7dPLvv4Vt0ZKvZX9eXs/2 ZktDj5JpQMvh/+EzHHddFOSbXPx700Yj1m+Td7nd+BTb7rfLoZvBcuZz98l8ckosxRmJhlrM RcWJAHMh+CTSAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsVy+t9jAd2jCfHBBu+O8llMffiEzeLywkus Fo0fb7I7MHtsWtXJ5tG3ZRWjx+dNcgHMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaG uoaWFuZKCnmJuam2Si4+AbpumTlAm5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUY GaCBhHWMGbuOL2YsmM1ZMa+vhamB8Tx7FyMnh4SAicTT6+tZIGwxiQv31rN1MXJxCAksYpS4 cucplPObUWLFg6NMIFVsAmoSX74cBurm4BARUJX4/8odJMws4Cix6/9lVpCwkICtRMv7UhCT U8BOYvZpUxBTWMBJovWrHUgxC1Df+nNrGUFsXqDidbNfMEPYghI/Jt9jgRioJbF+53EmCFte YvOat8wgYyQE1CUe/dUFCYsIGElsPn8DqkREYt+Ld4wTGIVmIZk0C8mkWUgmzULSsoCRZRWj aGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcGQ/k9rBuLLB4hCjAAejEg+vQVRcsBBrYllxZe4h RgkOZiUR3nyr+GAh3pTEyqrUovz4otKc1OJDjMlAj05klhJNzgcmnbySeENjEzMjSyMzCyMT c3PShJXEeQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYNzW6rZ7lut7KX/bF/eO/+uTaHe5NZVR 3fmlzJRwKdX8jwIeM8s9HnSypTycu/Tj/pOuyYUd66LnvDGoVxe2nnPI3v9V/ZpAE+OT5opf v3y5WM54sulVq8XBgP3atlEqrSzTJkXuVFf7YT1D8Tf/rXVs3yZZXtysPPPWZrl7K+Unik0P CsgVWa/EUpyRaKjFXFScCADE/fB4MAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han --- drivers/spi/spi-s3c64xx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 153b4be..75a5696 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -772,7 +772,6 @@ static struct s3c64xx_spi_csinfo *s3c64xx_get_slave_ctrldata( cs = kzalloc(sizeof(*cs), GFP_KERNEL); if (!cs) { - dev_err(&spi->dev, "could not allocate memory for controller data\n"); of_node_put(data_np); return ERR_PTR(-ENOMEM); } @@ -986,10 +985,8 @@ static struct s3c64xx_spi_info *s3c64xx_spi_parse_dt(struct device *dev) u32 temp; sci = devm_kzalloc(dev, sizeof(*sci), GFP_KERNEL); - if (!sci) { - dev_err(dev, "memory allocation for spi_info failed\n"); + if (!sci) return ERR_PTR(-ENOMEM); - } if (of_property_read_u32(dev->of_node, "samsung,spi-src-clk", &temp)) { dev_warn(dev, "spi bus clock parent not specified, using clock at index 0 as parent\n");