From patchwork Thu Oct 27 19:24:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9400257 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2165460588 for ; Thu, 27 Oct 2016 19:29:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2F3D2A396 for ; Thu, 27 Oct 2016 19:29:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E73022A398; Thu, 27 Oct 2016 19:29:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89ABB2A396 for ; Thu, 27 Oct 2016 19:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199AbcJ0T3n (ORCPT ); Thu, 27 Oct 2016 15:29:43 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34271 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633AbcJ0T3n (ORCPT ); Thu, 27 Oct 2016 15:29:43 -0400 Received: by mail-wm0-f68.google.com with SMTP id y138so4185639wme.1 for ; Thu, 27 Oct 2016 12:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=AX33d2TUqjVd2Mwx2dWT846nVwYRDHRJgbKHhmg/z+0=; b=S2IX6U6qx0MlRIxKIJiuJQEy1qqlP8QXoWcSWf2l0wkEY2RhnaUaTb+5GG/4soM7/p zW95RkZnc4V+JfzibWu2PnL6M4fA9ZKRIxk/1NT6Pl4QKBB9YID3lsRmrnYtFGUhWgbq hcGK+tR9QZNFkj+najqrD3aGsg/dOAjOUxiVSumg7eN7a68kg0W3IJx7sUJSMYn5Hcrz aV+fJRvxUEBvJ6z0lb0BrU5TtDHcvObKdishWA16WomSl7ZITM0MOZqN8G5UyH9K7kHw /uRjsj39+OHgUGDC9aiDj1lAuQtIyrnzQM1E2aLte6DTfKpPsmMzVcnRoIvgiXZpLWx4 edIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=AX33d2TUqjVd2Mwx2dWT846nVwYRDHRJgbKHhmg/z+0=; b=cpOlJvu43CpnKVd+m9/nX8qtl+WJjtyJR96qNkLMI2pVXIoTQsA5dzIz5GzSxCiFkW 7oUY8IIrwjyTVFZoBgh9RwuBqEEq4i7VxI+O74igIqp+Iv/onOIWX/ln2/wFyxFW9RMN aV1ij3/1fyUF+l4Glmg0mK4Jxeg95qFVqRKhvpu/BLQ9oDSK/icRH9bAFtvAIGCP2mPu T3g5zFZpTM77LqiHJph06Omd7SeCuQKCCyex1pdoWLdMZLbezNVDQVZoCsxfjVntUXS3 n3efl86MIHl+rwrfDZsYZ0y46/G0ySx+Xv5OCmcbYSvWN1NpJn2UlKP8cMBIQxi491il NqFA== X-Gm-Message-State: ABUngveQ83tOFwGmqMLJREWzHCWHpnwf9dOUIsxGG/o6p7tWfUCQxgwbYgUIYza3GONi4A== X-Received: by 10.28.159.16 with SMTP id i16mr16711wme.122.1477596581783; Thu, 27 Oct 2016 12:29:41 -0700 (PDT) Received: from ?IPv6:2003:62:5f6e:ba00:49f8:f47b:2191:41c4? (p200300625F6EBA0049F8F47B219141C4.dip0.t-ipconnect.de. [2003:62:5f6e:ba00:49f8:f47b:2191:41c4]) by smtp.googlemail.com with ESMTPSA id s204sm4952058wmd.1.2016.10.27.12.29.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2016 12:29:41 -0700 (PDT) From: Heiner Kallweit Subject: [PATCH v2 01/09] spi: fsl-espi: improve check for SPI_QE_CPU_MODE To: Mark Brown References: <5b98be38-17a2-79a2-14da-fb2bb6f8820f@gmail.com> Cc: "linux-spi@vger.kernel.org" Message-ID: <0b5e7849-88d6-2af5-a428-eeb0de0f2af2@gmail.com> Date: Thu, 27 Oct 2016 21:24:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5b98be38-17a2-79a2-14da-fb2bb6f8820f@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP SPI_QE_CPU_MODE doesn't exist for ESPI and is set by of_mpc8xxx_spi_probe based on DT property "mode". This property is not defined for ESPI, see Documentation/devicetree/bindings/spi/fsl-spi.txt. So print an error message and bail out if SPI_QE_CPU_MODE is set. Signed-off-by: Heiner Kallweit --- v2: - print error message and bail out instead of removing the check --- drivers/spi/spi-fsl-espi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index 4e8a99d..f04c246 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -583,8 +583,9 @@ static int fsl_espi_probe(struct device *dev, struct resource *mem, goto err_probe; if (mpc8xxx_spi->flags & SPI_QE_CPU_MODE) { - mpc8xxx_spi->rx_shift = 16; - mpc8xxx_spi->tx_shift = 24; + dev_err(dev, "SPI_QE_CPU_MODE is not supported on ESPI!\n"); + ret = -EINVAL; + goto err_probe; } /* SPI controller initializations */