| Message ID | 1387878574-21445-5-git-send-email-geert+renesas@linux-m68k.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2aae80b27da6904939ed38959ee3d153f27ee7d1 |
| Headers | show |
Hi Geert, Thank you for the patch. On Tuesday 24 December 2013 10:49:33 Geert Uytterhoeven wrote: > Make it more obvious that this value is dummy data. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> > --- > drivers/spi/spi-rspi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c > index 4e376db1ca4f..51fe3bdacb18 100644 > --- a/drivers/spi/spi-rspi.c > +++ b/drivers/spi/spi-rspi.c > @@ -149,6 +149,8 @@ > #define SPBFCR_TXRST 0x80 /* qspi only */ > #define SPBFCR_RXRST 0x40 /* qspi only */ > > +#define DUMMY_DATA 0x00 > + > struct rspi_data { > void __iomem *addr; > u32 max_speed_hz; > @@ -541,7 +543,7 @@ static int rspi_receive_pio(struct rspi_data *rspi, > struct spi_message *mesg, return -ETIMEDOUT; > } > /* dummy write for generate clock */ > - rspi_write16(rspi, 0x00, RSPI_SPDR); > + rspi_write16(rspi, DUMMY_DATA, RSPI_SPDR); Doesn't the comment make it obvious already ? > if (rspi_wait_for_interrupt(rspi, SPSR_SPRF, SPCR_SPRIE) < 0) { > dev_err(&rspi->master->dev, > @@ -586,7 +588,7 @@ static int qspi_receive_pio(struct rspi_data *rspi, > struct spi_message *mesg, return -ETIMEDOUT; > } > /* dummy write for generate clock */ > - rspi_write8(rspi, 0x00, RSPI_SPDR); > + rspi_write8(rspi, DUMMY_DATA, RSPI_SPDR); > > if (rspi_wait_for_interrupt(rspi, SPSR_SPRF, SPCR_SPRIE) < 0) { > dev_err(&rspi->master->dev,
On Fri, Dec 27, 2013 at 03:36:12PM +0100, Laurent Pinchart wrote: > On Tuesday 24 December 2013 10:49:33 Geert Uytterhoeven wrote: > > /* dummy write for generate clock */ > > - rspi_write16(rspi, 0x00, RSPI_SPDR); > > + rspi_write16(rspi, DUMMY_DATA, RSPI_SPDR); > Doesn't the comment make it obvious already ? To be honest that had been my thought as well but if it makes the people working on the driver happy...
diff --git a/drivers/spi/spi-rspi.c b/drivers/spi/spi-rspi.c index 4e376db1ca4f..51fe3bdacb18 100644 --- a/drivers/spi/spi-rspi.c +++ b/drivers/spi/spi-rspi.c @@ -149,6 +149,8 @@ #define SPBFCR_TXRST 0x80 /* qspi only */ #define SPBFCR_RXRST 0x40 /* qspi only */ +#define DUMMY_DATA 0x00 + struct rspi_data { void __iomem *addr; u32 max_speed_hz; @@ -541,7 +543,7 @@ static int rspi_receive_pio(struct rspi_data *rspi, struct spi_message *mesg, return -ETIMEDOUT; } /* dummy write for generate clock */ - rspi_write16(rspi, 0x00, RSPI_SPDR); + rspi_write16(rspi, DUMMY_DATA, RSPI_SPDR); if (rspi_wait_for_interrupt(rspi, SPSR_SPRF, SPCR_SPRIE) < 0) { dev_err(&rspi->master->dev, @@ -586,7 +588,7 @@ static int qspi_receive_pio(struct rspi_data *rspi, struct spi_message *mesg, return -ETIMEDOUT; } /* dummy write for generate clock */ - rspi_write8(rspi, 0x00, RSPI_SPDR); + rspi_write8(rspi, DUMMY_DATA, RSPI_SPDR); if (rspi_wait_for_interrupt(rspi, SPSR_SPRF, SPCR_SPRIE) < 0) { dev_err(&rspi->master->dev,
Make it more obvious that this value is dummy data. Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org> --- drivers/spi/spi-rspi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)