| Message ID | 1391529538-21685-9-git-send-email-ulf.hansson@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Feb 04, 2014 at 04:58:49PM +0100, Ulf Hansson wrote: > Use clk_disable_unprepare and clk_prepare_enable from the runtime PM > callbacks, to fully gate|ungate clocks. Potentially this will save more > power, depending on the clock tree for the current SOC. The same patch has already been applied (I noticed and fixed it while doing unrelated code review). > pinctrl_pm_select_default_state(dev); > - clk_enable(pl022->clk); > + clk_prepare_enable(pl022->clk); Someone should really make this check errors though!
On 4 February 2014 18:07, Mark Brown <broonie@kernel.org> wrote: > On Tue, Feb 04, 2014 at 04:58:49PM +0100, Ulf Hansson wrote: >> Use clk_disable_unprepare and clk_prepare_enable from the runtime PM >> callbacks, to fully gate|ungate clocks. Potentially this will save more >> power, depending on the clock tree for the current SOC. > > The same patch has already been applied (I noticed and fixed it while > doing unrelated code review). Sorry, didn't notice that. Thanks! Kind regards Ulf Hansson > >> pinctrl_pm_select_default_state(dev); >> - clk_enable(pl022->clk); >> + clk_prepare_enable(pl022->clk); > > Someone should really make this check errors though! -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index db829a1..2bb238f 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2355,7 +2355,7 @@ static int pl022_runtime_suspend(struct device *dev) { struct pl022 *pl022 = dev_get_drvdata(dev); - clk_disable(pl022->clk); + clk_disable_unprepare(pl022->clk); pinctrl_pm_select_idle_state(dev); return 0; @@ -2366,7 +2366,7 @@ static int pl022_runtime_resume(struct device *dev) struct pl022 *pl022 = dev_get_drvdata(dev); pinctrl_pm_select_default_state(dev); - clk_enable(pl022->clk); + clk_prepare_enable(pl022->clk); return 0; }
Use clk_disable_unprepare and clk_prepare_enable from the runtime PM callbacks, to fully gate|ungate clocks. Potentially this will save more power, depending on the clock tree for the current SOC. Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- drivers/spi/spi-pl022.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)