| Message ID | 1395731432-30027-1-git-send-email-alexander.stein@systec-electronic.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 342451df07109f865e6c108b7205e9738e814f3f |
| Headers | show |
On Tue, Mar 25, 2014 at 08:10:32AM +0100, Alexander Stein wrote: > If during a SPI transfer with len larger than PCH_MAX_FIFO_DEPTH and the > IRQ handler happens to be called when the transmit FIFO is already empty, > and SPSR_FI_BIT is set consequently, the message Applied, thanks. Please use subject lines consistent with the style of the subsystem.
diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 88eb57e..667a1bb 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -332,7 +332,7 @@ static void pch_spi_handler_sub(struct pch_spi_data *data, u32 reg_spsr_val, data->transfer_active = false; wake_up(&data->wait); } else { - dev_err(&data->master->dev, + dev_vdbg(&data->master->dev, "%s : Transfer is not completed", __func__); }
If during a SPI transfer with len larger than PCH_MAX_FIFO_DEPTH and the IRQ handler happens to be called when the transmit FIFO is already empty, and SPSR_FI_BIT is set consequently, the message "spi_master spi32766: pch_spi_handler_sub : Transfer is not completed" is spammed to the systemlog, because tx_index has already increased further due to the next bytes to be written. This case is uncritical as new bytes have already been written. Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> --- Changes in v2: * use dev_vdbg instead of dev_dbg drivers/spi/spi-topcliff-pch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)