From patchwork Tue Mar 25 07:10:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 3885391 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C4195BF540 for ; Tue, 25 Mar 2014 07:11:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E8CB52020E for ; Tue, 25 Mar 2014 07:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29D3D201FD for ; Tue, 25 Mar 2014 07:11:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751218AbaCYHLk (ORCPT ); Tue, 25 Mar 2014 03:11:40 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:52316 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbaCYHLk (ORCPT ); Tue, 25 Mar 2014 03:11:40 -0400 Received: from comm.systec-electronic.de (unknown [212.185.67.148]) by webbox1416.server-home.net (Postfix) with ESMTPA id 4234127A5ED; Tue, 25 Mar 2014 07:13:24 +0100 (CET) Received: from ws-stein.systec-electronic.de (unknown [192.168.10.109]) by comm.systec-electronic.de (Postfix) with ESMTP id CC22E97C275; Tue, 25 Mar 2014 08:11:37 +0100 (CET) From: Alexander Stein To: Mark Brown Cc: linux-spi@vger.kernel.org, Alexander Stein Subject: [PATCH v2] spi-topcliff-pch: Transform noisy message to dev_vdbg Date: Tue, 25 Mar 2014 08:10:32 +0100 Message-Id: <1395731432-30027-1-git-send-email-alexander.stein@systec-electronic.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <20140219124150.GO2669@sirena.org.uk> References: <20140219124150.GO2669@sirena.org.uk> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If during a SPI transfer with len larger than PCH_MAX_FIFO_DEPTH and the IRQ handler happens to be called when the transmit FIFO is already empty, and SPSR_FI_BIT is set consequently, the message "spi_master spi32766: pch_spi_handler_sub : Transfer is not completed" is spammed to the systemlog, because tx_index has already increased further due to the next bytes to be written. This case is uncritical as new bytes have already been written. Signed-off-by: Alexander Stein --- Changes in v2: * use dev_vdbg instead of dev_dbg drivers/spi/spi-topcliff-pch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c index 88eb57e..667a1bb 100644 --- a/drivers/spi/spi-topcliff-pch.c +++ b/drivers/spi/spi-topcliff-pch.c @@ -332,7 +332,7 @@ static void pch_spi_handler_sub(struct pch_spi_data *data, u32 reg_spsr_val, data->transfer_active = false; wake_up(&data->wait); } else { - dev_err(&data->master->dev, + dev_vdbg(&data->master->dev, "%s : Transfer is not completed", __func__); }