diff mbox

spi: core: Ignore unsupported spi-[tr]x-bus-width property values

Message ID 1401105925-16528-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit 80874d8c9e9cbfa195572dfea46f2314098b3869
Headers show

Commit Message

Geert Uytterhoeven May 26, 2014, 12:05 p.m. UTC 
Rejecting unsupported values of spi-tx-bus-width and spi-rx-bus-width
may break compatibility with future DTs. Just ignore them, falling back
to Single SPI Transfers.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
I thought I sent this before, but I can't find any evidence

 drivers/spi/spi.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

Comments

Mark Brown May 26, 2014, 2:29 p.m. UTC | #1 
On Mon, May 26, 2014 at 02:05:25PM +0200, Geert Uytterhoeven wrote:
> Rejecting unsupported values of spi-tx-bus-width and spi-rx-bus-width
> may break compatibility with future DTs. Just ignore them, falling back
> to Single SPI Transfers.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 074f55f5d5ec..d4f9670b51bc 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1270,11 +1270,10 @@  static void of_register_spi_devices(struct spi_master *master)
 				spi->mode |= SPI_TX_QUAD;
 				break;
 			default:
-				dev_err(&master->dev,
-					"spi-tx-bus-width %d not supported\n",
-					value);
-				spi_dev_put(spi);
-				continue;
+				dev_warn(&master->dev,
+					 "spi-tx-bus-width %d not supported\n",
+					 value);
+				break;
 			}
 		}
 
@@ -1289,11 +1288,10 @@  static void of_register_spi_devices(struct spi_master *master)
 				spi->mode |= SPI_RX_QUAD;
 				break;
 			default:
-				dev_err(&master->dev,
-					"spi-rx-bus-width %d not supported\n",
-					value);
-				spi_dev_put(spi);
-				continue;
+				dev_warn(&master->dev,
+					 "spi-rx-bus-width %d not supported\n",
+					 value);
+				break;
 			}
 		}