From patchwork Fri Aug 8 11:02:36 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 4695441 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 29A769F373 for ; Fri, 8 Aug 2014 11:02:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4EEEF2010C for ; Fri, 8 Aug 2014 11:02:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5410D20160 for ; Fri, 8 Aug 2014 11:02:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756325AbaHHLCm (ORCPT ); Fri, 8 Aug 2014 07:02:42 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:50659 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755969AbaHHLCl (ORCPT ); Fri, 8 Aug 2014 07:02:41 -0400 Received: by mail-pd0-f176.google.com with SMTP id y10so6860501pdj.21 for ; Fri, 08 Aug 2014 04:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=X0NW/UPB+n8FH+bQsvdc6Bj7z4auHggGzRdHgUpjcPY=; b=r23AVGM9LEeR2BrlgLCtKmNNx7DHzmLMajnNsJ9N+CGYrQXvndZ6AjIZylp52YPvPv iOg683gG93K4Kll12a+ZYiGJA8ofb5/G4lxTka2455gn2MmyWvqf3K0XoX/ViSfhzwp2 88ci20PC6+Nup3P4JNB1zLvDaM13zt3n39wnKOQ3RjuBZbWf3WJkPwJdtnSi+R8y30j7 VcYtKjR0roL7RmVCnF19n2H6YZp+TlcsSJhaVUhfson46zE3y0/1tflVK3pvuFdhQSb6 coJoa2lAITMtqe9PQN7cjAG1RL+j1wW/xp18VAoxcIPIL523rX/9c1AWMBwvx8tooQsi 5haA== X-Received: by 10.66.217.231 with SMTP id pb7mr23933495pac.29.1407495760937; Fri, 08 Aug 2014 04:02:40 -0700 (PDT) Received: from localhost ([216.228.120.20]) by mx.google.com with ESMTPSA id cv2sm2636897pbc.34.2014.08.08.04.02.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Aug 2014 04:02:40 -0700 (PDT) From: Thierry Reding To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] spi: Add missing kerneldoc bits Date: Fri, 8 Aug 2014 13:02:36 +0200 Message-Id: <1407495756-19331-1-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 2.0.4 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Thierry Reding These are all arguments or fields that got added without updating the kerneldoc comments. Signed-off-by: Thierry Reding --- drivers/spi/spi.c | 1 + include/linux/spi/spi.h | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index e0531baf2782..ca935df80c88 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -848,6 +848,7 @@ out: /** * spi_finalize_current_transfer - report completion of a transfer + * @master: the master reporting completion * * Called by SPI drivers using the core transfer_one_message() * implementation to notify it that the current interrupt driven diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index e713543336f1..46d188a9947c 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -253,6 +253,7 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv) * the device whose settings are being modified. * @transfer: adds a message to the controller's transfer queue. * @cleanup: frees controller-specific state + * @can_dma: determine whether this master supports DMA * @queued: whether this master is providing an internal message queue * @kworker: thread struct for message pump * @kworker_task: pointer to task for message pump kworker thread @@ -262,6 +263,7 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv) * @cur_msg: the currently in-flight message * @cur_msg_prepared: spi_prepare_message was called for the currently * in-flight message + * @cur_msg_mapped: message has been mapped for DMA * @xfer_completion: used by core transfer_one_message() * @busy: message pump is busy * @running: message pump is running @@ -299,6 +301,10 @@ static inline void spi_unregister_driver(struct spi_driver *sdrv) * @cs_gpios: Array of GPIOs to use as chip select lines; one per CS * number. Any individual value may be -ENOENT for CS lines that * are not GPIOs (driven by the SPI controller itself). + * @dma_tx: DMA transmit channel + * @dma_rx: DMA receive channel + * @dummy_rx: dummy receive buffer for full-duplex devices + * @dummy_tx: dummy transmit buffer for full-duplex devices * * Each SPI master controller can communicate with one or more @spi_device * children. These make a small bus, sharing MOSI, MISO and SCK signals @@ -632,6 +638,7 @@ struct spi_transfer { * addresses for each transfer buffer * @complete: called to report transaction completions * @context: the argument to complete() when it's called + * @frame_length: the total number of bytes in the message * @actual_length: the total number of bytes that were transferred in all * successful segments * @status: zero for success, else negative errno