| Message ID | 1411635212-20908-1-git-send-email-alexander.stein@systec-electronic.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote: > - pr_info(KERN_INFO "Freescale DSPI master initialized\n"); > + dev_info(&pdev->dev, "master initialized\n"); This message has no content, it should just be removed entirely.
On Thursday 25 September 2014 11:14:30, Mark Brown wrote: > On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote: > > > - pr_info(KERN_INFO "Freescale DSPI master initialized\n"); > > + dev_info(&pdev->dev, "master initialized\n"); > > This message has no content, it should just be removed entirely. Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg. Best regards, Alexander
On Thu, Sep 25, 2014 at 12:30:58PM +0200, Alexander Stein wrote: > On Thursday 25 September 2014 11:14:30, Mark Brown wrote: > > On Thu, Sep 25, 2014 at 10:53:32AM +0200, Alexander Stein wrote: > > > - pr_info(KERN_INFO "Freescale DSPI master initialized\n"); > > > + dev_info(&pdev->dev, "master initialized\n"); > > This message has no content, it should just be removed entirely. Fix your mailer to word wrap within paragraphs please. > Well, you know that the device has been probed successfully, which IMO is a message the user should be able to see in dmesg. The same thing applies to absolutely every driver in the system; if this is a useful thing to do we should just make the driver core do it, though there are then problems with noise during boot and an impact on boot time when using a serial console.
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index 5021ddf..e55144c 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -535,7 +535,7 @@ static int dspi_probe(struct platform_device *pdev) goto out_clk_put; } - pr_info(KERN_INFO "Freescale DSPI master initialized\n"); + dev_info(&pdev->dev, "master initialized\n"); return ret; out_clk_put:
No need to add KERN_INFO to pr_info. Output is: 6Freescale DSPI master initialized While at it, use dev_info instead for a device specific message. Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com> --- drivers/spi/spi-fsl-dspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)