From patchwork Thu Dec 4 13:15:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 5438221 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F23CF9F1D4 for ; Thu, 4 Dec 2014 14:46:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2543020272 for ; Thu, 4 Dec 2014 14:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1DA920295 for ; Thu, 4 Dec 2014 14:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932187AbaLDOqM (ORCPT ); Thu, 4 Dec 2014 09:46:12 -0500 Received: from mail-bn1bn0101.outbound.protection.outlook.com ([157.56.110.101]:44448 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754178AbaLDOqL (ORCPT ); Thu, 4 Dec 2014 09:46:11 -0500 X-Greylist: delayed 4574 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Dec 2014 09:46:10 EST Received: from BY2PR03CA079.namprd03.prod.outlook.com (10.141.249.52) by BY2PR03MB256.namprd03.prod.outlook.com (10.242.37.23) with Microsoft SMTP Server (TLS) id 15.1.26.15; Thu, 4 Dec 2014 13:14:58 +0000 Received: from BL2FFO11FD033.protection.gbl (2a01:111:f400:7c09::186) by BY2PR03CA079.outlook.office365.com (2a01:111:e400:2c5d::52) with Microsoft SMTP Server (TLS) id 15.1.26.15 via Frontend Transport; Thu, 4 Dec 2014 13:14:58 +0000 Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD033.mail.protection.outlook.com (10.173.161.129) with Microsoft SMTP Server (TLS) id 15.1.6.13 via Frontend Transport; Thu, 4 Dec 2014 13:14:57 +0000 Received: from fabio-OptiPlex-7010.am.freescale.net ([10.29.244.106]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id sB4DEtHa018830; Thu, 4 Dec 2014 06:14:55 -0700 From: Fabio Estevam To: CC: , , , Fabio Estevam Subject: [PATCH] spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg() Date: Thu, 4 Dec 2014 11:15:47 -0200 Message-ID: <1417698947-4273-1-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(189002)(199003)(4396001)(104166001)(104016003)(64706001)(110136001)(50226001)(20776003)(47776003)(50466002)(50986999)(48376002)(31966008)(102836001)(81156004)(105606002)(106466001)(84676001)(95666004)(19580405001)(19580395003)(6806004)(107046002)(2351001)(229853001)(69596002)(92566001)(92726001)(88136002)(89996001)(87936001)(93916002)(86362001)(87286001)(77156002)(62966003)(97736003)(230783001)(99396003)(21056001)(120916001)(36756003)(46102003)(68736005)(77096005)(33646002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR03MB256; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:sfv; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB256; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(602001)(9)(8); SRVR:BY2PR03MB256; X-Forefront-PRVS: 041517DFAB Received-SPF: Fail (protection.outlook.com: domain of freescale.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=Fabio.Estevam@freescale.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB256; X-OriginatorOrg: freescale.com Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since commit c592becbe704127 ("spi: fsl-(e)spi: migrate to generic master queueing") the function fsl_spi_do_one_msg() is not void anymore, so return an error code to avoid the following buid warning: drivers/spi/spi-fsl-spi.c: In function 'fsl_spi_do_one_msg': >> drivers/spi/spi-fsl-spi.c:374:4: warning: 'return' with no value, in function returning non-void [-Wreturn-type] return; ^ Reported-by: kbuild test robot Signed-off-by: Fabio Estevam --- drivers/spi/spi-fsl-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-spi.c b/drivers/spi/spi-fsl-spi.c index e24a9bf..83f8081 100644 --- a/drivers/spi/spi-fsl-spi.c +++ b/drivers/spi/spi-fsl-spi.c @@ -371,7 +371,7 @@ static int fsl_spi_do_one_msg(struct spi_master *master, status = -EINVAL; dev_err(&spi->dev, "bits_per_word/speed_hz should be same for the same SPI transfer\n"); - return; + return -EINVAL; } }