From patchwork Mon Dec 22 19:35:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Bresticker X-Patchwork-Id: 5528941 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B501B9F1CD for ; Mon, 22 Dec 2014 19:35:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DDDD4201BB for ; Mon, 22 Dec 2014 19:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3A7A20121 for ; Mon, 22 Dec 2014 19:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755388AbaLVTfW (ORCPT ); Mon, 22 Dec 2014 14:35:22 -0500 Received: from mail-ig0-f201.google.com ([209.85.213.201]:50677 "EHLO mail-ig0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755260AbaLVTfU (ORCPT ); Mon, 22 Dec 2014 14:35:20 -0500 Received: by mail-ig0-f201.google.com with SMTP id h15so526548igd.0 for ; Mon, 22 Dec 2014 11:35:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6wz7fPCXaQsr/9djClk7MIl6qmE1WkcDnR7YptzUgcE=; b=aThhvx0skpPk88334ToIKFHCkYr9j2YIxUytdYzGr7mpOCxCFAx3I7HY1EHiw1JTdV VdlXsZNjx+OXIstYW8KVOaqgEjDGEFAg022kRYT8CIXTt+mFpGELnhwoC5k6KqGiBN6L H98XSi/S7NI1KE5ganLvJ6e9s91HaxEPSQM7Qqb8axWPv+Y7PN0ripkVsytWwQUDXAU6 LZy9d4QB1XHYbXrb3eYZVNnPV/49UZngvaK2k37a0hVK5FOEzVrlzw7vlQjEkU6nnbGh 0n60qfVrC+CC2MziRnMnN5nk3vPIwmeqa/BCw9rG7jlbAuOEnQZINcxa7wIVnPzak1E4 EdjA== X-Gm-Message-State: ALoCoQkpd42g3JeJ3CYBtlYn0whTTJ0VRVjaQvVzWTFuF2Bzob2rZJYQnkEb0qJ6wHj/Pxneg6uE X-Received: by 10.182.87.165 with SMTP id az5mr2142538obb.50.1419276919507; Mon, 22 Dec 2014 11:35:19 -0800 (PST) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id 5si861110yhd.6.2014.12.22.11.35.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Dec 2014 11:35:19 -0800 (PST) Received: from abrestic.mtv.corp.google.com ([172.22.65.70]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id u6yiUzuE.1; Mon, 22 Dec 2014 11:35:19 -0800 Received: by abrestic.mtv.corp.google.com (Postfix, from userid 137652) id 6648922069E; Mon, 22 Dec 2014 11:35:18 -0800 (PST) From: Andrew Bresticker To: Mark Brown Cc: Sifan Naeem , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Bresticker Subject: [PATCH V2 1/2] spi: img-spfi: Increase DMA burst size Date: Mon, 22 Dec 2014 11:35:15 -0800 Message-Id: <1419276916-28433-1-git-send-email-abrestic@chromium.org> X-Mailer: git-send-email 2.2.0.rc0.207.ga3a616c Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A 1-byte burst size is rather inefficient and has been shown to cause TX issues during testing. Increase the DMA burst size to 4-bytes for both RX and TX DMA when using the 8-bit FIFO. Signed-off-by: Andrew Bresticker --- drivers/spi/spi-img-spfi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c index cd14556..aad6683 100644 --- a/drivers/spi/spi-img-spfi.c +++ b/drivers/spi/spi-img-spfi.c @@ -341,7 +341,7 @@ static int img_spfi_start_dma(struct spi_master *master, default: rxconf.src_addr = spfi->phys + SPFI_RX_8BIT_VALID_DATA; rxconf.src_addr_width = 1; - rxconf.src_maxburst = 1; + rxconf.src_maxburst = 4; } dmaengine_slave_config(spfi->rx_ch, &rxconf); @@ -368,7 +368,7 @@ static int img_spfi_start_dma(struct spi_master *master, default: txconf.dst_addr = spfi->phys + SPFI_TX_8BIT_VALID_DATA; txconf.dst_addr_width = 1; - txconf.dst_maxburst = 1; + txconf.dst_maxburst = 4; break; } dmaengine_slave_config(spfi->tx_ch, &txconf);