| Message ID | 1419294557-10632-1-git-send-email-broonie@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b2e5dda14fbc2ca1155c614c500c6de6f5b4ba8c |
| Headers | show |
Hi Mark, On Tue, Dec 23, 2014 at 1:29 AM, Mark Brown <broonie@kernel.org> wrote: > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > drivers/spi/spi-dln2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c > index 7b35454..cede063 100644 > --- a/drivers/spi/spi-dln2.c > +++ b/drivers/spi/spi-dln2.c > @@ -850,7 +850,7 @@ static int dln2_spi_resume(struct device *dev) > } > #endif /* CONFIG_PM_SLEEP */ > > -#ifdef CONFIG_PM_RUNTIME > +#ifdef CONFIG_PM > static int dln2_spi_runtime_suspend(struct device *dev) > { > struct spi_master *master = dev_get_drvdata(dev); You forgot to update the comment for the corresponding #endif a few lines below: #endif /* CONFIG_PM_RUNTIME */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 29, 2014 at 04:03:40PM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 23, 2014 at 1:29 AM, Mark Brown <broonie@kernel.org> wrote: > > +#ifdef CONFIG_PM > > static int dln2_spi_runtime_suspend(struct device *dev) > > { > > struct spi_master *master = dev_get_drvdata(dev); > You forgot to update the comment for the corresponding #endif a few > lines below: > #endif /* CONFIG_PM_RUNTIME */ *sigh* which is one of the many reasons to get annoyed about those comments; if you care about this please feel free to send a patch.
diff --git a/drivers/spi/spi-dln2.c b/drivers/spi/spi-dln2.c index 7b35454..cede063 100644 --- a/drivers/spi/spi-dln2.c +++ b/drivers/spi/spi-dln2.c @@ -850,7 +850,7 @@ static int dln2_spi_resume(struct device *dev) } #endif /* CONFIG_PM_SLEEP */ -#ifdef CONFIG_PM_RUNTIME +#ifdef CONFIG_PM static int dln2_spi_runtime_suspend(struct device *dev) { struct spi_master *master = dev_get_drvdata(dev);
Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/spi-dln2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)