From patchwork Fri Jan 23 16:08:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 5695781 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E6FF3C058D for ; Fri, 23 Jan 2015 16:14:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E9D23202E5 for ; Fri, 23 Jan 2015 16:14:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F10BC201F4 for ; Fri, 23 Jan 2015 16:14:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755603AbbAWQOc (ORCPT ); Fri, 23 Jan 2015 11:14:32 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:49484 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755786AbbAWQJF (ORCPT ); Fri, 23 Jan 2015 11:09:05 -0500 Received: by mail-la0-f44.google.com with SMTP id s18so2212705lam.3; Fri, 23 Jan 2015 08:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8YDyuRhInfpn0f4xQPqrr870ftwQ/iTPB1TAtw+OlMY=; b=mRUtwkTE1ILA/Gg6lpL9OnpTnXmzy81XQrfAfbcullvfQhs8DbO99K+2mPulC5YWvm 1XjsDEfhPgpqy35CMyhHHteHnKmruMTE0/2/7rSd0fZUdlIsAkRuWP4ox+4NBBRERiRr kli1075vPk/DoBA2hWvUdK4+4VWDFP3hcmSUpWPFLGu9OjxYCdMSpJgqO8w9lb3CRXiS wdtbm12QKmLoy6Hc6hC5TgwFr/Yhr98pawWUV6aUsK6NSRxubmG0LtUhR6cJjGFIe5AL 8jLirf3uyKRhx++g5Pd9fhbuf5QR+nmPIGIS4RcLwLyOBsTJ6cJt9YBEyTaKuXG7lOGD H+cQ== X-Received: by 10.112.27.133 with SMTP id t5mr8142135lbg.45.1422029343789; Fri, 23 Jan 2015 08:09:03 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by mx.google.com with ESMTPSA id h7sm542990lbl.41.2015.01.23.08.09.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 Jan 2015 08:09:02 -0800 (PST) From: Ricardo Ribalda Delgado To: Mark Brown , Michal Simek , =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH 06/18] spi/xilinx: Code cleanup Date: Fri, 23 Jan 2015 17:08:38 +0100 Message-Id: <1422029330-10971-7-git-send-email-ricardo.ribalda@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1422029330-10971-1-git-send-email-ricardo.ribalda@gmail.com> References: <1422029330-10971-1-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Trivial fix Signed-off-by: Ricardo Ribalda Delgado --- drivers/spi/spi-xilinx.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c index 408a842..978fbdd 100644 --- a/drivers/spi/spi-xilinx.c +++ b/drivers/spi/spi-xilinx.c @@ -248,7 +248,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) xspi->remaining_bytes = t->len; reinit_completion(&xspi->done); - for (;;) { + while (xspi->remaining_bytes) { u16 cr; int n_words; @@ -278,10 +278,6 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) /* Read out all the data from the Rx FIFO */ while (n_words--) xspi->rx_fn(xspi); - - /* See if there is more data to send */ - if (xspi->remaining_bytes <= 0) - break; } return t->len - xspi->remaining_bytes;