From patchwork Mon Apr 27 23:55:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 6284461 Return-Path: X-Original-To: patchwork-linux-spi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id DB66DBEEE5 for ; Mon, 27 Apr 2015 23:57:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E430D202FE for ; Mon, 27 Apr 2015 23:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BDD1C20304 for ; Mon, 27 Apr 2015 23:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbbD0X5S (ORCPT ); Mon, 27 Apr 2015 19:57:18 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34856 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932281AbbD0X5P (ORCPT ); Mon, 27 Apr 2015 19:57:15 -0400 Received: by pabtp1 with SMTP id tp1so145497904pab.2; Mon, 27 Apr 2015 16:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gMx4eJAH+6/v/+IPPLmOSgAwRhwC4tIrrruehDkL1iA=; b=prRN55n5rVQW0C517wij0j84fuF35h7zj/YeENjFY/ZErNxVwqx2Bsb0DhooElfW+U Hyx2p1nhZIHBcgXTbcmT3+fhXTYEuz4jZVKKt726DMSAGMbesWOPIDHgpyfaSRmOnHkF a+A8b2ve/Ozkj5b80XP0KoiXBT6u/2EA2ifvmipkmf6S4Y+3POKTiH7mA0KLBIfzVBjg knWiKgBkN4i71fXVmFYmq0mdl6FF2DNIJlcETE9hOlt/UVnGaC6BgT/pjM9AN1s66anD AWjFm9cCXudAHPLBqUd1FRLSOjUIGoizokeN9imvYIgdtPYVUDiYaK+lCb5npkGIJUgo MA8g== X-Received: by 10.68.68.134 with SMTP id w6mr26680034pbt.25.1430179034691; Mon, 27 Apr 2015 16:57:14 -0700 (PDT) Received: from fangorn.rup.mentorg.com (nat-min.mentorg.com. [139.181.32.34]) by mx.google.com with ESMTPSA id pv2sm20428375pbb.12.2015.04.27.16.57.08 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Apr 2015 16:57:14 -0700 (PDT) From: Dmitry Eremin-Solenikov To: Russell King , Daniel Mack , Robert Jarzmik , Linus Walleij , Alexandre Courbot , Wolfram Sang , Dmitry Torokhov , Bryan Wu , Richard Purdie , Samuel Ortiz , Lee Jones , Mark Brown , Jingoo Han , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Liam Girdwood , Andrea Adami Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH v2 08/17] gpio: locomo: implement per-pin irq handling Date: Tue, 28 Apr 2015 02:55:45 +0300 Message-Id: <1430178954-11138-9-git-send-email-dbaryshkov@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1430178954-11138-1-git-send-email-dbaryshkov@gmail.com> References: <1430178954-11138-1-git-send-email-dbaryshkov@gmail.com> Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP LoCoMo has a possibility to generate per-GPIO edge irqs. Support for that was there in old locomo driver, got 'cleaned up' during old driver IRQ cascading cleanup and is now reimplemented. It is expected that SL-5500 (collie) will use locomo gpio irqs for mmc detection irq. Signed-off-by: Dmitry Eremin-Solenikov Reviewed-by: Linus Walleij --- drivers/gpio/Kconfig | 1 + drivers/gpio/gpio-locomo.c | 120 ++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 120 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 4542684..6b77614 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -737,6 +737,7 @@ config GPIO_KEMPLD config GPIO_LOCOMO bool "Sharp LoCoMo GPIO support" depends on MFD_LOCOMO + select GPIOLIB_IRQCHIP help Select this to support GPIO pins on Sharp LoCoMo Grid Array found in Sharp Zaurus collie and poodle models. diff --git a/drivers/gpio/gpio-locomo.c b/drivers/gpio/gpio-locomo.c index dd9a1ca..d8e5880 100644 --- a/drivers/gpio/gpio-locomo.c +++ b/drivers/gpio/gpio-locomo.c @@ -16,13 +16,15 @@ #include #include #include -#include +#include #include +#include #include #include struct locomo_gpio { struct regmap *regmap; + int irq; struct gpio_chip gpio; @@ -79,6 +81,99 @@ static int locomo_gpio_direction_output(struct gpio_chip *chip, return 0; } +static void +locomo_gpio_irq_handler(unsigned int irq, struct irq_desc *desc) +{ + struct gpio_chip *chip = irq_get_handler_data(irq); + struct locomo_gpio *lg = container_of(chip, struct locomo_gpio, gpio); + struct irq_chip *irqchip = irq_desc_get_chip(desc); + unsigned int gir; + unsigned int gpd; + unsigned int req; + + chained_irq_enter(irqchip, desc); + + while (1) { + regmap_read(lg->regmap, LOCOMO_GIR, &gir); + regmap_read(lg->regmap, LOCOMO_GPD, &gpd); + req = gir & gpd; + + if (!req) + break; + + generic_handle_irq(irq_find_mapping(lg->gpio.irqdomain, + ffs(req) - 1)); + } + + chained_irq_exit(irqchip, desc); +} + +static void locomo_gpio_ack_irq(struct irq_data *d) +{ + struct gpio_chip *chip = irq_data_get_irq_chip_data(d); + struct locomo_gpio *lg = container_of(chip, struct locomo_gpio, gpio); + unsigned int mask = BIT(d->hwirq); + + regmap_update_bits(lg->regmap, LOCOMO_GWE, mask, mask); + regmap_update_bits(lg->regmap, LOCOMO_GIS, mask, 0); + regmap_update_bits(lg->regmap, LOCOMO_GWE, mask, 0); +} + +static void locomo_gpio_mask_irq(struct irq_data *d) +{ + struct gpio_chip *chip = irq_data_get_irq_chip_data(d); + struct locomo_gpio *lg = container_of(chip, struct locomo_gpio, gpio); + unsigned int mask = BIT(d->hwirq); + + regmap_update_bits(lg->regmap, LOCOMO_GIE, mask, 0); +} + +static void locomo_gpio_unmask_irq(struct irq_data *d) +{ + struct gpio_chip *chip = irq_data_get_irq_chip_data(d); + struct locomo_gpio *lg = container_of(chip, struct locomo_gpio, gpio); + unsigned int mask = BIT(d->hwirq); + + regmap_update_bits(lg->regmap, LOCOMO_GIE, mask, mask); +} + +static int locomo_gpio_type_irq(struct irq_data *d, unsigned int type) +{ + struct gpio_chip *chip = irq_data_get_irq_chip_data(d); + struct locomo_gpio *lg = container_of(chip, struct locomo_gpio, gpio); + unsigned int mask; + + mask = BIT(d->hwirq); + + if (type == IRQ_TYPE_PROBE) { + if ((lg->rising_edge | lg->falling_edge) & mask) + return 0; + type = IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING; + } + + if (type & IRQ_TYPE_EDGE_RISING) + lg->rising_edge |= mask; + else + lg->rising_edge &= ~mask; + if (type & IRQ_TYPE_EDGE_FALLING) + lg->falling_edge |= mask; + else + lg->falling_edge &= ~mask; + + regmap_write(lg->regmap, LOCOMO_GRIE, lg->rising_edge); + regmap_write(lg->regmap, LOCOMO_GFIE, lg->falling_edge); + + return 0; +} + +static struct irq_chip locomo_gpio_irq_chip = { + .name = "LOCOMO-g", + .irq_ack = locomo_gpio_ack_irq, + .irq_mask = locomo_gpio_mask_irq, + .irq_unmask = locomo_gpio_unmask_irq, + .irq_set_type = locomo_gpio_type_irq, +}; + #ifdef CONFIG_PM_SLEEP static int locomo_gpio_suspend(struct device *dev) { @@ -119,6 +214,10 @@ static int locomo_gpio_probe(struct platform_device *pdev) if (!lg) return -ENOMEM; + lg->irq = platform_get_irq(pdev, 0); + if (lg->irq < 0) + return -ENXIO; + lg->regmap = dev_get_regmap(pdev->dev.parent, NULL); if (!lg->regmap) return -EINVAL; @@ -130,6 +229,7 @@ static int locomo_gpio_probe(struct platform_device *pdev) regmap_write(lg->regmap, LOCOMO_GPD, 0x00); regmap_write(lg->regmap, LOCOMO_GIE, 0x00); + lg->gpio.dev = &pdev->dev; lg->gpio.base = pdata ? pdata->gpio_base : -1; lg->gpio.label = "locomo-gpio"; lg->gpio.ngpio = 16; @@ -142,7 +242,22 @@ static int locomo_gpio_probe(struct platform_device *pdev) if (ret) return ret; + ret = gpiochip_irqchip_add(&lg->gpio, &locomo_gpio_irq_chip, 0, + handle_level_irq, IRQ_TYPE_NONE); + if (ret) { + dev_err(&pdev->dev, "Failed to add irq chip\n"); + goto err_rm_gpiochip; + } + + gpiochip_set_chained_irqchip(&lg->gpio, &locomo_gpio_irq_chip, lg->irq, + locomo_gpio_irq_handler); + return 0; + +err_rm_gpiochip: + gpiochip_remove(&lg->gpio); + + return ret; } static int locomo_gpio_remove(struct platform_device *pdev) @@ -151,6 +266,9 @@ static int locomo_gpio_remove(struct platform_device *pdev) gpiochip_remove(&lg->gpio); + irq_set_chained_handler(lg->irq, NULL); + irq_set_handler_data(lg->irq, NULL); + return 0; }