diff mbox

spi: pxa2xx: Add terminating entry for pxa2xx_spi_pci_compound_match

Message ID 1438667542.8228.1.camel@ingics.com (mailing list archive)
State Accepted
Commit 94e5c23d3c52f58f4051810a15aeacc085127ad1
Headers show

Commit Message

Axel Lin Aug. 4, 2015, 5:52 a.m. UTC
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/spi/spi-pxa2xx.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jarkko Nikula Aug. 4, 2015, 5:58 a.m. UTC | #1
On 08/04/2015 08:52 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/spi/spi-pxa2xx.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index e924710..246ffab 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -1300,6 +1300,7 @@ static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
>   	/* SPT-H */
>   	{ PCI_VDEVICE(INTEL, 0xa129), LPSS_SPT_SSP },
>   	{ PCI_VDEVICE(INTEL, 0xa12a), LPSS_SPT_SSP },
> +	{ },
>   };
>
Oops, thanks for noticing!

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Robert Jarzmik Aug. 5, 2015, 7:07 p.m. UTC | #2
Jarkko Nikula <jarkko.nikula@linux.intel.com> writes:

> On 08/04/2015 08:52 AM, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>

I would have appreciated something in the git commit message, ie :
 - a "Fixes" tag maybe
 - a comment to describe how it was discovered : code reading, testing, etc ...
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

With a better commit message, please have my :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.
diff mbox

Patch

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index e924710..246ffab 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1300,6 +1300,7 @@  static const struct pci_device_id pxa2xx_spi_pci_compound_match[] = {
 	/* SPT-H */
 	{ PCI_VDEVICE(INTEL, 0xa129), LPSS_SPT_SSP },
 	{ PCI_VDEVICE(INTEL, 0xa12a), LPSS_SPT_SSP },
+	{ },
 };
 
 static bool pxa2xx_spi_idma_filter(struct dma_chan *chan, void *param)