From patchwork Tue May 24 02:24:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9132629 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D611A607D3 for ; Tue, 24 May 2016 02:24:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9ACE28221 for ; Tue, 24 May 2016 02:24:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE52E2825C; Tue, 24 May 2016 02:24:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E56428221 for ; Tue, 24 May 2016 02:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbcEXCYl (ORCPT ); Mon, 23 May 2016 22:24:41 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:34554 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216AbcEXCYl (ORCPT ); Mon, 23 May 2016 22:24:41 -0400 Received: by mail-qk0-f196.google.com with SMTP id i7so466947qkd.1 for ; Mon, 23 May 2016 19:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=F8BHAf61n+iyJ5sMAOQX8bAYrrVYAsHvdvjHmUBjEqQ=; b=XvVZrcgOBNOcwpOcxnUFwJJYB7v7YjTMTQzMbvcZIRlIeGO3FY5yLCiw5UrCJCttf/ BODmujx3jFrUgph6zALTSQaLxFhV6RElo1aAZGMhSXqNNZ7166BMavaW0NdIWVE3JRUh OpiiiB6AaNuv+GyRZv86/w4mamYD+HtaHpWtKcN0DCsJUn/rnKm6rQ3u9y9uLyQjvgMb QVkFEQvnsDdN5hLrswJus+bYLojti5tov1aw3SMK/JyFjz+8bnPrQDgRzAXFJde9JZJ8 jTiPRImLSpuW3eXIp4xZoyZlkIV4omc43C73RuqITlWZmK7+6ZhkjCb1Xs7P071QGqP7 CIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=F8BHAf61n+iyJ5sMAOQX8bAYrrVYAsHvdvjHmUBjEqQ=; b=htOaF7SbuYJ2Ii0+R+borh3NVchDqmVfFYJlcJCiM1T8a7pcOcmhzmjYA1vT6QebuQ ry0XMStDiTZ3NbzUzngzIs4G2MIYWES1IgoYGXgwL2CzYxB9E6a6v8RoM7joki2xwsgn qAgSUmuFountQ3gU6ky1V2i5ELHbyt6jHjwDE3oghvZ8kXAvY/fyzKFAP9OEnVp88Wy7 FtcL8y7Jwhkfg3sM/viZ8A5G7b9rAo1+PIVpTxCTMzxtANbuyznesUBy5Sdo6K979RO1 GrZECZJhUugAedv8mI3KHBth+7EmvWEa2icf6GkifKzzq2lWQgtb4FOT96OtrtbC6LnJ jwCA== X-Gm-Message-State: ALyK8tIFzDhH/0YR2Vr3woL5J0f8/TC5SOW7VfnBENagvZLV5fLswcMnzQRuynwAAQFpRg== X-Received: by 10.55.166.139 with SMTP id p133mr1172674qke.161.1464056680165; Mon, 23 May 2016 19:24:40 -0700 (PDT) Received: from localhost.localdomain ([187.180.184.32]) by smtp.gmail.com with ESMTPSA id p109sm2357454qge.38.2016.05.23.19.24.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 May 2016 19:24:39 -0700 (PDT) From: Fabio Estevam To: broonie@kernel.org Cc: linux-spi@vger.kernel.org, Fabio Estevam Subject: [PATCH] spi: spi-ep93xx: Fix the PTR_ERR() argument Date: Mon, 23 May 2016 23:24:21 -0300 Message-Id: <1464056661-7056-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam PTR_ERR should access the value just tested by IS_ERR. The semantic patch that makes this change is available in scripts/coccinelle/tests/odd_ptr_err.cocci. Signed-off-by: Fabio Estevam --- drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index bb00be8..17a6387 100644 --- a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ -567,7 +567,7 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi) txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV); if (IS_ERR(txd)) { ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM); - dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd)); + dev_err(&espi->pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(txd)); msg->status = PTR_ERR(txd); return; }